| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e5d66e75-0de3-b772-2305-7ff1e2f4f9e6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BEA6:1580DD:71AA0:98CD6:6A619A05 |
| html-safe-nonce | 7e7b7ce7d010a7b00e79abfb00c363535e8ee7939d0949e59df14af0cfbb8b09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUE2OjE1ODBERDo3MUFBMDo5OENENjo2QTYxOUEwNSIsInZpc2l0b3JfaWQiOiI3NjQzMDQxNDIwNTMxNTcxMjA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6645bfda4dc5b6adaff24cc5592418ea3759558dca5350c3484137261ac84a01 |
| hovercard-subject-tag | pull_request:2071656788 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/476/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d272f68f161ce5f14a51713515009d23e4b285c5271c0caf892ee54884aef7ff/google/GoogleSignIn-iOS/pull/476 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d272f68f161ce5f14a51713515009d23e4b285c5271c0caf892ee54884aef7ff/google/GoogleSignIn-iOS/pull/476 |
| og:image:alt | This PR fixes an issue introduced by #402 related to AppAuth's use of a nonce, fixes an issue in GSI's -[GIDSignIn maybeFetchToken:], and provides an example in the DaysUntilBirthday app.
I... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mdmathias |
| hostname | github.com |
| expected-hostname | github.com |
| None | c28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c |
| turbo-cache-control | no-cache |
| go-import | github.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 351159356 |
| octolytics-dimension-repository_nwo | google/GoogleSignIn-iOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 351159356 |
| octolytics-dimension-repository_network_root_nwo | google/GoogleSignIn-iOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd05235d52ffb3318513d883a56c87a121015c8b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/google/GoogleSignIn-iOS/pull/476#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
|
google
| https://github.com/google |
| GoogleSignIn-iOS | https://github.com/google/GoogleSignIn-iOS |
|
Notifications
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Fork
276
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Star
733
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
79
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
3
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
0
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
| mdmathias | https://github.com/mdmathias |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| mdmathias/fix-manual-nonce | https://github.com/google/GoogleSignIn-iOS/tree/mdmathias/fix-manual-nonce |
| Conversation | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| Commits6 (6) | https://github.com/google/GoogleSignIn-iOS/pull/476/commits |
| Checks | https://github.com/google/GoogleSignIn-iOS/pull/476/checks |
| Files changed | https://github.com/google/GoogleSignIn-iOS/pull/476/files |
| Fix passing nil for nonce and add example | https://github.com/google/GoogleSignIn-iOS/pull/476#top |
| mdmathias | https://github.com/mdmathias |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| mdmathias/fix-manual-nonce | https://github.com/google/GoogleSignIn-iOS/tree/mdmathias/fix-manual-nonce |
|
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| Sep 13, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issue-2525682359 |
| #402 | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| #402 | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| #402 | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| OIDAuthorizationRequest initializer | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| #402 | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| -[GIDSignInOptions nonce] | https://github.com/google/GoogleSignIn-iOS/pull/402/files#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640R735 |
| this initializer | https://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationRequest.m#L224 |
| pass nil for the last authorization response | https://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationService.m#L425 |
| nonce would be nil | https://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationService.m#L641 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
|
| https://github.com/mdmathias |
| Fix passing nil for nonce and add example | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/20da986c25cfef84282c674a8e020cc8fd698d60 |
| 20da986 | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/20da986c25cfef84282c674a8e020cc8fd698d60 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| brnnmrls | https://github.com/brnnmrls |
| ch40w31 | https://github.com/ch40w31 |
| yalkhder | https://github.com/yalkhder |
| September 13, 2024 20:53 | https://github.com/google/GoogleSignIn-iOS/pull/476#event-14254392918 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| Sep 13, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2350155339 |
| @vonovak | https://github.com/vonovak |
| #402 | https://github.com/google/GoogleSignIn-iOS/pull/402 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| mdmathias | https://github.com/mdmathias |
| September 13, 2024 14:01 | https://github.com/google/GoogleSignIn-iOS/pull/476#commits-pushed-05b8ac9 |
|
| https://github.com/mdmathias |
| Update print message in sample to be assertionFailure | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/05b8ac96d1a2ba6d2bdc468d49392888ab41576f |
| 05b8ac9 | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/05b8ac96d1a2ba6d2bdc468d49392888ab41576f |
|
| https://github.com/mdmathias |
| Add missing space in comment | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/3a58e5e1324c62e442cb1287d189f8ab8e9aa101 |
| 3a58e5e | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/3a58e5e1324c62e442cb1287d189f8ab8e9aa101 |
|
| https://github.com/mdmathias |
| Fix GIDSignInTest to stub correct token request method | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/030294edc0873340d0f39bd132bce83f55b61826 |
| 030294e | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/030294edc0873340d0f39bd132bce83f55b61826 |
| https://github.com/brnnmrls |
| brnnmrls | https://github.com/brnnmrls |
|
Sep 17, 2024
| https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310206530 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
| https://github.com/vonovak |
| vonovak | https://github.com/vonovak |
|
Sep 17, 2024
| https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310897156 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
| vonovak | https://github.com/vonovak |
| https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310897156 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| Samples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift | https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826#diff-a18bf9862b63c8fcf732be6666ae2053d01622aaeb722583dbbdca31a8aeaab6 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| https://github.com/yalkhder |
| yalkhder | https://github.com/yalkhder |
|
Oct 1, 2024
| https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2322891998 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
| GoogleSignIn/Sources/GIDSignIn.m | https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
|
| https://github.com/mdmathias |
| Update identation | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/7d6dbb83e41a7e8d0f96de0783438372fe816ba6 |
| 7d6dbb8 | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/7d6dbb83e41a7e8d0f96de0783438372fe816ba6 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| Oct 3, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2392206492 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
|
| https://github.com/mdmathias |
| Merge branch 'main' into mdmathias/fix-manual-nonce | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/67a79f6129e800fad047a28c33aee24c04aa74b3 |
| 67a79f6 | https://github.com/google/GoogleSignIn-iOS/pull/476/commits/67a79f6129e800fad047a28c33aee24c04aa74b3 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| 72b9e63 | https://github.com/google/GoogleSignIn-iOS/commit/72b9e63074b213f58a28ff14f8bebb31ca4bdf6e |
| Oct 3, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#event-14509620790 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| October 3, 2024 19:49 | https://github.com/google/GoogleSignIn-iOS/pull/476#event-14509621009 |
| https://github.com/riderx |
| riderx | https://github.com/riderx |
| Oct 4, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2392617731 |
| @mdmathias | https://github.com/mdmathias |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| https://github.com/vonovak |
| vonovak | https://github.com/vonovak |
| Oct 17, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2419459004 |
| @mdmathias | https://github.com/mdmathias |
| openid/AppAuth-iOS#788 | https://github.com/openid/AppAuth-iOS/pull/788 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| https://github.com/brnnmrls |
| brnnmrls | https://github.com/brnnmrls |
| Oct 17, 2024 | https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2420577428 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
| https://github.com/yuanfuautotrader |
| yuanfuautotrader | https://github.com/yuanfuautotrader |
|
Apr 10, 2025
| https://github.com/google/GoogleSignIn-iOS/pull/476#ref-issue-2984189135 |
|
Google Sign In iOS nonce integration with their latest version 8.1.0-vwg-eap-1.0.0
supabase/supabase#34874
| https://github.com/supabase/supabase/issues/34874 |
| https://github.co/hiddenchars |
| https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476 |
|
| https://github.com/yalkhder |
|
yalkhder
| https://github.com/yalkhder |
|
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
|
| https://github.com/brnnmrls |
|
brnnmrls
| https://github.com/brnnmrls |
|
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
|
| https://github.com/ch40w31 |
|
ch40w31
| https://github.com/ch40w31 |
|
| https://github.com/vonovak |
|
vonovak
| https://github.com/vonovak |
|
| https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/476 |
|
| https://github.com/mdmathias |
|
| https://github.com/riderx |
|
| https://github.com/vonovak |
|
| https://github.com/brnnmrls |
|
| https://github.com/yalkhder |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |