René's URL Explorer Experiment


Title: Fix passing nil for nonce and add example by mdmathias · Pull Request #476 · google/GoogleSignIn-iOS · GitHub

Open Graph Title: Fix passing nil for nonce and add example by mdmathias · Pull Request #476 · google/GoogleSignIn-iOS

X Title: Fix passing nil for nonce and add example by mdmathias · Pull Request #476 · google/GoogleSignIn-iOS

Description: Enables iOS and macOS apps to sign in with Google. - Fix passing nil for nonce and add example by mdmathias · Pull Request #476 · google/GoogleSignIn-iOS

Open Graph Description: This PR fixes an issue introduced by #402 related to AppAuth's use of a nonce, fixes an issue in GSI's -[GIDSignIn maybeFetchToken:], and provides an example in the DaysUntilBirthday app. I...

X Description: This PR fixes an issue introduced by #402 related to AppAuth's use of a nonce, fixes an issue in GSI's -[GIDSignIn maybeFetchToken:], and provides an example in the DaysUntilBirthda...

Opengraph URL: https://github.com/google/GoogleSignIn-iOS/pull/476

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5d66e75-0de3-b772-2305-7ff1e2f4f9e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEA6:1580DD:71AA0:98CD6:6A619A05
html-safe-nonce7e7b7ce7d010a7b00e79abfb00c363535e8ee7939d0949e59df14af0cfbb8b09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUE2OjE1ODBERDo3MUFBMDo5OENENjo2QTYxOUEwNSIsInZpc2l0b3JfaWQiOiI3NjQzMDQxNDIwNTMxNTcxMjA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6645bfda4dc5b6adaff24cc5592418ea3759558dca5350c3484137261ac84a01
hovercard-subject-tagpull_request:2071656788
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/476/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d272f68f161ce5f14a51713515009d23e4b285c5271c0caf892ee54884aef7ff/google/GoogleSignIn-iOS/pull/476
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d272f68f161ce5f14a51713515009d23e4b285c5271c0caf892ee54884aef7ff/google/GoogleSignIn-iOS/pull/476
og:image:altThis PR fixes an issue introduced by #402 related to AppAuth's use of a nonce, fixes an issue in GSI's -[GIDSignIn maybeFetchToken:], and provides an example in the DaysUntilBirthday app. I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdmathias
hostnamegithub.com
expected-hostnamegithub.com
Nonec28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c
turbo-cache-controlno-cache
go-importgithub.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id351159356
octolytics-dimension-repository_nwogoogle/GoogleSignIn-iOS
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id351159356
octolytics-dimension-repository_network_root_nwogoogle/GoogleSignIn-iOS
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecd05235d52ffb3318513d883a56c87a121015c8b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/google/GoogleSignIn-iOS/pull/476#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/476
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/476
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/476
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
google https://github.com/google
GoogleSignIn-iOShttps://github.com/google/GoogleSignIn-iOS
Notifications https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Fork 276 https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Star 733 https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Code https://github.com/google/GoogleSignIn-iOS
Issues 79 https://github.com/google/GoogleSignIn-iOS/issues
Pull requests 3 https://github.com/google/GoogleSignIn-iOS/pulls
Actions https://github.com/google/GoogleSignIn-iOS/actions
Projects https://github.com/google/GoogleSignIn-iOS/projects
Security and quality 0 https://github.com/google/GoogleSignIn-iOS/security
Insights https://github.com/google/GoogleSignIn-iOS/pulse
Code https://github.com/google/GoogleSignIn-iOS
Issues https://github.com/google/GoogleSignIn-iOS/issues
Pull requests https://github.com/google/GoogleSignIn-iOS/pulls
Actions https://github.com/google/GoogleSignIn-iOS/actions
Projects https://github.com/google/GoogleSignIn-iOS/projects
Security and quality https://github.com/google/GoogleSignIn-iOS/security
Insights https://github.com/google/GoogleSignIn-iOS/pulse
mdmathiashttps://github.com/mdmathias
mainhttps://github.com/google/GoogleSignIn-iOS/tree/main
mdmathias/fix-manual-noncehttps://github.com/google/GoogleSignIn-iOS/tree/mdmathias/fix-manual-nonce
Conversationhttps://github.com/google/GoogleSignIn-iOS/pull/476
Commits6 (6)https://github.com/google/GoogleSignIn-iOS/pull/476/commits
Checkshttps://github.com/google/GoogleSignIn-iOS/pull/476/checks
Files changedhttps://github.com/google/GoogleSignIn-iOS/pull/476/files
Fix passing nil for nonce and add examplehttps://github.com/google/GoogleSignIn-iOS/pull/476#top
mdmathiashttps://github.com/mdmathias
mainhttps://github.com/google/GoogleSignIn-iOS/tree/main
mdmathias/fix-manual-noncehttps://github.com/google/GoogleSignIn-iOS/tree/mdmathias/fix-manual-nonce
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Sep 13, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issue-2525682359
#402https://github.com/google/GoogleSignIn-iOS/pull/402
#402https://github.com/google/GoogleSignIn-iOS/pull/402
#402https://github.com/google/GoogleSignIn-iOS/pull/402
OIDAuthorizationRequest initializerhttps://github.com/google/GoogleSignIn-iOS/pull/402
#402https://github.com/google/GoogleSignIn-iOS/pull/402
-[GIDSignInOptions nonce]https://github.com/google/GoogleSignIn-iOS/pull/402/files#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640R735
this initializerhttps://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationRequest.m#L224
pass nil for the last authorization responsehttps://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationService.m#L425
nonce would be nilhttps://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuthCore/OIDAuthorizationService.m#L641
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/mdmathias
Fix passing nil for nonce and add examplehttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/20da986c25cfef84282c674a8e020cc8fd698d60
20da986https://github.com/google/GoogleSignIn-iOS/pull/476/commits/20da986c25cfef84282c674a8e020cc8fd698d60
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
brnnmrlshttps://github.com/brnnmrls
ch40w31https://github.com/ch40w31
yalkhderhttps://github.com/yalkhder
September 13, 2024 20:53https://github.com/google/GoogleSignIn-iOS/pull/476#event-14254392918
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Sep 13, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2350155339
@vonovakhttps://github.com/vonovak
#402https://github.com/google/GoogleSignIn-iOS/pull/402
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
mdmathiashttps://github.com/mdmathias
September 13, 2024 14:01https://github.com/google/GoogleSignIn-iOS/pull/476#commits-pushed-05b8ac9
https://github.com/mdmathias
Update print message in sample to be assertionFailurehttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/05b8ac96d1a2ba6d2bdc468d49392888ab41576f
05b8ac9https://github.com/google/GoogleSignIn-iOS/pull/476/commits/05b8ac96d1a2ba6d2bdc468d49392888ab41576f
https://github.com/mdmathias
Add missing space in commenthttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/3a58e5e1324c62e442cb1287d189f8ab8e9aa101
3a58e5ehttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/3a58e5e1324c62e442cb1287d189f8ab8e9aa101
https://github.com/mdmathias
Fix GIDSignInTest to stub correct token request methodhttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/030294edc0873340d0f39bd132bce83f55b61826
030294ehttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/030294edc0873340d0f39bd132bce83f55b61826
https://github.com/brnnmrls
brnnmrlshttps://github.com/brnnmrls
Sep 17, 2024 https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310206530
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
https://github.com/vonovak
vonovakhttps://github.com/vonovak
Sep 17, 2024 https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310897156
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
vonovakhttps://github.com/vonovak
https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2310897156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
Samples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swifthttps://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826#diff-a18bf9862b63c8fcf732be6666ae2053d01622aaeb722583dbbdca31a8aeaab6
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/yalkhder
yalkhderhttps://github.com/yalkhder
Oct 1, 2024 https://github.com/google/GoogleSignIn-iOS/pull/476#pullrequestreview-2322891998
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
GoogleSignIn/Sources/GIDSignIn.mhttps://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/mdmathias
Update identationhttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/7d6dbb83e41a7e8d0f96de0783438372fe816ba6
7d6dbb8https://github.com/google/GoogleSignIn-iOS/pull/476/commits/7d6dbb83e41a7e8d0f96de0783438372fe816ba6
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Oct 3, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2392206492
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/mdmathias
Merge branch 'main' into mdmathias/fix-manual-noncehttps://github.com/google/GoogleSignIn-iOS/pull/476/commits/67a79f6129e800fad047a28c33aee24c04aa74b3
67a79f6https://github.com/google/GoogleSignIn-iOS/pull/476/commits/67a79f6129e800fad047a28c33aee24c04aa74b3
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
72b9e63https://github.com/google/GoogleSignIn-iOS/commit/72b9e63074b213f58a28ff14f8bebb31ca4bdf6e
Oct 3, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#event-14509620790
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
October 3, 2024 19:49https://github.com/google/GoogleSignIn-iOS/pull/476#event-14509621009
https://github.com/riderx
riderxhttps://github.com/riderx
Oct 4, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2392617731
@mdmathiashttps://github.com/mdmathias
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/vonovak
vonovakhttps://github.com/vonovak
Oct 17, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2419459004
@mdmathiashttps://github.com/mdmathias
openid/AppAuth-iOS#788https://github.com/openid/AppAuth-iOS/pull/788
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/brnnmrls
brnnmrlshttps://github.com/brnnmrls
Oct 17, 2024https://github.com/google/GoogleSignIn-iOS/pull/476#issuecomment-2420577428
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/yuanfuautotrader
yuanfuautotraderhttps://github.com/yuanfuautotrader
Apr 10, 2025 https://github.com/google/GoogleSignIn-iOS/pull/476#ref-issue-2984189135
Google Sign In iOS nonce integration with their latest version 8.1.0-vwg-eap-1.0.0 supabase/supabase#34874 https://github.com/supabase/supabase/issues/34874
https://github.co/hiddenchars
https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F476
https://github.com/yalkhder
yalkhder https://github.com/yalkhder
https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
https://github.com/brnnmrls
brnnmrls https://github.com/brnnmrls
https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
https://github.com/ch40w31
ch40w31 https://github.com/ch40w31
https://github.com/vonovak
vonovak https://github.com/vonovak
https://github.com/google/GoogleSignIn-iOS/pull/476/files/030294edc0873340d0f39bd132bce83f55b61826
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/476
https://github.com/mdmathias
https://github.com/riderx
https://github.com/vonovak
https://github.com/brnnmrls
https://github.com/yalkhder
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.