René's URL Explorer Experiment


Title: Fix the restorePreviousSignIn when completion is nil by henryhl22321 · Pull Request #301 · google/GoogleSignIn-iOS · GitHub

Open Graph Title: Fix the restorePreviousSignIn when completion is nil by henryhl22321 · Pull Request #301 · google/GoogleSignIn-iOS

X Title: Fix the restorePreviousSignIn when completion is nil by henryhl22321 · Pull Request #301 · google/GoogleSignIn-iOS

Description: Enables iOS and macOS apps to sign in with Google. - Fix the restorePreviousSignIn when completion is nil by henryhl22321 · Pull Request #301 · google/GoogleSignIn-iOS

Open Graph Description: Return to void and not trigger the callback when the completion is nil.

X Description: Return to void and not trigger the callback when the completion is nil.

Opengraph URL: https://github.com/google/GoogleSignIn-iOS/pull/301

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a7afd25e-a4cb-9925-fa8f-8ef9d3a6ed1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9416:129517:B097F3:EBDAC1:6A62B518
html-safe-nonce33b28c5e2112b68b04d89a232dd7b06ff020adebbce57fa4e7945648e263dd10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDE2OjEyOTUxNzpCMDk3RjM6RUJEQUMxOjZBNjJCNTE4IiwidmlzaXRvcl9pZCI6Ijc2OTI2MDk4NjE0MzMwNzkwNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac05acad7d8d33fc5660bd511f62b20a53c5c6f0d50abcd0d42e4883fbaf423f3e
hovercard-subject-tagpull_request:1320651536
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/301/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd423a98fc65cc653d509502485b4350e2224f0be73fe2018d0b3c7e06378d6f/google/GoogleSignIn-iOS/pull/301
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd423a98fc65cc653d509502485b4350e2224f0be73fe2018d0b3c7e06378d6f/google/GoogleSignIn-iOS/pull/301
og:image:altReturn to void and not trigger the callback when the completion is nil.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehenryhl22321
hostnamegithub.com
expected-hostnamegithub.com
None2738d7125e864b55224a8bc40c72c220ca7d2c73f91a7bb8d69dffe9d35e997d
turbo-cache-controlno-cache
go-importgithub.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git
octolytics-dimension-user_id1342004
octolytics-dimension-user_logingoogle
octolytics-dimension-repository_id351159356
octolytics-dimension-repository_nwogoogle/GoogleSignIn-iOS
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id351159356
octolytics-dimension-repository_network_root_nwogoogle/GoogleSignIn-iOS
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebf54af498459157b66a67136f992a68752cdbb54
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/google/GoogleSignIn-iOS/pull/301#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F301
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F301
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/301
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/301
Reloadhttps://github.com/google/GoogleSignIn-iOS/pull/301
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
google https://github.com/google
GoogleSignIn-iOShttps://github.com/google/GoogleSignIn-iOS
Notifications https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Fork 276 https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Star 733 https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS
Code https://github.com/google/GoogleSignIn-iOS
Issues 79 https://github.com/google/GoogleSignIn-iOS/issues
Pull requests 4 https://github.com/google/GoogleSignIn-iOS/pulls
Actions https://github.com/google/GoogleSignIn-iOS/actions
Projects https://github.com/google/GoogleSignIn-iOS/projects
Security and quality 0 https://github.com/google/GoogleSignIn-iOS/security
Insights https://github.com/google/GoogleSignIn-iOS/pulse
Code https://github.com/google/GoogleSignIn-iOS
Issues https://github.com/google/GoogleSignIn-iOS/issues
Pull requests https://github.com/google/GoogleSignIn-iOS/pulls
Actions https://github.com/google/GoogleSignIn-iOS/actions
Projects https://github.com/google/GoogleSignIn-iOS/projects
Security and quality https://github.com/google/GoogleSignIn-iOS/security
Insights https://github.com/google/GoogleSignIn-iOS/pulse
henryhl22321https://github.com/henryhl22321
mainhttps://github.com/google/GoogleSignIn-iOS/tree/main
hengyul/bug-fixhttps://github.com/google/GoogleSignIn-iOS/tree/hengyul/bug-fix
Conversationhttps://github.com/google/GoogleSignIn-iOS/pull/301
Commits6 (6)https://github.com/google/GoogleSignIn-iOS/pull/301/commits
Checkshttps://github.com/google/GoogleSignIn-iOS/pull/301/checks
Files changedhttps://github.com/google/GoogleSignIn-iOS/pull/301/files
Fix the restorePreviousSignIn when completion is nilhttps://github.com/google/GoogleSignIn-iOS/pull/301#top
henryhl22321https://github.com/henryhl22321
mainhttps://github.com/google/GoogleSignIn-iOS/tree/main
hengyul/bug-fixhttps://github.com/google/GoogleSignIn-iOS/tree/hengyul/bug-fix
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
Apr 19, 2023https://github.com/google/GoogleSignIn-iOS/pull/301#issue-1675742997
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
mdmathiashttps://github.com/mdmathias
April 19, 2023 22:50https://github.com/google/GoogleSignIn-iOS/pull/301#event-9051521560
https://github.com/ch40w31
ch40w31https://github.com/ch40w31
Apr 20, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1393038768
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Apr 20, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1394478606
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Apr 20, 2023https://github.com/google/GoogleSignIn-iOS/pull/301#issuecomment-1516748624
@henryhl22321https://github.com/henryhl22321
#302https://github.com/google/GoogleSignIn-iOS/pull/302
#302https://github.com/google/GoogleSignIn-iOS/pull/302
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Apr 26, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1402361063
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
ch40w31https://github.com/ch40w31
mdmathiashttps://github.com/mdmathias
April 27, 2023 07:12https://github.com/google/GoogleSignIn-iOS/pull/301#event-9110892776
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Apr 27, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1404767653
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
Apr 29, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1406746881
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files
GoogleSignIn/Tests/Unit/GIDSignInTest.mhttps://github.com/google/GoogleSignIn-iOS/pull/301/files#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
May 2, 2023https://github.com/google/GoogleSignIn-iOS/pull/301#event-9149569992
restorePreviousSignInWithCompletion() call crash if the completion is null #289 https://github.com/google/GoogleSignIn-iOS/issues/289
https://github.com/mdmathias
mdmathiashttps://github.com/mdmathias
May 3, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1411667726
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
henryhl22321https://github.com/henryhl22321
May 3, 2023 19:29https://github.com/google/GoogleSignIn-iOS/pull/301#commits-pushed-01bb8dd
https://github.com/henryhl22321
Fix the restorePreviousSignIn when completion is nilhttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/01bb8dd5304b8b7122cedd2af155079393a480d2
01bb8ddhttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/01bb8dd5304b8b7122cedd2af155079393a480d2
https://github.com/henryhl22321
Add restorePreviousSignIn test case when completion is nilhttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/7d35a42fdeab33f70a481c688c3ff9320b0af3ca
7d35a42https://github.com/google/GoogleSignIn-iOS/pull/301/commits/7d35a42fdeab33f70a481c688c3ff9320b0af3ca
https://github.com/henryhl22321
Fixed the test problem from comments.https://github.com/google/GoogleSignIn-iOS/pull/301/commits/b6210ac63bd11ed113e8796a114a2567011df13f
b6210achttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/b6210ac63bd11ed113e8796a114a2567011df13f
https://github.com/henryhl22321
Add the value to verify the _signIn.currentUserhttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/bbb0cd4b2188eb5f74725b13d0e8b88a16ebfb3d
bbb0cd4https://github.com/google/GoogleSignIn-iOS/pull/301/commits/bbb0cd4b2188eb5f74725b13d0e8b88a16ebfb3d
https://github.com/henryhl22321
Removed the mocked user data comparison, add TODO for using the real …https://github.com/google/GoogleSignIn-iOS/pull/301/commits/fa25c23e202edc5fb879a8b866866b960165d431
fa25c23https://github.com/google/GoogleSignIn-iOS/pull/301/commits/fa25c23e202edc5fb879a8b866866b960165d431
https://github.com/henryhl22321
Removed the unused importhttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
a8ce59ehttps://github.com/google/GoogleSignIn-iOS/pull/301/commits/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
force-pushedhttps://github.com/google/GoogleSignIn-iOS/compare/6b4871abf2fbc984c54f80882b4e69ad4a89a7ad..a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
6b4871ahttps://github.com/google/GoogleSignIn-iOS/commit/6b4871abf2fbc984c54f80882b4e69ad4a89a7ad
a8ce59ehttps://github.com/google/GoogleSignIn-iOS/commit/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
Compare https://github.com/google/GoogleSignIn-iOS/compare/6b4871abf2fbc984c54f80882b4e69ad4a89a7ad..a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
May 4, 2023 02:29https://github.com/google/GoogleSignIn-iOS/pull/301#event-9162081926
https://github.com/ch40w31
ch40w31https://github.com/ch40w31
May 4, 2023 https://github.com/google/GoogleSignIn-iOS/pull/301#pullrequestreview-1413651172
View reviewed changes https://github.com/google/GoogleSignIn-iOS/pull/301/files/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
6a329cbhttps://github.com/google/GoogleSignIn-iOS/commit/6a329cbf4fe308d0a3bfe7cc8effa86b3182ccbb
May 4, 2023https://github.com/google/GoogleSignIn-iOS/pull/301#event-9170227764
https://github.com/henryhl22321
henryhl22321https://github.com/henryhl22321
May 4, 2023 18:14https://github.com/google/GoogleSignIn-iOS/pull/301#event-9170227911
https://github.co/hiddenchars
https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F301
https://github.com/mdmathias
mdmathias https://github.com/mdmathias
https://github.com/google/GoogleSignIn-iOS/pull/301/files/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
https://github.com/ch40w31
ch40w31 https://github.com/ch40w31
https://github.com/google/GoogleSignIn-iOS/pull/301/files/a8ce59e809aa3e6ac7b5833d6b182224211ed8ca
restorePreviousSignInWithCompletion() call crash if the completion is null https://github.com/google/GoogleSignIn-iOS/issues/289
Please reload this pagehttps://github.com/google/GoogleSignIn-iOS/pull/301
https://github.com/henryhl22321
https://github.com/mdmathias
https://github.com/ch40w31
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.