| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:29d7f02f-2267-6694-d4b6-229f622e68c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4BA:246E06:2EC571:431D7F:6A61E394 |
| html-safe-nonce | 217f6f33bef2ce89269999d6ca231e7c04065e85a2b9839a3f764acd9eebabfa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEJBOjI0NkUwNjoyRUM1NzE6NDMxRDdGOjZBNjFFMzk0IiwidmlzaXRvcl9pZCI6IjQ3NDE1NDE3NDkzNjE1OTkzODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a8d95ff35fe9c62a3c0d1aa701b1e79c738d7f8ea49b30848b138daffa82c9de |
| hovercard-subject-tag | pull_request:1292068969 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/299/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7f1a1e2564bf3d37ebf0b6de911aed77fb089e43850db08493eb355c2b50df06/google/GoogleSignIn-iOS/pull/299 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f1a1e2564bf3d37ebf0b6de911aed77fb089e43850db08493eb355c2b50df06/google/GoogleSignIn-iOS/pull/299 |
| og:image:alt | GTMAppAuth added a new protocol to provide an interface for dependencies to both add additional token refresh parameters and update errors issued by GTMAppAuth. The latter is especially for the cas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mdmathias |
| hostname | github.com |
| expected-hostname | github.com |
| None | b2de8c74e5e61e893155ba46ee41bc66170c1644cb795adefa8386d490f7781c |
| turbo-cache-control | no-cache |
| go-import | github.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 351159356 |
| octolytics-dimension-repository_nwo | google/GoogleSignIn-iOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 351159356 |
| octolytics-dimension-repository_network_root_nwo | google/GoogleSignIn-iOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1866027ded575df8a15c731dd8b9986c9483ceb |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/google/GoogleSignIn-iOS/pull/299#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F299 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F299 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
|
google
| https://github.com/google |
| GoogleSignIn-iOS | https://github.com/google/GoogleSignIn-iOS |
|
Notifications
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Fork
276
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Star
733
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
79
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
3
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
0
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
| mdmathias | https://github.com/mdmathias |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| mdmathias/gtmaa-error-handling | https://github.com/google/GoogleSignIn-iOS/tree/mdmathias/gtmaa-error-handling |
| Conversation | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Commits38 (38) | https://github.com/google/GoogleSignIn-iOS/pull/299/commits |
| Checks | https://github.com/google/GoogleSignIn-iOS/pull/299/checks |
| Files changed | https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| Use GTMAppAuth's new delegate protocol | https://github.com/google/GoogleSignIn-iOS/pull/299#top |
| mdmathias | https://github.com/mdmathias |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| mdmathias/gtmaa-error-handling | https://github.com/google/GoogleSignIn-iOS/tree/mdmathias/gtmaa-error-handling |
|
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| Mar 27, 2023 | https://github.com/google/GoogleSignIn-iOS/pull/299#issue-1642890978 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GTMAppAuth added a new protocol | https://github.com/google/GTMAppAuth/pull/224 |
| #304 | https://github.com/google/GoogleSignIn-iOS/issues/304 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| XiangtianDai | https://github.com/XiangtianDai |
| ch40w31 | https://github.com/ch40w31 |
| April 12, 2023 20:53 | https://github.com/google/GoogleSignIn-iOS/pull/299#event-8989874602 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Apr 12, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1382137887 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| Samples/ObjC/SignInSample/Source/Empty.swift | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-776152aeca346915421548c29a1bd134bb78de6596b128e364d8fb35fcb0a600 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Samples/ObjC/SignInSample/Source/Empty.swift | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-776152aeca346915421548c29a1bd134bb78de6596b128e364d8fb35fcb0a600 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Samples/Swift/DaysUntilBirthday/Podfile | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-3e453e0ed0c06c59b70d745a63760750df541c6ed37ca35cbf9a665d02a5a39c |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDAuthStateMigration.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-84143022462acf558036edb20e0c0e2af81d8a8a747628613ebeafbfb55db756 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-08f8a82772be314a9a83a0d6dd3881bd23053792d8de6f8410baaef6705301ad |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDEMMSupportTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-d51db5f699811af5b19c97475580c64f1c9bb2dd709c88041740e671b10e44db |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDFailingOIDAuthState.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-e800543c59583d9daf8420c6d15f9ddd9213ed935c02cf22893812a88e63ee96 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDFakeFetcher.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-1059cb1a58f2e131b6aba5aae87308c9133f9f6b893579a7129c1a6b951e2b0d |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDGoogleUserTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-8e471926eb28e7f394afeb1eb65a3b124bb41a813b33bf1387e36d50bba7dbe1 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDEMMSupportTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-d51db5f699811af5b19c97475580c64f1c9bb2dd709c88041740e671b10e44db |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Apr 13, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1383831251 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| GoogleSignIn/Sources/GIDAuthStateMigration.h | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-509ef4be1603d50b1e05093b40e6f035de4f577d3e425db1c626015208211872 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDAuthStateMigration.h | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-509ef4be1603d50b1e05093b40e6f035de4f577d3e425db1c626015208211872 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-08f8a82772be314a9a83a0d6dd3881bd23053792d8de6f8410baaef6705301ad |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDEMMSupportTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-d51db5f699811af5b19c97475580c64f1c9bb2dd709c88041740e671b10e44db |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/paulb777 |
| paulb777 | https://github.com/paulb777 |
|
Apr 13, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1384189106 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| .github/workflows/unit_tests.yml | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69a |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn.podspec | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-39c6c47f6e1a47d9a646ea4b0f0957b5bd0c988d3ef207d7ce55c7aa51d8b1cb |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| Package.swift | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-f913940c58e8744a2af1c68b909bb6383e49007e6c5a12fb03104a9006ae677e |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/paulb777 |
| paulb777 | https://github.com/paulb777 |
|
Apr 14, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1385727932 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| paulb777 | https://github.com/paulb777 |
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1385727932 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/XiangtianDai |
| XiangtianDai | https://github.com/XiangtianDai |
|
Apr 21, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1396475363 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| GoogleSignIn/Sources/GIDEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-08f8a82772be314a9a83a0d6dd3881bd23053792d8de6f8410baaef6705301ad |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-08f8a82772be314a9a83a0d6dd3881bd23053792d8de6f8410baaef6705301ad |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-9cace522c90e87250974691440a8c5b326a16fc5a5a0e1e7faaec2e2247c3b93 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
|
Apr 22, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#ref-pullrequest-1679693555 |
|
Add a method taking a completion argument for asynchronous error updates
google/GTMAppAuth#229
| https://github.com/google/GTMAppAuth/pull/229 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/0764b95b93340ed1418b651a41f484e770ceb691..bb10b392fb392af5b9795d7d9e15e795406db401 |
| 0764b95 | https://github.com/google/GoogleSignIn-iOS/commit/0764b95b93340ed1418b651a41f484e770ceb691 |
| bb10b39 | https://github.com/google/GoogleSignIn-iOS/commit/bb10b392fb392af5b9795d7d9e15e795406db401 |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/0764b95b93340ed1418b651a41f484e770ceb691..bb10b392fb392af5b9795d7d9e15e795406db401 |
| April 28, 2023 23:16 | https://github.com/google/GoogleSignIn-iOS/pull/299#event-9128958759 |
| https://github.com/XiangtianDai |
| XiangtianDai | https://github.com/XiangtianDai |
|
May 9, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1419472268 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files |
| mdmathias | https://github.com/mdmathias |
| May 15, 2023 18:00 | https://github.com/google/GoogleSignIn-iOS/pull/299#commits-pushed-528e534 |
|
| https://github.com/mdmathias |
| Initial setup for GTMAA error handling | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/528e534dc77b914deb8f3de0b38afb550e54bdbc |
| 528e534 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/528e534dc77b914deb8f3de0b38afb550e54bdbc |
|
| https://github.com/mdmathias |
| Set the authorizer on the fetcher | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/0600090e719a884471351607970d5581653e2bba |
| 0600090 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/0600090e719a884471351607970d5581653e2bba |
|
| https://github.com/mdmathias |
| Add the error handling delegate on the authorization | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e25d0440297868b73114b0389aba3a49ae7c8165 |
| e25d044 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e25d0440297868b73114b0389aba3a49ae7c8165 |
|
| https://github.com/mdmathias |
| Add some support for testing emm support | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/aea7ec0e407849faf3f07f34a26fd1790878fa39 |
| aea7ec0 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/aea7ec0e407849faf3f07f34a26fd1790878fa39 |
|
| https://github.com/mdmathias |
| Do not expose method creating fetcher with an error as unneeded | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/99b73d22c8372c12ad8831a1238697370a8c5ac8 |
| 99b73d2 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/99b73d22c8372c12ad8831a1238697370a8c5ac8 |
|
| https://github.com/mdmathias |
| Add test for testing EMM error handling flow with GTMAppAuth | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/193ea42d977bc82f5383ba0e2c63e53b1b6dd12e |
| 193ea42 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/193ea42d977bc82f5383ba0e2c63e53b1b6dd12e |
|
| https://github.com/mdmathias |
| Add doc comments to GIDEMMSupport | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/0eb2f1f5f08e65d5bda255eea75e570a5132903a |
| 0eb2f1f | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/0eb2f1f5f08e65d5bda255eea75e570a5132903a |
|
| https://github.com/mdmathias |
| Fix GIDAuthStateMigrationTest | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/bd8325ee0b837f8deb3aa598f7888d0c7b757656 |
| bd8325e | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/bd8325ee0b837f8deb3aa598f7888d0c7b757656 |
|
| https://github.com/mdmathias |
| Fix most of GIDSignInTests | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/4e2ee95a329d3862176fd3c0c82d96afa2a76bff |
| 4e2ee95 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/4e2ee95a329d3862176fd3c0c82d96afa2a76bff |
|
| https://github.com/mdmathias |
| Fix GIDSignInTest | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b9d9b8f2d24534490b430485c5841566bdbbfdef |
| b9d9b8f | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b9d9b8f2d24534490b430485c5841566bdbbfdef |
|
| https://github.com/mdmathias |
| Some cocoapods import fixes | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/96c8c3b0c88898f6281d97727c00022647cb86b4 |
| 96c8c3b | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/96c8c3b0c88898f6281d97727c00022647cb86b4 |
|
| https://github.com/mdmathias |
| Do not forward declare protocol conformance | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/55aeb46db8ced02e64dffcb65c5e705ef5668ff4 |
| 55aeb46 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/55aeb46db8ced02e64dffcb65c5e705ef5668ff4 |
|
| https://github.com/mdmathias |
| Bump dependencies for AppAuth-iOS and GTMAppAuth | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/614111fc22019a9c2863f5b8c660ef208c31fe68 |
| 614111f | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/614111fc22019a9c2863f5b8c660ef208c31fe68 |
|
| https://github.com/mdmathias |
| Update sample apps | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/c024c5284b2d17917613422d5fa5d9c71f30a621 |
| c024c52 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/c024c5284b2d17917613422d5fa5d9c71f30a621 |
|
| https://github.com/mdmathias |
| Use frameworks with static linkage in Swift sample | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/4febcdb6c9c0d0625df473ac78f5fda46191e280 |
| 4febcdb | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/4febcdb6c9c0d0625df473ac78f5fda46191e280 |
|
| https://github.com/mdmathias |
| Remove use_libraries and use_static_frameworks flags from pod lib lint | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/52cef300ef005d8cb8eed8293dcf49b484764dfa |
| 52cef30 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/52cef300ef005d8cb8eed8293dcf49b484764dfa |
|
| https://github.com/mdmathias |
| Add swift version | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e113cdb38f73b46996221ea25dbd61ffc78682d9 |
| e113cdb | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e113cdb38f73b46996221ea25dbd61ffc78682d9 |
|
| https://github.com/mdmathias |
| Clean up imports | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/a8aa402090672f70370f385ca94847345ab4dbff |
| a8aa402 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/a8aa402090672f70370f385ca94847345ab4dbff |
|
| https://github.com/mdmathias |
| Fix typos and alignment issues from PR feedback | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/d4df1fce4f147c91c35d074e2e2287e444b46846 |
| d4df1fc | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/d4df1fce4f147c91c35d074e2e2287e444b46846 |
|
| https://github.com/mdmathias |
| Set require app host to true in GoogleSignInSwiftSupport podspec | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/c04dc0cb82ceefa61b6746845ed1a6209f73ecc4 |
| c04dc0c | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/c04dc0cb82ceefa61b6746845ed1a6209f73ecc4 |
| mdmathias | https://github.com/mdmathias |
| May 15, 2023 18:00 | https://github.com/google/GoogleSignIn-iOS/pull/299#commits-pushed-434ec5a |
|
| https://github.com/mdmathias |
| Update EMM support test to be more clear | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/434ec5a2e6fe73afa3a0f12b57e245d3b5c883d6 |
| 434ec5a | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/434ec5a2e6fe73afa3a0f12b57e245d3b5c883d6 |
|
| https://github.com/mdmathias |
| Remove unused init override in GIDAuthStateMigration | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/61daac5611a80a9f55273fcd961f078db2562e0a |
| 61daac5 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/61daac5611a80a9f55273fcd961f078db2562e0a |
|
| https://github.com/mdmathias |
| Add back init in GIDAuthStateMigration.m to remove warning | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/23bbea2dfef1c3f126a2baf8431942fa0425d4de |
| 23bbea2 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/23bbea2dfef1c3f126a2baf8431942fa0425d4de |
|
| https://github.com/mdmathias |
| Move extractAuthorizationWithTokenURL from GIDAuthStateMigration.h to… | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/10677aed1cde68886b277b50886f6bab85479046 |
| 10677ae | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/10677aed1cde68886b277b50886f6bab85479046 |
|
| https://github.com/mdmathias |
| Add typedef to NS_ENUM | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/74f01ee29e9fb8c01f9484e220bdbda182771f4a |
| 74f01ee | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/74f01ee29e9fb8c01f9484e220bdbda182771f4a |
|
| https://github.com/mdmathias |
| Fix version numbers for deps in podspec and package | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/bbe15574142d813c87d2385d7c891c9f989945d8 |
| bbe1557 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/bbe15574142d813c87d2385d7c891c9f989945d8 |
|
| https://github.com/mdmathias |
| Remove reference to fake fetcher error property | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/26d8f576a0636179e499ceedcf3c04360283b5f3 |
| 26d8f57 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/26d8f576a0636179e499ceedcf3c04360283b5f3 |
|
| https://github.com/mdmathias |
| Remove GIDTestWorker | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/61a08bd5af6206d51a23e29ea36b81788c6d7296 |
| 61a08bd | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/61a08bd5af6206d51a23e29ea36b81788c6d7296 |
|
| https://github.com/mdmathias |
| Rename authState to failingAuthState in EMM error handling test | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/a87b9341f23d183b56969973364c35bdfa3a602d |
| a87b934 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/a87b9341f23d183b56969973364c35bdfa3a602d |
|
| https://github.com/mdmathias |
| Update GIDEMMSupport to more clearly handle the updated error | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/38641b70a35f0f3472285813f20c7bb66949205b |
| 38641b7 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/38641b70a35f0f3472285813f20c7bb66949205b |
|
| https://github.com/mdmathias |
| Update GIDEMMSupport to use new update error delegate method | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/1a1041d9c9aeb1c21d558edc8f433d246f44618b |
| 1a1041d | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/1a1041d9c9aeb1c21d558edc8f433d246f44618b |
|
| https://github.com/mdmathias |
| Remove duplicated constants | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b16fbb86ed64a4e7566cf479b5e48449241a1694 |
| b16fbb8 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b16fbb86ed64a4e7566cf479b5e48449241a1694 |
|
| https://github.com/mdmathias |
| Use new EMM error handling delegate method name | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/cce884e2c673fd52bf20f819b113cd8e82622371 |
| cce884e | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/cce884e2c673fd52bf20f819b113cd8e82622371 |
|
| https://github.com/mdmathias |
| Depend upon main GTMAppAuth branch | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/ca7f78fedb0f65322ebdd8b6f424ac90da210807 |
| ca7f78f | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/ca7f78fedb0f65322ebdd8b6f424ac90da210807 |
|
| https://github.com/mdmathias |
| Update GIDEMMSupportTest to swizzle a key window and alert controller | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/10b6b60c59a9d6ca20edb96a8b853ae2d64d616e |
| 10b6b60 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/10b6b60c59a9d6ca20edb96a8b853ae2d64d616e |
|
| https://github.com/mdmathias |
| Depend upon GTMAppAuth 4.0.0 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b940af4bc1f4d91973eb91d5079c3786594f1fb4 |
| b940af4 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/b940af4bc1f4d91973eb91d5079c3786594f1fb4 |
|
| https://github.com/mdmathias |
| Stub expected method on keychainStore in GIDSignInTest | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/2dab4df47809a589281c9dabacca97ebbd64aa6d |
| 2dab4df | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/2dab4df47809a589281c9dabacca97ebbd64aa6d |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/00151614714b4b7f741617390b085325cc312ba5..2dab4df47809a589281c9dabacca97ebbd64aa6d |
| 0015161 | https://github.com/google/GoogleSignIn-iOS/commit/00151614714b4b7f741617390b085325cc312ba5 |
| 2dab4df | https://github.com/google/GoogleSignIn-iOS/commit/2dab4df47809a589281c9dabacca97ebbd64aa6d |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/00151614714b4b7f741617390b085325cc312ba5..2dab4df47809a589281c9dabacca97ebbd64aa6d |
| May 16, 2023 01:10 | https://github.com/google/GoogleSignIn-iOS/pull/299#event-9252345128 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
May 16, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1429008074 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files/2dab4df47809a589281c9dabacca97ebbd64aa6d |
| GoogleSignIn/Sources/GIDAuthStateMigration.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files/2dab4df47809a589281c9dabacca97ebbd64aa6d#diff-84143022462acf558036edb20e0c0e2af81d8a8a747628613ebeafbfb55db756 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDAuthStateMigration.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files/2dab4df47809a589281c9dabacca97ebbd64aa6d#diff-84143022462acf558036edb20e0c0e2af81d8a8a747628613ebeafbfb55db756 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDAuthStateMigration.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files/2dab4df47809a589281c9dabacca97ebbd64aa6d#diff-84143022462acf558036edb20e0c0e2af81d8a8a747628613ebeafbfb55db756 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files/2dab4df47809a589281c9dabacca97ebbd64aa6d#diff-9cace522c90e87250974691440a8c5b326a16fc5a5a0e1e7faaec2e2247c3b93 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDGoogleUser_Private.h | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-69ab0ff496c0fbb5f99720f071d0a7a018f076e7e4accae1ac2b64c6e49b6a28 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
| GoogleSignIn/Sources/GIDEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/299/files#diff-08f8a82772be314a9a83a0d6dd3881bd23053792d8de6f8410baaef6705301ad |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
|
| https://github.com/mdmathias |
| Rename authorization -> authSession | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e862376fa2dbdc79b498f8f398e7be9f292e6b71 |
| e862376 | https://github.com/google/GoogleSignIn-iOS/pull/299/commits/e862376fa2dbdc79b498f8f398e7be9f292e6b71 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
May 16, 2023
| https://github.com/google/GoogleSignIn-iOS/pull/299#pullrequestreview-1429163380 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/299/files/e862376fa2dbdc79b498f8f398e7be9f292e6b71 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| 55bf5d0 | https://github.com/google/GoogleSignIn-iOS/commit/55bf5d077bc7226357c49bb929a0188968b4589e |
| May 16, 2023 | https://github.com/google/GoogleSignIn-iOS/pull/299#event-9262046971 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
| May 16, 2023 20:01 | https://github.com/google/GoogleSignIn-iOS/pull/299#event-9262047105 |
| https://github.co/hiddenchars |
| https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F299 |
|
| https://github.com/ch40w31 |
|
ch40w31
| https://github.com/ch40w31 |
|
| https://github.com/google/GoogleSignIn-iOS/pull/299/files/e862376fa2dbdc79b498f8f398e7be9f292e6b71 |
|
| https://github.com/XiangtianDai |
|
XiangtianDai
| https://github.com/XiangtianDai |
|
| https://github.com/google/GoogleSignIn-iOS/pull/299/files/77039ba747d2fc875d4834177f3432f79674924a |
|
| https://github.com/paulb777 |
|
paulb777
| https://github.com/paulb777 |
|
| https://github.com/google/GoogleSignIn-iOS/pull/299/files/9f1e1df5d594453d977999caf17d260324418acd |
|
GIDGoogleUser doesn't look like it will handle EMM support
| https://github.com/google/GoogleSignIn-iOS/issues/304 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/299 |
|
| https://github.com/mdmathias |
|
| https://github.com/paulb777 |
|
| https://github.com/ch40w31 |
|
| https://github.com/XiangtianDai |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |