| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6323ee7e-29f9-c3b5-5848-98761e267b5e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9544:3BD55A:533885:7958C9:6A61EC76 |
| html-safe-nonce | 3cb973c26955ddd42878c21c20a4f179778d3abc46735990bcdc032c6f7ffae7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTQ0OjNCRDU1QTo1MzM4ODU6Nzk1OEM5OjZBNjFFQzc2IiwidmlzaXRvcl9pZCI6IjU3MjYyMTgzOTg0NTc3ODU0NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 76dfaee755e38a7d1c9296b56916bb80a81a6c9e5d9a78754a610993b5ca0384 |
| hovercard-subject-tag | pull_request:1076326328 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/234/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/170e69234dd305b77da7d8a489fab7e5550117cb7f214daf324beb3f6b5ecf68/google/GoogleSignIn-iOS/pull/234 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/170e69234dd305b77da7d8a489fab7e5550117cb7f214daf324beb3f6b5ecf68/google/GoogleSignIn-iOS/pull/234 |
| og:image:alt | This PR moves the doWithFreshTokens into GIDGoogleUser which is the last part in GIDAuthentication. The main modifications are as follows.
Move doWithFreshTokens: into GIDGoogleUser.
Keep GIDAuthe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Alex-4-Git |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5dd1217fff37e297563b9d318ee02bf6378c8957c6195b77786bb8896fc9c95d |
| turbo-cache-control | no-cache |
| go-import | github.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 351159356 |
| octolytics-dimension-repository_nwo | google/GoogleSignIn-iOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 351159356 |
| octolytics-dimension-repository_network_root_nwo | google/GoogleSignIn-iOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 554667f6dda2a53c83687de64fabc457970f0f04 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/google/GoogleSignIn-iOS/pull/234#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F234 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F234 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
|
google
| https://github.com/google |
| GoogleSignIn-iOS | https://github.com/google/GoogleSignIn-iOS |
|
Notifications
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Fork
276
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Star
733
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
79
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
3
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
0
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
| Alex-4-Git | https://github.com/Alex-4-Git |
| GIDGoogleUser-restructure | https://github.com/google/GoogleSignIn-iOS/tree/GIDGoogleUser-restructure |
| pin-moveDoWithFreshTokens | https://github.com/google/GoogleSignIn-iOS/tree/pin-moveDoWithFreshTokens |
| Conversation | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Commits30 (30) | https://github.com/google/GoogleSignIn-iOS/pull/234/commits |
| Checks | https://github.com/google/GoogleSignIn-iOS/pull/234/checks |
| Files changed | https://github.com/google/GoogleSignIn-iOS/pull/234/files |
| Move the method doWithFreshTokens: into GIDGoogleUserAPI | https://github.com/google/GoogleSignIn-iOS/pull/234#top |
| Alex-4-Git | https://github.com/Alex-4-Git |
| GIDGoogleUser-restructure | https://github.com/google/GoogleSignIn-iOS/tree/GIDGoogleUser-restructure |
| pin-moveDoWithFreshTokens | https://github.com/google/GoogleSignIn-iOS/tree/pin-moveDoWithFreshTokens |
|
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| Oct 4, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/234#issue-1396633592 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Alex-4-Git | https://github.com/Alex-4-Git |
| September 19, 2022 17:55 | https://github.com/google/GoogleSignIn-iOS/pull/234#commits-pushed-30699df |
|
| https://github.com/Alex-4-Git |
| Add KVO in GIDGoogleUser | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/30699dff05984dfc4d5f710c6d151f5c3a86a707 |
| 30699df | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/30699dff05984dfc4d5f710c6d151f5c3a86a707 |
|
| https://github.com/Alex-4-Git |
| Observe KVO in GIDGoogleUserTest | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9ac54783eb4f3c2daa67b4e3dbe0aeb84ce931f7 |
| 9ac5478 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9ac54783eb4f3c2daa67b4e3dbe0aeb84ce931f7 |
|
| https://github.com/Alex-4-Git |
| Utilize the class extension and automatic KVO notifications | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/26784fe5ac207be94d4f9b71ebdc476f9bb49bad |
| 26784fe | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/26784fe5ac207be94d4f9b71ebdc476f9bb49bad |
|
| https://github.com/Alex-4-Git |
| Merge branch 'GIDGoogleUser-restructure' into pin-AddKVOInGoogleUser | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f2b0a5f0cff06adaa253807acfcdc579d7717bc6 |
| f2b0a5f | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f2b0a5f0cff06adaa253807acfcdc579d7717bc6 |
|
| https://github.com/Alex-4-Git |
| Only update tokens if necessary | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6e5d21adfa5e29158a387aed0b6c31e4fdfb0ae1 |
| 6e5d21a | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6e5d21adfa5e29158a387aed0b6c31e4fdfb0ae1 |
|
| https://github.com/Alex-4-Git |
| Merge branch 'pin-AddKVOInGoogleUser' of | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9f32608c66c545d784a5e1a04d0d69730695858d |
| https://github.com/google/Go… | https://github.com/google/GoogleSignIn-iOS |
| 9f32608 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9f32608c66c545d784a5e1a04d0d69730695858d |
| …ogleSignIn-iOS | https://github.com/google/GoogleSignIn-iOS |
|
| https://github.com/Alex-4-Git |
| Remove the KVO testing | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/d45e398d697f2cffed73d1eb06b2cb4ceef781dc |
| d45e398 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/d45e398d697f2cffed73d1eb06b2cb4ceef781dc |
|
| https://github.com/Alex-4-Git |
| Test tokens unchanged | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/a56786b6024cdb1edb31a432245d6d15c74a15b5 |
| a56786b | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/a56786b6024cdb1edb31a432245d6d15c74a15b5 |
|
| https://github.com/Alex-4-Git |
| Move fetcherAuthorizer from GIDAuthentication to GIDGoogleUser | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/58d2acf457f4ad6454ed034d2c8ad794bc7ed432 |
| 58d2acf | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/58d2acf457f4ad6454ed034d2c8ad794bc7ed432 |
|
| https://github.com/Alex-4-Git |
| Merge branch 'GIDGoogleUser-restructure' into pin-moveFetcherAuthorizaer | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f843c579f67cc835e31a646a1e63029a42fd9480 |
| f843c57 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f843c579f67cc835e31a646a1e63029a42fd9480 |
|
| https://github.com/Alex-4-Git |
| Move fetcherAuthorizer into GIDGoogleUser API | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/3d2921240dee8ccfb7d8a9d8792c93e347827571 |
| 3d29212 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/3d2921240dee8ccfb7d8a9d8792c93e347827571 |
|
| https://github.com/Alex-4-Git |
| Create GIDAppAuthFetcherAuthorizationWithEMMSupport class | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ca97c303ac0f563690573c5da37184e4325a9a89 |
| ca97c30 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ca97c303ac0f563690573c5da37184e4325a9a89 |
|
| https://github.com/Alex-4-Git |
| Minor improvements. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ad40f6c795afa9bb86cf1c3d0b313710aa07f55f |
| ad40f6c | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ad40f6c795afa9bb86cf1c3d0b313710aa07f55f |
|
| https://github.com/Alex-4-Git |
| Update GIDAppAuthFetcherAuthorizationWithEMMSupport.m | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/bd3257d7b4ed0acfa408338c1ce948cf16db2e95 |
| bd3257d | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/bd3257d7b4ed0acfa408338c1ce948cf16db2e95 |
|
| https://github.com/Alex-4-Git |
| Create fetcherAuthorizer at initialization | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f87f063cf83cf56a3b3983d7855c86a147c64b9a |
| f87f063 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/f87f063cf83cf56a3b3983d7855c86a147c64b9a |
|
| https://github.com/Alex-4-Git |
| Fix test failures | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9f9f85ab547dd0407ae63551ccbfc25dd9436af1 |
| 9f9f85a | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/9f9f85ab547dd0407ae63551ccbfc25dd9436af1 |
|
| https://github.com/Alex-4-Git |
| Suppress the deprecation warnings. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/c622c9733d2d518ffcdbc7f1497fe04ae48213b5 |
| c622c97 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/c622c9733d2d518ffcdbc7f1497fe04ae48213b5 |
|
| https://github.com/Alex-4-Git |
| Added Utility class GIDEMMSupport to handle EMM related issues. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/51bb4246bb65697615f75d44807a6b1480425bc8 |
| 51bb424 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/51bb4246bb65697615f75d44807a6b1480425bc8 |
|
| https://github.com/Alex-4-Git |
| Minor improvement. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/befe97774ee7de5cab1e7acbed77d77f6c667651 |
| befe977 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/befe97774ee7de5cab1e7acbed77d77f6c667651 |
|
| https://github.com/Alex-4-Git |
| Move doWithFreshTokens: into GIDGoogleUser API | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/33705b481ff534f7bbd8e952b5e8b56af1ce1e0b |
| 33705b4 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/33705b481ff534f7bbd8e952b5e8b56af1ce1e0b |
|
| https://github.com/Alex-4-Git |
| Merge branch 'GIDGoogleUser-restructure' into pin-moveDoWithFreshTokens | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/0102dc626ff87d87ee9970437c643d0959b2fc7e |
| 0102dc6 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/0102dc626ff87d87ee9970437c643d0959b2fc7e |
|
| https://github.com/Alex-4-Git |
| Minor improvement | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/846f4ce6553fa500bac2dd3432e66e9e1699778b |
| 846f4ce | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/846f4ce6553fa500bac2dd3432e66e9e1699778b |
|
| https://github.com/Alex-4-Git |
| Add unit tests | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/70bc182ecd0d1e40adec80e03ff8f3f7466a08fb |
| 70bc182 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/70bc182ecd0d1e40adec80e03ff8f3f7466a08fb |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| October 6, 2022 20:07 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7538332693 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| mdmathias | https://github.com/mdmathias |
| petea | https://github.com/petea |
| October 6, 2022 20:07 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7538332973 |
|
| https://github.com/Alex-4-Git |
| Minor improvements and move GIDEMMSupportTest to a separate PR. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
| ee6f7a4 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/bc07103de22156ed2f034abbf522a9f152b7e977..ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
| bc07103 | https://github.com/google/GoogleSignIn-iOS/commit/bc07103de22156ed2f034abbf522a9f152b7e977 |
| ee6f7a4 | https://github.com/google/GoogleSignIn-iOS/commit/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/bc07103de22156ed2f034abbf522a9f152b7e977..ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
| October 6, 2022 20:48 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7538580176 |
| https://github.com/petea |
| petea | https://github.com/petea |
|
Oct 7, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1134934748 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290 |
| GoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-d183c9cca3db7f530877934f7815612846c68bc12363727073dcabeab8a962cf |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-d183c9cca3db7f530877934f7815612846c68bc12363727073dcabeab8a962cf |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| Samples/Swift/DaysUntilBirthday/Shared/Services/BirthdayLoader.swift | https://github.com/google/GoogleSignIn-iOS/pull/234/files/ee6f7a4e1d3817bec6bc4bfcab3de0f3b6af6290#diff-afdf2904a6df61e9da65a229fae6659f12424c76e1b7c8f5df060c1ab26a2480 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Oct 7, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1135077134 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/4065709924d2e5af37567302105ebf229bb87aae..8b241e6548862c9bcf2d5045c5d980ecd9a32650 |
| 4065709 | https://github.com/google/GoogleSignIn-iOS/commit/4065709924d2e5af37567302105ebf229bb87aae |
| 8b241e6 | https://github.com/google/GoogleSignIn-iOS/commit/8b241e6548862c9bcf2d5045c5d980ecd9a32650 |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/4065709924d2e5af37567302105ebf229bb87aae..8b241e6548862c9bcf2d5045c5d980ecd9a32650 |
| October 7, 2022 23:58 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7547104604 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| ch40w31 | https://github.com/ch40w31 |
| petea | https://github.com/petea |
| October 7, 2022 23:59 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7547106790 |
|
| https://github.com/Alex-4-Git |
| Resolve comments | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/b9f312a6d7bd9240dca149754b9dcf3a38f32595 |
| b9f312a | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/b9f312a6d7bd9240dca149754b9dcf3a38f32595 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/8b241e6548862c9bcf2d5045c5d980ecd9a32650..b9f312a6d7bd9240dca149754b9dcf3a38f32595 |
| 8b241e6 | https://github.com/google/GoogleSignIn-iOS/commit/8b241e6548862c9bcf2d5045c5d980ecd9a32650 |
| b9f312a | https://github.com/google/GoogleSignIn-iOS/commit/b9f312a6d7bd9240dca149754b9dcf3a38f32595 |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/8b241e6548862c9bcf2d5045c5d980ecd9a32650..b9f312a6d7bd9240dca149754b9dcf3a38f32595 |
| October 8, 2022 00:22 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7547152759 |
|
| https://github.com/Alex-4-Git |
| Minor improvement. | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1 |
| 6d8575d | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1 |
| https://github.com/petea |
| petea | https://github.com/petea |
|
Oct 10, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1136531628 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-d183c9cca3db7f530877934f7815612846c68bc12363727073dcabeab8a962cf |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Tests/Unit/GIDSignInTest.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6d8575d30d0dd34f8baa8b4d225bb0d9e82561e1#diff-0bae95806300a9681dc99f4d9d5f8dad6b9fb911fc32536ea15cb68605b7dc8c |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
|
| https://github.com/Alex-4-Git |
| Resolve comments | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ded0a373f6abdbbd10bffd2bba73d9c29fbffd87 |
| ded0a37 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/ded0a373f6abdbbd10bffd2bba73d9c29fbffd87 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| petea | https://github.com/petea |
| October 11, 2022 05:57 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7559074389 |
| Alex-4-Git | https://github.com/Alex-4-Git |
| October 11, 2022 15:54 | https://github.com/google/GoogleSignIn-iOS/pull/234#commits-pushed-7f4aab8 |
|
| https://github.com/Alex-4-Git |
| Update authState with OIDAuthorizationResponse | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/7f4aab8af01e8cab183325dfb0833107fe1b242d |
| 7f4aab8 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/7f4aab8af01e8cab183325dfb0833107fe1b242d |
|
| https://github.com/Alex-4-Git |
| Add unit test for GIDGoogleUser old encoding format | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
| 6ee3073 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/3ff1fa54d890d41e4440bef0f8898321daf5a568..6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
| 3ff1fa5 | https://github.com/google/GoogleSignIn-iOS/commit/3ff1fa54d890d41e4440bef0f8898321daf5a568 |
| 6ee3073 | https://github.com/google/GoogleSignIn-iOS/commit/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/3ff1fa54d890d41e4440bef0f8898321daf5a568..6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
| October 12, 2022 21:51 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7575561449 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Oct 13, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1139786768 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a |
| ch40w31 | https://github.com/ch40w31 |
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1139786768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDAuthentication.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-b8a3155293b7631001de3b8cbd79228c057d87bf0f11125e2e857d041f18fcf6 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDAuthentication.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-b8a3155293b7631001de3b8cbd79228c057d87bf0f11125e2e857d041f18fcf6 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.h | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-eaa6fceb93a33a2d688b41e40d9a6e9b019f8a82d5785d5e0774dc0a8d316aa0 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-a37b5251beafba9125622d9da3f3585e8a4af3505b31e50d9bc495f476445522 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| GoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.h | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-eaa6fceb93a33a2d688b41e40d9a6e9b019f8a82d5785d5e0774dc0a8d316aa0 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| ch40w31 | https://github.com/ch40w31 |
| October 13, 2022 18:42 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7584101591 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Oct 13, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1141502905 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files |
| GoogleSignIn/Sources/GIDGoogleUser.m | https://github.com/google/GoogleSignIn-iOS/pull/234/files/6ee30738abc8adbb8b37eeb8956cc83e8097ef5a#diff-a09e7e865361f9898d1cb46cabecb5ee1985d5b6a18bda9a0b3fd1e8f5ab4035 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| ch40w31 | https://github.com/ch40w31 |
| October 13, 2022 21:40 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7585285350 |
|
| https://github.com/Alex-4-Git |
| Improve testing class GIDGoogleUserOldFormat | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/c065b293ab3cdc0ca615988304f3d1a8664150f3 |
| c065b29 | https://github.com/google/GoogleSignIn-iOS/pull/234/commits/c065b293ab3cdc0ca615988304f3d1a8664150f3 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| force-pushed | https://github.com/google/GoogleSignIn-iOS/compare/35be9ecfd3a7a7b81f12d145e86ae713872a6322..c065b293ab3cdc0ca615988304f3d1a8664150f3 |
| 35be9ec | https://github.com/google/GoogleSignIn-iOS/commit/35be9ecfd3a7a7b81f12d145e86ae713872a6322 |
| c065b29 | https://github.com/google/GoogleSignIn-iOS/commit/c065b293ab3cdc0ca615988304f3d1a8664150f3 |
|
Compare
| https://github.com/google/GoogleSignIn-iOS/compare/35be9ecfd3a7a7b81f12d145e86ae713872a6322..c065b293ab3cdc0ca615988304f3d1a8664150f3 |
| October 13, 2022 22:44 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7585570196 |
| https://github.com/ch40w31 |
| ch40w31 | https://github.com/ch40w31 |
|
Oct 13, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/234#pullrequestreview-1141635146 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/234/files/c065b293ab3cdc0ca615988304f3d1a8664150f3 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| e43bd7f | https://github.com/google/GoogleSignIn-iOS/commit/e43bd7f5a5f5a2de419d216886c2628ce62abd35 |
| Oct 14, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7586078126 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
| October 14, 2022 00:55 | https://github.com/google/GoogleSignIn-iOS/pull/234#event-7586078175 |
| https://github.co/hiddenchars |
| https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F234 |
|
| https://github.com/ch40w31 |
|
ch40w31
| https://github.com/ch40w31 |
|
| https://github.com/google/GoogleSignIn-iOS/pull/234/files/c065b293ab3cdc0ca615988304f3d1a8664150f3 |
|
| https://github.com/mdmathias |
|
mdmathias
| https://github.com/mdmathias |
|
| https://github.com/petea |
|
petea
| https://github.com/petea |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/234 |
|
| https://github.com/Alex-4-Git |
|
| https://github.com/petea |
|
| https://github.com/ch40w31 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |