| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:95f9f7bf-7aaf-67a7-b362-2e004446d4a0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E95E:C1BCD:7FE757:AFC87B:6A61B8A0 |
| html-safe-nonce | a0906c54cd4bea4a8009d75b573cdffa2f582c7ed8935838fdeaa75e54690b08 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTVFOkMxQkNEOjdGRTc1NzpBRkM4N0I6NkE2MUI4QTAiLCJ2aXNpdG9yX2lkIjoiODA0OTY0MTM4MzEyMzg1OTYxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 708cdc4d27cd191b127e88993fa7a9785340bb9421093ea0911eeafa1ffda0fc |
| hovercard-subject-tag | pull_request:1065798238 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/google/GoogleSignIn-iOS/228/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dac8840d266d74e598c9f3f37d79da335f9f7c88fd3f2b40a2daef1d83e600e6/google/GoogleSignIn-iOS/pull/228 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dac8840d266d74e598c9f3f37d79da335f9f7c88fd3f2b40a2daef1d83e600e6/google/GoogleSignIn-iOS/pull/228 |
| og:image:alt | Provide a new configuration property on GIDSignIn representing the active config.
Update the API surface to remove the GIDConfiguration parameter from the signIn method signatures.
Create a mechani... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6f4633bcf01c1ad14b73fd07dd39ac31d61f3d3c2578ee08ec1792b7b351eeb9 |
| turbo-cache-control | no-cache |
| go-import | github.com/google/GoogleSignIn-iOS git https://github.com/google/GoogleSignIn-iOS.git |
| octolytics-dimension-user_id | 1342004 |
| octolytics-dimension-user_login | google |
| octolytics-dimension-repository_id | 351159356 |
| octolytics-dimension-repository_nwo | google/GoogleSignIn-iOS |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 351159356 |
| octolytics-dimension-repository_network_root_nwo | google/GoogleSignIn-iOS |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ac296ae7f21856f1f92adbad22f870b6fbb4b907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/google/GoogleSignIn-iOS/pull/228#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F228 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F228 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=google%2FGoogleSignIn-iOS |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| Reload | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
|
google
| https://github.com/google |
| GoogleSignIn-iOS | https://github.com/google/GoogleSignIn-iOS |
|
Notifications
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Fork
276
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Star
733
| https://github.com/login?return_to=%2Fgoogle%2FGoogleSignIn-iOS |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
79
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
3
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
0
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
|
Code
| https://github.com/google/GoogleSignIn-iOS |
|
Issues
| https://github.com/google/GoogleSignIn-iOS/issues |
|
Pull requests
| https://github.com/google/GoogleSignIn-iOS/pulls |
|
Actions
| https://github.com/google/GoogleSignIn-iOS/actions |
|
Projects
| https://github.com/google/GoogleSignIn-iOS/projects |
|
Security and quality
| https://github.com/google/GoogleSignIn-iOS/security |
|
Insights
| https://github.com/google/GoogleSignIn-iOS/pulse |
| petea | https://github.com/petea |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| petea-config | https://github.com/google/GoogleSignIn-iOS/tree/petea-config |
| Conversation | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| Commits10 (10) | https://github.com/google/GoogleSignIn-iOS/pull/228/commits |
| Checks | https://github.com/google/GoogleSignIn-iOS/pull/228/checks |
| Files changed | https://github.com/google/GoogleSignIn-iOS/pull/228/files |
| Add a configuration property populated via Info.plist | https://github.com/google/GoogleSignIn-iOS/pull/228#top |
| petea | https://github.com/petea |
| main | https://github.com/google/GoogleSignIn-iOS/tree/main |
| petea-config | https://github.com/google/GoogleSignIn-iOS/tree/petea-config |
|
| https://github.com/petea |
| petea | https://github.com/petea |
| Sep 23, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/228#issue-1384357235 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| petea | https://github.com/petea |
| September 23, 2022 15:14 | https://github.com/google/GoogleSignIn-iOS/pull/228#commits-pushed-032b080 |
|
| https://github.com/petea |
| Add core Info.plist config functionality and update API surface. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/032b0800d398a4c71d0e823f983051e71396dbab |
| 032b080 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/032b0800d398a4c71d0e823f983051e71396dbab |
|
| https://github.com/petea |
| Use -objectForInfoDictionaryKey: instead of infoDictionary subscripting. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/1d58a2d9a2fc2ba0f06a2a6f2625129f164e32ce |
| 1d58a2d | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/1d58a2d9a2fc2ba0f06a2a6f2625129f164e32ce |
|
| https://github.com/petea |
| Add tests for basic config scenarios. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af |
| 8aa0d39 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af |
| https://github.com/petea |
| petea | https://github.com/petea |
| September 26, 2022 23:33 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7463310578 |
| https://github.com/petea |
| petea | https://github.com/petea |
| Alex-4-Git | https://github.com/Alex-4-Git |
| mdmathias | https://github.com/mdmathias |
| September 26, 2022 23:33 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7463310806 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
|
Sep 27, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1122431481 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af |
| Samples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift | https://github.com/google/GoogleSignIn-iOS/pull/228/files/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af#diff-a18bf9862b63c8fcf732be6666ae2053d01622aaeb722583dbbdca31a8aeaab6 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
|
Sep 27, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1121050928 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af |
| Samples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift | https://github.com/google/GoogleSignIn-iOS/pull/228/files/8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af#diff-a18bf9862b63c8fcf732be6666ae2053d01622aaeb722583dbbdca31a8aeaab6 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| GoogleSignIn/Sources/GIDSignIn.m | https://github.com/google/GoogleSignIn-iOS/pull/228/files/032b0800d398a4c71d0e823f983051e71396dbab#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h | https://github.com/google/GoogleSignIn-iOS/pull/228/files/032b0800d398a4c71d0e823f983051e71396dbab#diff-c80e02f3d8bb180810239bc40653e11329ec338be52cb2a429937e929b2a4d40 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| GoogleSignIn/Tests/Unit/GIDFakeMainBundle.m | https://github.com/google/GoogleSignIn-iOS/pull/228/files/1d58a2d9a2fc2ba0f06a2a6f2625129f164e32ce..8aa0d393ece2f2221ed4c7ae56bc7a22acb4a3af#diff-b93a6098bd108efc5cf3f8f76c994e48bf5008ab031751b2e22733698c3031db |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| petea | https://github.com/petea |
| September 27, 2022 11:39 | https://github.com/google/GoogleSignIn-iOS/pull/228#commits-pushed-2189b39 |
|
| https://github.com/petea |
| Handle invalid config scenario. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/2189b3962620808cd0dfa88518e82b55f5a16578 |
| 2189b39 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/2189b3962620808cd0dfa88518e82b55f5a16578 |
|
| https://github.com/petea |
| Remove bundle ID URL scheme support from our fake bundle. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/83ca781bde9614ae05ec8d9bf18ee5cd9bed97bd |
| 83ca781 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/83ca781bde9614ae05ec8d9bf18ee5cd9bed97bd |
|
| https://github.com/petea |
| Fix indentation. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/77b76e34d83d8d4915e9b095014d2b1264bbdd44 |
| 77b76e3 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/77b76e34d83d8d4915e9b095014d2b1264bbdd44 |
|
| https://github.com/petea |
| Update doc comments. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/8b9435b79bf02a6408c5e63acb60cbd192c1bf40 |
| 8b9435b | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/8b9435b79bf02a6408c5e63acb60cbd192c1bf40 |
|
| https://github.com/petea |
| Update method names and doc comments. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/112f1766f161699672df47187fd4336386a0b7ea |
| 112f176 | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/112f1766f161699672df47187fd4336386a0b7ea |
| https://github.com/petea |
| petea | https://github.com/petea |
| Sep 27, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7471580797 |
| https://github.com/Alex-4-Git |
| Alex-4-Git | https://github.com/Alex-4-Git |
|
Sep 27, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1122832813 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/112f1766f161699672df47187fd4336386a0b7ea |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
|
Sep 28, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1122857074 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/112f1766f161699672df47187fd4336386a0b7ea |
| GoogleSignIn/Sources/GIDSignIn.m | https://github.com/google/GoogleSignIn-iOS/pull/228/files/112f1766f161699672df47187fd4336386a0b7ea#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
|
Sep 28, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1122859424 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/112f1766f161699672df47187fd4336386a0b7ea |
| petea | https://github.com/petea |
| September 28, 2022 13:32 | https://github.com/google/GoogleSignIn-iOS/pull/228#commits-pushed-0b2212b |
|
| https://github.com/petea |
| Simplify setting the initial config. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/0b2212b22d66bb37308a7c5a7951a7d271e0f897 |
| 0b2212b | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/0b2212b22d66bb37308a7c5a7951a7d271e0f897 |
|
| https://github.com/petea |
| Dry up Info.plist config loading. | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/99d0e5bfd5f1df51e00912ecb5861a9f372f4a3c |
| 99d0e5b | https://github.com/google/GoogleSignIn-iOS/pull/228/commits/99d0e5bfd5f1df51e00912ecb5861a9f372f4a3c |
| https://github.com/mdmathias |
| mdmathias | https://github.com/mdmathias |
|
Sep 29, 2022
| https://github.com/google/GoogleSignIn-iOS/pull/228#pullrequestreview-1124484291 |
|
View reviewed changes
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/99d0e5bfd5f1df51e00912ecb5861a9f372f4a3c |
| GoogleSignIn/Sources/GIDSignIn.m | https://github.com/google/GoogleSignIn-iOS/pull/228/files/0b2212b22d66bb37308a7c5a7951a7d271e0f897..99d0e5bfd5f1df51e00912ecb5861a9f372f4a3c#diff-b76ad8011382daf05bf7a830db6abe2428c68fbeadd4b617b39bd2c504e2b640 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
| https://github.com/petea |
| petea | https://github.com/petea |
| ae5276c | https://github.com/google/GoogleSignIn-iOS/commit/ae5276cf1f75f662724be3d5198af77f2ed0db03 |
| Sep 29, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7490253047 |
| https://github.com/petea |
| petea | https://github.com/petea |
| September 29, 2022 20:38 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7490253129 |
| https://github.com/petea |
| petea | https://github.com/petea |
| 7.0.0 | https://github.com/google/GoogleSignIn-iOS/milestone/4 |
| Nov 2, 2022 | https://github.com/google/GoogleSignIn-iOS/pull/228#event-7726754650 |
| https://github.co/hiddenchars |
| https://github.com/google/GoogleSignIn-iOS/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogle%2FGoogleSignIn-iOS%2Fpull%2F228 |
|
| https://github.com/mdmathias |
|
mdmathias
| https://github.com/mdmathias |
|
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/99d0e5bfd5f1df51e00912ecb5861a9f372f4a3c |
|
| https://github.com/Alex-4-Git |
|
Alex-4-Git
| https://github.com/Alex-4-Git |
|
| https://github.com/google/GoogleSignIn-iOS/pull/228/files/112f1766f161699672df47187fd4336386a0b7ea |
|
7.0.0
| https://github.com/google/GoogleSignIn-iOS/milestone/4 |
| Please reload this page | https://github.com/google/GoogleSignIn-iOS/pull/228 |
|
| https://github.com/petea |
|
| https://github.com/mdmathias |
|
| https://github.com/Alex-4-Git |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |