René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"api_key param is absent and ParseError reference is missing","articleBody":"Your python client lib has problems. First up the api_key param in your example doesn't work:\r\n\r\n`from glassnode import GlassnodeClient\r\n\r\ngn = GlassnodeClient(api_key='YOUR-KEY')`\r\n\r\nObviously that's insecure but I wanted to give it a first run and got this:\r\n\r\nTypeError: __init__() got an unexpected keyword argument 'api_key'\r\n\r\nLooking at the source I can see why. Anyway, I removed the param as I had set an env variable in PyCharm as well as in OS X:\r\n\r\n```\r\nimport os\r\nfrom glassnode import GlassnodeClient\r\n\r\nGLASSNODE_API_KEY = os.getenv('GLASSNODE_API_KEY')\r\nprint(GLASSNODE_API_KEY)\r\n\r\ngn = GlassnodeClient()\r\n\r\nresponse = gn.get(\r\n    'https://api.glassnode.com/v1/metrics/indicators/net_realized_profit_loss?a=BTC\u0026s=1479573422\u0026u=1614470400',\r\n    a='BTC',\r\n    s='2020-01-01',\r\n    i='24h'\r\n)\r\n\r\nprint(response)\r\n\r\n```\r\n\r\nAfter running it like that I get another error:\r\n\r\n```\r\n401 Client Error: Unauthorized for url: https://api.glassnode.com/v1/metrics/indicators/net_realized_profit_loss?a=BTC\u0026s=1479573422\u0026u=1614470400\u0026a=BTC\u0026i=24h\u0026c=native\u0026s=1577833200\u0026api_key=\r\n\u003chtml\u003e\r\n\u003chead\u003e\u003ctitle\u003e401 Authorization Required\u003c/title\u003e\u003c/head\u003e\r\n\u003cbody\u003e\r\n\u003ccenter\u003e\u003ch1\u003e401 Authorization Required\u003c/h1\u003e\u003c/center\u003e\r\n\u003chr\u003e\u003ccenter\u003enginx/1.15.9\u003c/center\u003e\r\n\u003c/body\u003e\r\n\u003c/html\u003e\r\n\r\nExpecting value: line 1 column 1 (char 0)\r\nNone\r\n```\r\n\r\nSo either it's not picking up the key or something else is going on.\r\n\r\nFinally there seem to be an unresolved ParseError reference in glassnode.py. It's clearly the iso8601 ParseError and I've fixed it by making it verbose by adding the module name ahead of ParseError. I've also removed superfluous imports:\r\n\r\n```\r\nimport json\r\nimport requests\r\nimport iso8601\r\nimport pandas as pd\r\n\r\nclass GlassnodeClient:\r\n\r\n  def __init__(self):\r\n    self._api_key = ''\r\n\r\n  @property\r\n  def api_key(self):\r\n    return self._api_key\r\n\r\n  def set_api_key(self, value):\r\n    self._api_key = value\r\n\r\n  def get(self, url, a='BTC', i='24h', c='native', s=None, u=None):\r\n    p = dict()\r\n    p['a'] = a\r\n    p['i'] = i\r\n    p['c'] = c\r\n\r\n    if s is not None:\r\n      try:\r\n        p['s'] = iso8601.parse_date(s).strftime('%s')\r\n      except iso8601.ParseError:\r\n        p['s'] = s\r\n\r\n    if u is not None:\r\n      try:\r\n        p['u'] = iso8601.parse_date(u).strftime('%s')\r\n      except iso8601.ParseError:\r\n        p['u'] = s\r\n\r\n    p['api_key'] = self.api_key\r\n\r\n    r = requests.get(url, params=p)\r\n\r\n    try:\r\n       r.raise_for_status()\r\n    except Exception as e:\r\n        print(e)\r\n        print(r.text)\r\n\r\n    try:\r\n        df = pd.DataFrame(json.loads(r.text))\r\n        df = df.set_index('t')\r\n        df.index = pd.to_datetime(df.index, unit='s')\r\n        df = df.sort_index()\r\n        s = df.v\r\n        s.name = '_'.join(url.split('/')[-2:])\r\n        return s\r\n    except Exception as e:\r\n        print(e)\r\n```\r\n\r\nI run python 3.9 on OS X.\r\n\r\nAny pointers would be appreciated. ","author":{"url":"https://github.com/mmehrle","@type":"Person","name":"mmehrle"},"datePublished":"2021-02-28T13:43:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/6/glassnode-api-python-client/issues/6"}