Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib · GitHub
Open Graph Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib
X Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib
Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoids double-negatives ("Are we not not showing the summary?"), making the logic easier to follow and easier to find bugs in. I left the flag name as-is for compatability reasons. Fixes #1.
Open Graph Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi...
X Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi...
Opengraph URL: https://github.com/glamp/bashplotlib/pull/6
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:02c8e6cf-d012-80f4-2667-6839ebdb9b61 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3C6:1C3EE2:15DE708:1D20601:697D1E30 |
| html-safe-nonce | 76fd272c5b5974c405ad2b812e379c75d9697a8a937a6ede9f740ba382b3f92b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0M2OjFDM0VFMjoxNURFNzA4OjFEMjA2MDE6Njk3RDFFMzAiLCJ2aXNpdG9yX2lkIjoiMTM4NTU3NDY3OTMwMDYxMTYzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37364c880184a6dd70d654065081a7d82559e44d2e9038a83b87ab0e9d176ea3 |
| hovercard-subject-tag | pull_request:11826495 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/glamp/bashplotlib/pull/6/files |
| twitter:image | https://avatars.githubusercontent.com/u/23369?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/23369?s=400&v=4 |
| og:image:alt | The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2d5649ae937eae7f63d31fc38497f18a9f7584ad9d7f9e934a7b64b964ed52fd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/glamp/bashplotlib git https://github.com/glamp/bashplotlib.git |
| octolytics-dimension-user_id | 1409333 |
| octolytics-dimension-user_login | glamp |
| octolytics-dimension-repository_id | 7142310 |
| octolytics-dimension-repository_nwo | glamp/bashplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7142310 |
| octolytics-dimension-repository_network_root_nwo | glamp/bashplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87312954ce93e22874ec34d319d96d539f0beba0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width