Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib · GitHub
Open Graph Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib
X Title: Fix --nosummary flag by xiongchiamiov · Pull Request #6 · glamp/bashplotlib
Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoids double-negatives ("Are we not not showing the summary?"), making the logic easier to follow and easier to find bugs in. I left the flag name as-is for compatability reasons. Fixes #1.
Open Graph Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi...
X Description: The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi...
Opengraph URL: https://github.com/glamp/bashplotlib/pull/6
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b5e66272-87e9-6116-db25-1ea9665e437b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E11C:37296A:34A0F11:46AE633:697C7803 |
| html-safe-nonce | cad5e8cae7534769c28cbafb7f65ebdf505d296af1c56b1b8de4e18acfc4e237 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTFDOjM3Mjk2QTozNEEwRjExOjQ2QUU2MzM6Njk3Qzc4MDMiLCJ2aXNpdG9yX2lkIjoiNjI5MTI2NzUwODU0MDA0NTMxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5af2f91727e962c16baf9e2f1f153e222b1dc1e781f4e1edc548b3a884308296 |
| hovercard-subject-tag | pull_request:11826495 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/glamp/bashplotlib/pull/6/checks |
| twitter:image | https://avatars.githubusercontent.com/u/23369?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/23369?s=400&v=4 |
| og:image:alt | The --nosummary flag was inverted, which cause it to always be true. Rather than just flip store_false to store_true, I opted to refactor the internal name from nosummary to showSummary. This avoi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 639d2e61e0595a02d145092815d5b5c7345a4476fa7ce7eedc85345f4b0d5bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/glamp/bashplotlib git https://github.com/glamp/bashplotlib.git |
| octolytics-dimension-user_id | 1409333 |
| octolytics-dimension-user_login | glamp |
| octolytics-dimension-repository_id | 7142310 |
| octolytics-dimension-repository_nwo | glamp/bashplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7142310 |
| octolytics-dimension-repository_network_root_nwo | glamp/bashplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63131d96a4439002c1e480bbbc136f28b7fff962 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width