| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:92053fa0-06f1-c025-5a3c-8780c506dbac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A202:3EEF66:14F1AA3:1DA5950:69691B21 |
| html-safe-nonce | 4f4a62df608b6e71c9423d0725158924218b8b1832c573b6db8a9b6b23a9c4c7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjAyOjNFRUY2NjoxNEYxQUEzOjFEQTU5NTA6Njk2OTFCMjEiLCJ2aXNpdG9yX2lkIjoiMjc1ODkyMzM4MDIzNDcyMjA4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e43b050a98a8e97ad576437bf7b196300f7a722d60148cf8e5372c39191c7684 |
| hovercard-subject-tag | pull_request:91164780 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/gitpython-developers/smmap/33/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1f0ea97c2e35faff3475d8cbafd37e38923d52cd91db09332551748f75ac053a/gitpython-developers/smmap/pull/33 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f0ea97c2e35faff3475d8cbafd37e38923d52cd91db09332551748f75ac053a/gitpython-developers/smmap/pull/33 |
| og:image:alt | BREAKING API:
retrofit git.util.mman as context-manager,
to release memory-mapped regions held.
The mmap-manager(s) are re-entrant, but not thread-safe context-manager(s),
to be used within a wit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ankostis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/smmap git https://github.com/gitpython-developers/smmap.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1865144 |
| octolytics-dimension-repository_nwo | gitpython-developers/smmap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1865144 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/smmap |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd206f7ed6207863172be4a783826e86bd2375c3 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/gitpython-developers/smmap/pull/33#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2Fsmmap%2Fpull%2F33 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2Fsmmap%2Fpull%2F33 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=gitpython-developers%2Fsmmap |
| Reload | https://github.com/gitpython-developers/smmap/pull/33 |
| Reload | https://github.com/gitpython-developers/smmap/pull/33 |
| Reload | https://github.com/gitpython-developers/smmap/pull/33 |
|
gitpython-developers
| https://github.com/gitpython-developers |
| smmap | https://github.com/gitpython-developers/smmap |
|
Notifications
| https://github.com/login?return_to=%2Fgitpython-developers%2Fsmmap |
|
Fork
28
| https://github.com/login?return_to=%2Fgitpython-developers%2Fsmmap |
|
Star
71
| https://github.com/login?return_to=%2Fgitpython-developers%2Fsmmap |
|
Code
| https://github.com/gitpython-developers/smmap |
|
Issues
2
| https://github.com/gitpython-developers/smmap/issues |
|
Pull requests
1
| https://github.com/gitpython-developers/smmap/pulls |
|
Actions
| https://github.com/gitpython-developers/smmap/actions |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/gitpython-developers/smmap/security |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
|
Insights
| https://github.com/gitpython-developers/smmap/pulse |
|
Code
| https://github.com/gitpython-developers/smmap |
|
Issues
| https://github.com/gitpython-developers/smmap/issues |
|
Pull requests
| https://github.com/gitpython-developers/smmap/pulls |
|
Actions
| https://github.com/gitpython-developers/smmap/actions |
|
Security
| https://github.com/gitpython-developers/smmap/security |
|
Insights
| https://github.com/gitpython-developers/smmap/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgitpython-developers%2Fsmmap%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgitpython-developers%2Fsmmap%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/gitpython-developers/smmap/pull/33#issue-comment-box |
| ankostis | https://github.com/ankostis |
| gitpython-developers:master | https://github.com/gitpython-developers/smmap/tree/master |
| ankostis:leaks2 | https://github.com/ankostis/smmap/tree/leaks2 |
|
FIX memoryview leaks and retrofit memory-manager as context-managers
| https://github.com/gitpython-developers/smmap/pull/33#top |
| ankostis | https://github.com/ankostis |
| gitpython-developers:master | https://github.com/gitpython-developers/smmap/tree/master |
| ankostis:leaks2 | https://github.com/ankostis/smmap/tree/leaks2 |
|
Conversation
6
| https://github.com/gitpython-developers/smmap/pull/33 |
|
Commits
19
| https://github.com/gitpython-developers/smmap/pull/33/commits |
|
Checks
0
| https://github.com/gitpython-developers/smmap/pull/33/checks |
|
Files changed
| https://github.com/gitpython-developers/smmap/pull/33/files |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.co/hiddenchars |
| https://github.com/gitpython-developers/smmap/pull/{{ revealButtonHref }} |
|
| https://github.com/ankostis |
| ankostis | https://github.com/ankostis |
| Oct 27, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issue-185619068 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| ankostis | https://github.com/ankostis |
| October 23, 2016 17:09 | https://github.com/gitpython-developers/smmap/pull/33#commits-pushed-2347f3d |
|
| https://github.com/ankostis |
| feat(enc): test with unicode tmpdir | https://github.com/gitpython-developers/smmap/pull/33/commits/2347f3d6121ecd499b4aca2fde734553ba2f445c |
| 2347f3d | https://github.com/gitpython-developers/smmap/pull/33/commits/2347f3d6121ecd499b4aca2fde734553ba2f445c |
| gitpython-developers/GitPython#543 | https://github.com/gitpython-developers/GitPython/pull/543 |
|
| https://github.com/ankostis |
| fix(leaks): attempt to plug the leaks & filter dead regions | https://github.com/gitpython-developers/smmap/pull/33/commits/883217bedd27dc5502a9760b8d734cbe11d39904 |
| 883217b | https://github.com/gitpython-developers/smmap/pull/33/commits/883217bedd27dc5502a9760b8d734cbe11d39904 |
| gitpython-developers#31 | https://github.com/gitpython-developers/smmap/issues/31 |
|
| https://github.com/ankostis |
| chore(ver): bump 2.0.1-->2.1.0.dev0 | https://github.com/gitpython-developers/smmap/pull/33/commits/43c5f233477579eed0b9bd5eb8f0049388e1db82 |
| 43c5f23 | https://github.com/gitpython-developers/smmap/pull/33/commits/43c5f233477579eed0b9bd5eb8f0049388e1db82 |
|
| https://github.com/ankostis |
| fix(regs): fix/rename scream_if_closed()-->collect_closed_regions() | https://github.com/gitpython-developers/smmap/pull/33/commits/f10196f7974cc00e0e2f3e6b52262d66f7b99da1 |
| f10196f | https://github.com/gitpython-developers/smmap/pull/33/commits/f10196f7974cc00e0e2f3e6b52262d66f7b99da1 |
|
| https://github.com/ankostis |
| chore(ver): bump 2.0.1-->2.1.0.dev1 | https://github.com/gitpython-developers/smmap/pull/33/commits/88e276952639711f1bca7774cd04d96a5564aae3 |
| 88e2769 | https://github.com/gitpython-developers/smmap/pull/33/commits/88e276952639711f1bca7774cd04d96a5564aae3 |
|
| https://github.com/ankostis |
| style(listuple): pep8, literals for empty lists/tuples | https://github.com/gitpython-developers/smmap/pull/33/commits/133dd1c9eb26c41683b15ea3459e8b7de5603358 |
| 133dd1c | https://github.com/gitpython-developers/smmap/pull/33/commits/133dd1c9eb26c41683b15ea3459e8b7de5603358 |
|
| https://github.com/ankostis |
| refact(region): rename offset _b --> _ofs | https://github.com/gitpython-developers/smmap/pull/33/commits/7c1eac7944c680ca191fc8e54d92e301ae4b79a9 |
| 7c1eac7 | https://github.com/gitpython-developers/smmap/pull/33/commits/7c1eac7944c680ca191fc8e54d92e301ae4b79a9 |
|
| https://github.com/ankostis |
| refact(minor): use region.priv-func, close fd on same condition | https://github.com/gitpython-developers/smmap/pull/33/commits/bba086aa50c8d57ba84973482d23897e876fe121 |
| bba086a | https://github.com/gitpython-developers/smmap/pull/33/commits/bba086aa50c8d57ba84973482d23897e876fe121 |
|
| https://github.com/ankostis |
| feat(mman): BREAKING API mman as context-manager to release regions | https://github.com/gitpython-developers/smmap/pull/33/commits/a2bc2d2e983e34b576f87127a531fdf978ecc322 |
| a2bc2d2 | https://github.com/gitpython-developers/smmap/pull/33/commits/a2bc2d2e983e34b576f87127a531fdf978ecc322 |
|
| https://github.com/ankostis |
| chore(ver): bump 2.1.0.dev1-->2.1.0.dev3 | https://github.com/gitpython-developers/smmap/pull/33/commits/01df7f33136644b189e8b6a981180cbc4c77f490 |
| 01df7f3 | https://github.com/gitpython-developers/smmap/pull/33/commits/01df7f33136644b189e8b6a981180cbc4c77f490 |
|
| https://github.com/ankostis |
| feat(mman-contxt): opt-out not to scream if mman not entered | https://github.com/gitpython-developers/smmap/pull/33/commits/bf68f775d7a9e176fa518d1d10cca6d351582684 |
| bf68f77 | https://github.com/gitpython-developers/smmap/pull/33/commits/bf68f775d7a9e176fa518d1d10cca6d351582684 |
|
| https://github.com/ankostis |
| fix(leaks): attempt to gc-collect before region-collect | https://github.com/gitpython-developers/smmap/pull/33/commits/4598966aba7bbf8873de5e29893117b95f601379 |
| 4598966 | https://github.com/gitpython-developers/smmap/pull/33/commits/4598966aba7bbf8873de5e29893117b95f601379 |
|
| https://github.com/ankostis |
| fix(mman): exit log-msg were missing left-overs arg, log as debug | https://github.com/gitpython-developers/smmap/pull/33/commits/d0bd74ec3ee0b66ca50e096497234c7ec72f8854 |
| d0bd74e | https://github.com/gitpython-developers/smmap/pull/33/commits/d0bd74ec3ee0b66ca50e096497234c7ec72f8854 |
|
| https://github.com/ankostis |
| refact(buf): also use SlidingWindowMapBuffer as optional context-manager | https://github.com/gitpython-developers/smmap/pull/33/commits/e33235a24d1e3cd9a41079af2b3edd09c5b4a02a |
| e33235a | https://github.com/gitpython-developers/smmap/pull/33/commits/e33235a24d1e3cd9a41079af2b3edd09c5b4a02a |
|
| https://github.com/ankostis |
| refact(TCs): unittestize assertions | https://github.com/gitpython-developers/smmap/pull/33/commits/33f12e64438ff942ec401ef23697e6c31ee03a4a |
| 33f12e6 | https://github.com/gitpython-developers/smmap/pull/33/commits/33f12e64438ff942ec401ef23697e6c31ee03a4a |
|
| https://github.com/ankostis |
| refact(buf): simplify API - no begin/end after construct | https://github.com/gitpython-developers/smmap/pull/33/commits/8489c31d92c63a42273ab04c1d0690f495617ee8 |
| 8489c31 | https://github.com/gitpython-developers/smmap/pull/33/commits/8489c31d92c63a42273ab04c1d0690f495617ee8 |
|
| https://github.com/ankostis |
| style(mman): move managed_mmaps() closer to 2 mmans | https://github.com/gitpython-developers/smmap/pull/33/commits/d81dc1da26227b0e084438040ec114db48b25de5 |
| d81dc1d | https://github.com/gitpython-developers/smmap/pull/33/commits/d81dc1da26227b0e084438040ec114db48b25de5 |
|
| https://github.com/ankostis |
| fix(leaks): FIX memoryview leak in Windows | https://github.com/gitpython-developers/smmap/pull/33/commits/9ba1649d8e987c2e1ad26a54cbfa9cfe5f3884bb |
| 9ba1649 | https://github.com/gitpython-developers/smmap/pull/33/commits/9ba1649d8e987c2e1ad26a54cbfa9cfe5f3884bb |
|
| https://github.com/ankostis |
| chore(ver): bump 2.1.0.dev3-->2.1.0.dev4 | https://github.com/gitpython-developers/smmap/pull/33/commits/144891bc6c3d5ecdd96e522cb4e3571dff948171 |
| 144891b | https://github.com/gitpython-developers/smmap/pull/33/commits/144891bc6c3d5ecdd96e522cb4e3571dff948171 |
| https://github.com/ankostis |
| ankostis | https://github.com/ankostis |
|
tag.leaks
| https://github.com/gitpython-developers/smmap/issues?q=state%3Aopen%20label%3Atag.leaks |
| Oct 27, 2016 | https://github.com/gitpython-developers/smmap/pull/33#event-838326717 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Oct 27, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-256594953 |
| https://coveralls.io/builds/8535937 |
| 144891b | https://github.com/gitpython-developers/smmap/commit/144891bc6c3d5ecdd96e522cb4e3571dff948171 |
| 6e55a1c | https://github.com/gitpython-developers/smmap/commit/6e55a1c70843e5e5e29686176325f309f8285f29 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Oct 27, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-256594954 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://coveralls.io/builds/8535937 |
| 144891b | https://github.com/gitpython-developers/smmap/commit/144891bc6c3d5ecdd96e522cb4e3571dff948171 |
| 6e55a1c | https://github.com/gitpython-developers/smmap/commit/6e55a1c70843e5e5e29686176325f309f8285f29 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/ankostis |
| ankostis | https://github.com/ankostis |
| Oct 27, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-256595666 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| @Byron | https://github.com/Byron |
| where a memoryview is crated | https://github.com/gitpython-developers/smmap/blob/master/smmap/util.py#L26-L28 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/Byron |
| Byron | https://github.com/Byron |
| Dec 8, 2016 | https://github.com/gitpython-developers/smmap/pull/33#event-886656088 |
| https://github.com/Byron |
| Byron | https://github.com/Byron |
| Dec 8, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-265709654 |
| @ankostis | https://github.com/ankostis |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/ankostis |
| ankostis | https://github.com/ankostis |
| Dec 8, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-265712350 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/Byron |
| Byron | https://github.com/Byron |
| Dec 8, 2016 | https://github.com/gitpython-developers/smmap/pull/33#issuecomment-265714049 |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
| https://github.com/EliahKagan |
| EliahKagan | https://github.com/EliahKagan |
|
Dec 13, 2023
| https://github.com/gitpython-developers/smmap/pull/33#ref-issue-1906380130 |
|
SymbolicReference.set_reference may not roll back properly on error
gitpython-developers/GitPython#1669
| https://github.com/gitpython-developers/GitPython/issues/1669 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2Fsmmap%2Fpull%2F33 |
|
| https://github.com/Byron |
|
Byron
| https://github.com/Byron |
|
tag.leaks
| https://github.com/gitpython-developers/smmap/issues?q=state%3Aopen%20label%3Atag.leaks |
| Please reload this page | https://github.com/gitpython-developers/smmap/pull/33 |
|
| https://github.com/ankostis |
|
| https://github.com/coveralls |
|
| https://github.com/Byron |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |