Title: Prefer `import` to `__import__` by zwimer · Pull Request #82 · gitpython-developers/gitdb · GitHub
Open Graph Title: Prefer `import` to `__import__` by zwimer · Pull Request #82 · gitpython-developers/gitdb
X Title: Prefer `import` to `__import__` by zwimer · Pull Request #82 · gitpython-developers/gitdb
Description: What In __init__.py there is a loop that invokes __import__ here: gitdb/gitdb/__init__.py Line 13 in 3415e08 def _init_externals(): Since the loop only has one item this PR convert refactors it to use the standard import. Why Some tooling only works with modules to be imported via import as the packages names are resolve-able without executing code, which __import__ prevents. Possible Changes If it is desired to have smmap added into globals() of __init__.py; I can remove the del smmap line. Right now it is there because __import__, which import is replacing, does not add smmap to globals()
Open Graph Description: What In __init__.py there is a loop that invokes __import__ here: gitdb/gitdb/__init__.py Line 13 in 3415e08 ...
X Description: What In __init__.py there is a loop that invokes __import__ here: gitdb/gitdb/__init__.py Line 13 in 3415e08 ...
Opengraph URL: https://github.com/gitpython-developers/gitdb/pull/82
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:666960c4-e7ba-3013-64f4-15dac81e276b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D536:2D7E6:B917BA:FC8771:696935EE |
| html-safe-nonce | 61371540e039d0082185153015493d3c4d3a97ad381ccff5e72e94762585cb82 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTM2OjJEN0U2OkI5MTdCQTpGQzg3NzE6Njk2OTM1RUUiLCJ2aXNpdG9yX2lkIjoiMTQzNTk1ODkwNjI4ODk0NDYyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b8af5aba2ad9e45e741c395f4064543084061670f4bbe2b3612d0280a2e93d8f |
| hovercard-subject-tag | pull_request:1132648213 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/gitdb/pull/82/files |
| twitter:image | https://avatars.githubusercontent.com/u/20288064?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20288064?s=400&v=4 |
| og:image:alt | What In __init__.py there is a loop that invokes __import__ here: gitdb/gitdb/__init__.py Line 13 in 3415e08 ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/gitdb git https://github.com/gitpython-developers/gitdb.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126093 |
| octolytics-dimension-repository_nwo | gitpython-developers/gitdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126093 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/gitdb |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width