Title: fix: replace deprecated codecs.open with built-in open (#128) by mvanhorn · Pull Request #134 · gitpython-developers/gitdb · GitHub
Open Graph Title: fix: replace deprecated codecs.open with built-in open (#128) by mvanhorn · Pull Request #134 · gitpython-developers/gitdb
X Title: fix: replace deprecated codecs.open with built-in open (#128) by mvanhorn · Pull Request #134 · gitpython-developers/gitdb
Description: Fixes #128. What changed gitdb/db/ref.py:45 used codecs.open(self._ref_file, 'r', encoding="utf-8"). Replaced it with the built-in open(self._ref_file, 'r', encoding="utf-8") and dropped the now-unused import codecs. Why this matters Running the test suite under Python 3.14 emits the warning quoted in the issue: gitdb/db/ref.py:45: DeprecationWarning: codecs.open() is deprecated. Use open() instead. with codecs.open(self._ref_file, 'r', encoding="utf-8") as f: The built-in open() has accepted the encoding keyword since Python 3.0, and the call site already passed encoding="utf-8", so the replacement is byte-for-byte equivalent on every supported Python version. @Byron's comment on the issue ("if using open in its place is backwards compatible within the v3 version of python, this should be an easy fix") is exactly what this is. Verification pytest gitdb/test/db/test_ref.py — 1 passed grep -rn 'codecs.open' --include='*.py' — 0 matches after the change
Open Graph Description: Fixes #128. What changed gitdb/db/ref.py:45 used codecs.open(self._ref_file, 'r', encoding="utf-8"). Replaced it with the built-in open(self._ref_file, 'r', encoding="...
X Description: Fixes #128. What changed gitdb/db/ref.py:45 used codecs.open(self._ref_file, 'r', encoding="utf-8"). Replaced it with the built-in open(self._ref_file, 'r&...
Opengraph URL: https://github.com/gitpython-developers/gitdb/pull/134
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c5bc374a-0c6e-c4f0-83a6-15a8421d1768 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2C0:3FCE56:31F9D81:4799488:6A568EF0 |
| html-safe-nonce | 913b4151b89ba744eaa30599ca4dc170f0e826b2a9072f54a7befed4753af42f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkMwOjNGQ0U1NjozMUY5RDgxOjQ3OTk0ODg6NkE1NjhFRjAiLCJ2aXNpdG9yX2lkIjoiNDY2MTczMDUxNTI4Nzk2OTUyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3135fec88af59ed56abcd42888d9e8b7d7d774fbccd13b0626f1ab2062a3f487 |
| hovercard-subject-tag | pull_request:3607907415 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/gitdb/pull/134/files |
| twitter:image | https://avatars.githubusercontent.com/u/455140?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/455140?s=400&v=4 |
| og:image:alt | Fixes #128. What changed gitdb/db/ref.py:45 used codecs.open(self._ref_file, 'r', encoding="utf-8"). Replaced it with the built-in open(self._ref_file, 'r', encoding="... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8f21be8503ba8fe6154df415b855c03af52eae3f285bd6ae1fef041dc053da38 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/gitdb git https://github.com/gitpython-developers/gitdb.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126093 |
| octolytics-dimension-repository_nwo | gitpython-developers/gitdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126093 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/gitdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 78af172a48a2056810bb627ffa684003e4f9a5ca |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width