Title: Fix Git.transform_kwarg by FrNecas · Pull Request #899 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix Git.transform_kwarg by FrNecas · Pull Request #899 · gitpython-developers/GitPython
X Title: Fix Git.transform_kwarg by FrNecas · Pull Request #899 · gitpython-developers/GitPython
Description: While working on our project I found that old_repo.git.rev_list('HEAD', max_parents=0) started to work differently after the new release of GitPython and our tests started to fail. After some debugging I found the problem. Kwargs were not transformed correctly if a value was set to 0 due to wrong if condition: >>> 0 not in (False, None) False >>> 0 is not False and 0 is not None True The commit also contains a test for the edge case.
Open Graph Description: While working on our project I found that old_repo.git.rev_list('HEAD', max_parents=0) started to work differently after the new release of GitPython and our tests started to fail. After so...
X Description: While working on our project I found that old_repo.git.rev_list('HEAD', max_parents=0) started to work differently after the new release of GitPython and our tests started to fail. ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/899
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bbc9500f-e7f9-7174-ff42-3a2def3f6a31 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9726:2FE4F4:634499:8D6126:696A545E |
| html-safe-nonce | 3f7469c8b2fe2ba0c0504ef32ee58ecef1592c200fecacfa512bc7e9fb8ce8d2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzI2OjJGRTRGNDo2MzQ0OTk6OEQ2MTI2OjY5NkE1NDVFIiwidmlzaXRvcl9pZCI6IjQ0NjU3NzE1MDU4NDgzNzIxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6386f7aa3d74360e71e6b898f8f0ed335ab3c5ea4af5e799404fe0da2707c41a |
| hovercard-subject-tag | pull_request:300238652 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/899/files |
| twitter:image | https://avatars.githubusercontent.com/u/28452337?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/28452337?s=400&v=4 |
| og:image:alt | While working on our project I found that old_repo.git.rev_list('HEAD', max_parents=0) started to work differently after the new release of GitPython and our tests started to fail. After so... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width