René's URL Explorer Experiment


Title: added support for non-ascii directories and file names by xarx00 · Pull Request #860 · gitpython-developers/GitPython · GitHub

Open Graph Title: added support for non-ascii directories and file names by xarx00 · Pull Request #860 · gitpython-developers/GitPython

X Title: added support for non-ascii directories and file names by xarx00 · Pull Request #860 · gitpython-developers/GitPython

Description: This fix allows support for non-ascii filenames, both in workdir and repos. For instance, when your workdir contains non-ascii (0-255) characters, git.Repo.clone_from() didn't work. Implementation: It turned out that the amount of necessary changes is not big. The main problem was in that git.compat.defenc was set to sys.getdefaultencoding() instead of sys.getfilesystemencoding(). sys.getfilesystemencoding() requires Python 2.3. The from builtins import str fixes several str(epath) etc. conversions that were causing UnicodeEncodeError. I have no idea what python2 version is necessary for that. I have tested the fix on Windows7 Pro x64, both with Python 2.7.13 and 3.7.3.

Open Graph Description: This fix allows support for non-ascii filenames, both in workdir and repos. For instance, when your workdir contains non-ascii (0-255) characters, git.Repo.clone_from() didn't work. Implementat...

X Description: This fix allows support for non-ascii filenames, both in workdir and repos. For instance, when your workdir contains non-ascii (0-255) characters, git.Repo.clone_from() didn't work. Impleme...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/860

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba2d54cc-c3b0-85e0-f243-ef02083c8e49
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE16:3B149:40BA89:5821D3:69694934
html-safe-noncef5828e5b255300d32001e5918ec25bd47288b1113b655c12bc12041be603cf27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTE2OjNCMTQ5OjQwQkE4OTo1ODIxRDM6Njk2OTQ5MzQiLCJ2aXNpdG9yX2lkIjoiODkyNjgxMTA5MjM2NDY0MjYxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca39f652acece35da9bdce5fd7b06339b2e17587fc4cef6a20cc8d61b47aac2b7
hovercard-subject-tagpull_request:267989003
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/860/files
twitter:imagehttps://avatars.githubusercontent.com/u/15482887?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15482887?s=400&v=4
og:image:altThis fix allows support for non-ascii filenames, both in workdir and repos. For instance, when your workdir contains non-ascii (0-255) characters, git.Repo.clone_from() didn't work. Implementat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/860/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F860%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F860%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/860/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/860/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/860/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/860/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/860/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
gitpython-developers:masterhttps://github.com/gitpython-developers/GitPython/tree/master
xarx00:PR-non-ascii-filenameshttps://github.com/xarx00/GitPython/tree/PR-non-ascii-filenames
Conversation 3 https://github.com/gitpython-developers/GitPython/pull/860
Commits 3 https://github.com/gitpython-developers/GitPython/pull/860/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/860/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/860/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/860/files
added support for non-ascii directories and file names https://github.com/gitpython-developers/GitPython/pull/860/files#top
Show all changes 3 commits https://github.com/gitpython-developers/GitPython/pull/860/files
3953d71 added support for non-ascii directories and file names xarx00 Apr 5, 2019 https://github.com/gitpython-developers/GitPython/pull/860/commits/3953d71374994a00c7ef756040d2c77090f07bb4
a6f596d Fix for: No module named builtins (CI tests error) xarx00 Apr 5, 2019 https://github.com/gitpython-developers/GitPython/pull/860/commits/a6f596d7f46cb13a3d87ff501c844c461c0a3b0a
a77eab2 builtins module is part of the future package xarx00 Apr 5, 2019 https://github.com/gitpython-developers/GitPython/pull/860/commits/a77eab2b5668cd65a3230f653f19ee00c34789bf
Clear filters https://github.com/gitpython-developers/GitPython/pull/860/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/860/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/860/files
compat.py https://github.com/gitpython-developers/GitPython/pull/860/files#diff-2f2b548c14a71e5bbf15502f6d7fd98a50842119152c451ae2ec5e1cc42f02d2
base.py https://github.com/gitpython-developers/GitPython/pull/860/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
requirements.txt https://github.com/gitpython-developers/GitPython/pull/860/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552
git/compat.pyhttps://github.com/gitpython-developers/GitPython/pull/860/files#diff-2f2b548c14a71e5bbf15502f6d7fd98a50842119152c451ae2ec5e1cc42f02d2
View file https://github.com/xarx00/GitPython/blob/a77eab2b5668cd65a3230f653f19ee00c34789bf/git/compat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/860/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/860/files#diff-2f2b548c14a71e5bbf15502f6d7fd98a50842119152c451ae2ec5e1cc42f02d2
https://github.com/gitpython-developers/GitPython/pull/860/files#diff-2f2b548c14a71e5bbf15502f6d7fd98a50842119152c451ae2ec5e1cc42f02d2
git/repo/base.pyhttps://github.com/gitpython-developers/GitPython/pull/860/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
View file https://github.com/xarx00/GitPython/blob/a77eab2b5668cd65a3230f653f19ee00c34789bf/git/repo/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/860/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/860/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
https://github.com/gitpython-developers/GitPython/pull/860/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
requirements.txthttps://github.com/gitpython-developers/GitPython/pull/860/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552
View file https://github.com/xarx00/GitPython/blob/a77eab2b5668cd65a3230f653f19ee00c34789bf/requirements.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/860/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.