Title: Fix setup.py and use of requirements files and add a docker test container by jeking3 · Pull Request #826 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix setup.py and use of requirements files and add a docker test container by jeking3 · Pull Request #826 · gitpython-developers/GitPython
X Title: Fix setup.py and use of requirements files and add a docker test container by jeking3 · Pull Request #826 · gitpython-developers/GitPython
Description: Before: jking@ubuntu:~/GitPython$ python3 setup.py check /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'test_requirements' warnings.warn(msg) running check Note that setup.py was not even using the contents of requirements.txt or test-requirements.txt. Now it does, and it properly identifies the tests-require field. The requirements.txt file declared a runtime dependency on a testing package. I'm assuming that is an error (although it could be used in production code, I don't know...) so I removed that. When I ran tox locally on Python 3.6.7 I saw a flake8 error F821 which I disabled as it looks bogus - that exception is defined in the documentation. Added a docker container that you can use with a couple new make targets. This allows you to run python 2.7, 3.4, 3.5, 3.6, or 3.7 tox even if you are on a local branch not named "master" (some tests require this). Finally, found and fixed the issue on CI with python 3.7 / Xenial / travis. The root cause is that in git 2.20 new behavior was introduced to stop "git fetch --tags" from clobbering local tags that have changed: git/git@0bc8d71 The unit tests expect the old behavior, so now we pass --force down if the version is 2.20 or higher (for the remote test only, the code change is in the test code). It took a while to find this because for some reason when GitCommandError returns an error code, stderr isn't captured. If it was, it would have been easier to figure this out...
Open Graph Description: Before: jking@ubuntu:~/GitPython$ python3 setup.py check /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'test_requirements' warnings.warn(msg) running...
X Description: Before: jking@ubuntu:~/GitPython$ python3 setup.py check /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'test_requirements' warnings.warn(msg)...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/826
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8ccd4513-f08a-77ce-3ee8-98d2df60991d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CD0:1F2A01:1A94605:2560DF1:6968FFE3 |
| html-safe-nonce | b5d05b8376add568fc1ea07355b68211fdbf0689fc4a129fda17c7809e36e288 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0QwOjFGMkEwMToxQTk0NjA1OjI1NjBERjE6Njk2OEZGRTMiLCJ2aXNpdG9yX2lkIjoiNDYwOTE5MzE1Njc1Mjc2ODk5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b61898d25d97abc5318e2fe3f154aa246294a77acd4558d345523438b9dc99c2 |
| hovercard-subject-tag | pull_request:244944280 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/826/files |
| twitter:image | https://avatars.githubusercontent.com/u/11771245?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11771245?s=400&v=4 |
| og:image:alt | Before: jking@ubuntu:~/GitPython$ python3 setup.py check /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'test_requirements' warnings.warn(msg) running... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fd1938215b152e2c6a29cf56fec07fd9f91f1203 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width