René's URL Explorer Experiment


Title: GPG signature support on commit object. by sugi · Pull Request #57 · gitpython-developers/GitPython · GitHub

Open Graph Title: GPG signature support on commit object. by sugi · Pull Request #57 · gitpython-developers/GitPython

X Title: GPG signature support on commit object. by sugi · Pull Request #57 · gitpython-developers/GitPython

Description: Current version fails if any commit object has GPG signeture. It works by just deleting lines from 433 to 440 of git/objects/commit.py. I can't find documentation of git object format. But I tried to write support GPG signature on commit object. Please consider to merge. Here is the way to reproduce problem: sugi@vaj-k-334-sugi:~% mkdir signed-test sugi@vaj-k-334-sugi:~% cd signed-test sugi@vaj-k-334-sugi:~/signed-tes/% git init Initialized empty Git repository in /home/sugi/signed-test/.git/ git@vaj-k-334-sugi:~/signed-test% date > date.txt sugi@vaj-k-334-sugi:~/signed-test% git add . sugi@vaj-k-334-sugi:~/signed-test% git commit -S -m 'Test commit with GPG sig.' You need a passphrase to unlock the secret key for user: "Tatsuki Sugiura " 1024-bit DSA key, ID 4502FDC2, created 2000-09-30 gpg: gpg-agent is not available in this session [master (root-commit) afad9ad] Test commit with GPG sig. 1 file changed, 1 insertion(+) create mode 100644 date.txt sugi@vaj-k-334-sugi:~/signed-test% git cat-file commit HEAD tree 9165a13698f6b211db3d9631958ef11e8d06d477 author Tatsuki Sugiura 1336266773 +0900 committer Tatsuki Sugiura 1336266773 +0900 gpgsig -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAk+l0BUACgkQbK2FzkUC/cLR9wCeKUkjeA39+vy0T/TwJuqPhca3 eNMAnRw0tDNAqIcM4HJnHvzCsu86dLGV =ZlAu -----END PGP SIGNATURE----- Test commit with GPG sig. sugi@vaj-k-334-sugi:~/signed-test% python Python 2.7.3rc2 (default, Apr 22 2012, 22:35:38) [GCC 4.6.3] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import git >>> git = git.Repo("/home/sugi/signed-test") >>> git.commit() >>> git.commit().author afad9ad7986c98784288ae71deb696d505cdfe5c Traceback (most recent call last): File "", line 1, in File "/home/sugi/lib/python2.7/site-packages/gitdb-0.5.4-py2.7-linux-x86_64.egg/gitdb/util.py", line 238, in __getattr__ self._set_cache_(attr) File "/home/sugi/lib/python2.7/site-packages/GitPython-0.3.2.RC1-py2.7.egg/git/objects/commit.py", line 133, in _set_cache_ self._deserialize(StringIO(stream.read())) File "/home/sugi/lib/python2.7/site-packages/GitPython-0.3.2.RC1-py2.7.egg/git/objects/commit.py", line 444, in _deserialize self.author.name = self.author.name.decode(self.encoding) LookupError: unknown encoding: -----BEGIN PGP SIGNATURE-----

Open Graph Description: Current version fails if any commit object has GPG signeture. It works by just deleting lines from 433 to 440 of git/objects/commit.py. I can't find documentation of git object format. But I tr...

X Description: Current version fails if any commit object has GPG signeture. It works by just deleting lines from 433 to 440 of git/objects/commit.py. I can't find documentation of git object format. But ...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/57

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cd2c91a4-d283-4d32-3465-a311490c8d38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8626:8619D:6152B4:810383:696985B8
html-safe-noncece2a9277127a681fefbb497a7c2d0f55a6e26e453939a8d77a262c69d62ea153
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjI2Ojg2MTlEOjYxNTJCNDo4MTAzODM6Njk2OTg1QjgiLCJ2aXNpdG9yX2lkIjoiNzY1MzUwMDE4MTI3NzE0ODYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac25a7566154d1b47b3eb8d60e345d4ea8393aa75542ac3ac95f78730882b8870c
hovercard-subject-tagpull_request:1295271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/57/files
twitter:imagehttps://avatars.githubusercontent.com/u/11642?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11642?s=400&v=4
og:image:altCurrent version fails if any commit object has GPG signeture. It works by just deleting lines from 433 to 440 of git/objects/commit.py. I can't find documentation of git object format. But I tr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None533e7cac596c452090972c1150d587fd0b36531b8dc4e8bbfe4ab694aca02408
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63d27af10eea2ccab520b162530cf6c7b739e767
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/57/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F57%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F57%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/57/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/57/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/57/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/57/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/57/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
sugihttps://github.com/sugi
gitpython-developers:masterhttps://github.com/gitpython-developers/GitPython/tree/master
sugi:signed-commithttps://github.com/sugi/GitPython/tree/signed-commit
Conversation 4 https://github.com/gitpython-developers/GitPython/pull/57
Commits 1 https://github.com/gitpython-developers/GitPython/pull/57/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/57/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/57/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/57/files
GPG signature support on commit object. https://github.com/gitpython-developers/GitPython/pull/57/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/57/files
e30881a gpg signature support on commit object. sugi May 6, 2012 https://github.com/gitpython-developers/GitPython/pull/57/commits/e30881ad2e176a05e22f1dd30b5fed8d59b29587
Clear filters https://github.com/gitpython-developers/GitPython/pull/57/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/57/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/57/files
git/objects/commit.pyhttps://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
View file https://github.com/sugi/GitPython/blob/e30881ad2e176a05e22f1dd30b5fed8d59b29587/git/objects/commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/57/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/57/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.