Title: Store raw path bytes in Diff instances by nvie · Pull Request #474 · gitpython-developers/GitPython · GitHub
Open Graph Title: Store raw path bytes in Diff instances by nvie · Pull Request #474 · gitpython-developers/GitPython
X Title: Store raw path bytes in Diff instances by nvie · Pull Request #474 · gitpython-developers/GitPython
Description: Previously, the following fields on Diff instances were assumed to be passed in as unicode strings: a_path b_path rename_from rename_to However, since Git natively records paths as bytes, these may potentially not have a valid unicode representation. This patch changes the Diff instance to instead take the following equivalent fields that should be raw bytes instead: a_rawpath b_rawpath raw_rename_from raw_rename_to NOTE ON BACKWARD COMPATIBILITY: The original a_path, b_path, etc. fields are still available as properties (rather than slots). These properties now dynamically decode the raw bytes into a unicode string (performing the potentially destructive operation of replacing invalid unicode chars by "�"'s). This means that all code using Diffs should remain backward compatible. The only exception is when people would manually construct Diff instances by calling the constructor directly, in which case they should now pass in bytes rather than unicode strings. See also the discussion on #467
Open Graph Description: Previously, the following fields on Diff instances were assumed to be passed in as unicode strings: a_path b_path rename_from rename_to However, since Git natively records paths as bytes, these m...
X Description: Previously, the following fields on Diff instances were assumed to be passed in as unicode strings: a_path b_path rename_from rename_to However, since Git natively records paths as bytes, these m...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/474
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f3851b5f-8d45-e70c-20ba-c7c717227002 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C980:E3F0D:198FE09:2136A5D:696B2F6F |
| html-safe-nonce | e2388f97c9e3a31e62468ca7a5eec64d17101977861ac15e3f162200f9e99138 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTgwOkUzRjBEOjE5OEZFMDk6MjEzNkE1RDo2OTZCMkY2RiIsInZpc2l0b3JfaWQiOiI1MzEzNTExNzQ4MjY4NjY2NzM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b421637b149286b35770656649c868a2320f054831b8ca7db2708419fe6215af |
| hovercard-subject-tag | pull_request:73814281 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/474/files |
| twitter:image | https://avatars.githubusercontent.com/u/83844?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/83844?s=400&v=4 |
| og:image:alt | Previously, the following fields on Diff instances were assumed to be passed in as unicode strings: a_path b_path rename_from rename_to However, since Git natively records paths as bytes, these m... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width