René's URL Explorer Experiment


Title: Fix order of operators before executing the git command by guyzmo · Pull Request #431 · gitpython-developers/GitPython · GitHub

Open Graph Title: Fix order of operators before executing the git command by guyzmo · Pull Request #431 · gitpython-developers/GitPython

X Title: Fix order of operators before executing the git command by guyzmo · Pull Request #431 · gitpython-developers/GitPython

Description: Hello, For a tool I'm writing git-repo, I was working with a mockup of subprocess to run regression tests for commands issued through GitPython. I've written a process similar to the VCR or Betamax libraries to define expected command calls passed through Popen. Here is where I setup the mockup, and here is a place where I use it. It was working great, up until recently when I've introduced the --progress support. Then I've been hitting an issue where the same code would fail inconsistently between calls. Cf the travis reports. With a fair bit of debugging, I found out the issue is that because GitPython relies on the kwargs construct to pass around optional arguments, the order of argument will depend on the order of the items within the dict. As when I introduced progress support, opt_arg contains '-v' and '--progress' now, the order depending on both hash('-v') and hash('--progress'). So this request for merging is intended to fix that issue by simply ordering optional arguments by their name before passing the command to subprocess.

Open Graph Description: Hello, For a tool I'm writing git-repo, I was working with a mockup of subprocess to run regression tests for commands issued through GitPython. I've written a process similar to the VCR or...

X Description: Hello, For a tool I'm writing git-repo, I was working with a mockup of subprocess to run regression tests for commands issued through GitPython. I've written a process similar to th...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/431

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0592ee61-2d53-44ad-0aa1-8e7f8504d882
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA484:C9E9C:100C3FE:166CBD0:696A2C06
html-safe-nonce998b83a27ca08f36c14396c7a5b75079c4eff72bb646f176d40986c406895edd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDg0OkM5RTlDOjEwMEMzRkU6MTY2Q0JEMDo2OTZBMkMwNiIsInZpc2l0b3JfaWQiOiI3Mzc0MjQ3OTk2MTcxMTAzMjM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99eeb2e8af27788dd7fcff9e3f96b25f61db5719a8126b58321f2b2a14a87660
hovercard-subject-tagpull_request:69853408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/431/files
twitter:imagehttps://avatars.githubusercontent.com/u/254441?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/254441?s=400&v=4
og:image:altHello, For a tool I'm writing git-repo, I was working with a mockup of subprocess to run regression tests for commands issued through GitPython. I've written a process similar to the VCR or...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneade130928b3890d20ecf9c887468a17e88d5c9a740ea2a85c2c2162e7c58e623
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec00842167ca2e5b13e8171812965d503e925ece6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/431/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F431%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F431%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/431/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/431/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/431/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:masterhttps://github.com/gitpython-developers/GitPython/tree/master
guyzmo:fix-opt_arg-orderhttps://github.com/guyzmo/GitPython/tree/fix-opt_arg-order
Conversation 14 https://github.com/gitpython-developers/GitPython/pull/431
Commits 1 https://github.com/gitpython-developers/GitPython/pull/431/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/431/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/431/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Fix order of operators before executing the git command https://github.com/gitpython-developers/GitPython/pull/431/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/431/files
89ade7b Fix order of operators before executing the git command guyzmo May 12, 2016 https://github.com/gitpython-developers/GitPython/pull/431/commits/89ade7bfff534ae799d7dd693b206931d5ed3d4f
Clear filters https://github.com/gitpython-developers/GitPython/pull/431/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/431/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/guyzmo/GitPython/blob/89ade7bfff534ae799d7dd693b206931d5ed3d4f/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/431/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/431/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
boegelhttps://github.com/boegel
May 25, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64649040
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://pypi.python.org/pypi/ordereddicthttps://pypi.python.org/pypi/ordereddict
https://github.com/gitpython-developers/GitPython/blob/master/git/config.py#L20https://github.com/gitpython-developers/GitPython/blob/master/git/config.py#L20
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Byronhttps://github.com/Byron
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64694649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@boegelhttps://github.com/boegel
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
boegelhttps://github.com/boegel
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64698605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Byronhttps://github.com/Byron
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64699336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
changeloghttps://github.com/gitpython-developers/GitPython/blob/master/doc/source/changes.rst#200---features
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
boegelhttps://github.com/boegel
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64700314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Byronhttps://github.com/Byron
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Byronhttps://github.com/Byron
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64701123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
Byronhttps://github.com/Byron
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64701634
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://travis-ci.org/gitpython-developers/GitPython/jobs/133041770https://travis-ci.org/gitpython-developers/GitPython/jobs/133041770
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
boegelhttps://github.com/boegel
May 26, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r64702103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#431https://github.com/gitpython-developers/GitPython/pull/431
https://travis-ci.org/gitpython-developers/GitPython/jobs/133041770https://travis-ci.org/gitpython-developers/GitPython/jobs/133041770
easybuilders/easybuild-framework#1781https://github.com/easybuilders/easybuild-framework/pull/1781
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
https://github.com/gitpython-developers/GitPython/pull/431/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/431/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
dmerejkowskyhttps://github.com/dmerejkowsky
May 12, 2016https://github.com/gitpython-developers/GitPython/pull/431/files#r63063312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/431/files
https://github.com/gitpython-developers/GitPython/pull/431/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.