Title: Allow submodules to be ignored in is_dirty by Javex · Pull Request #294 · gitpython-developers/GitPython · GitHub
Open Graph Title: Allow submodules to be ignored in is_dirty by Javex · Pull Request #294 · gitpython-developers/GitPython
X Title: Allow submodules to be ignored in is_dirty by Javex · Pull Request #294 · gitpython-developers/GitPython
Description: I had a use case with PyGitUp where I did not want submodules to be considered when asking whether a repo is dirty. This change allows that. I am a bit unsure with the "untracked_files" part: I would think that it's not necessary, as I can't imagine an untracked submodule (how would that work? Git would not see it as a submodule), but I included this change anyway. I can of course revert it if you are sure that there can't be a relevant case. One problem though: I could not run (and thus not write) tests as even the most current tag had test failures for me on Python 2.7. Please let me know what you think.
Open Graph Description: I had a use case with PyGitUp where I did not want submodules to be considered when asking whether a repo is dirty. This change allows that. I am a bit unsure with the "untracked_files" p...
X Description: I had a use case with PyGitUp where I did not want submodules to be considered when asking whether a repo is dirty. This change allows that. I am a bit unsure with the "untracked_files&...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/294
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:66eb6561-2763-2a4f-0cb9-121ae8554db1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADF2:2DCB72:E430C:141F78:6969FA0A |
| html-safe-nonce | 7a3b2927546d4e1beb7919d803886fec88e5ae9084ab4d29273fe32186548a14 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREYyOjJEQ0I3MjpFNDMwQzoxNDFGNzg6Njk2OUZBMEEiLCJ2aXNpdG9yX2lkIjoiNDM5MzMxNTE3Njg5OTI3OTM3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 138d61f3452a312fc82656df223160e40b4b7da2e1a56d2b94da4d02ee4ff73e |
| hovercard-subject-tag | pull_request:37015543 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/294/files |
| twitter:image | https://avatars.githubusercontent.com/u/641439?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/641439?s=400&v=4 |
| og:image:alt | I had a use case with PyGitUp where I did not want submodules to be considered when asking whether a repo is dirty. This change allows that. I am a bit unsure with the "untracked_files" p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width