Title: fix(gix): use Git for .gitmodules lines that Git reject karta hai by Keerthana-64 · Pull Request #2345 · gitpython-developers/GitPython · GitHub
Open Graph Title: fix(gix): use Git for .gitmodules lines that Git reject karta hai by Keerthana-64 · Pull Request #2345 · gitpython-developers/GitPython
X Title: fix(gix): use Git for .gitmodules lines that Git reject karta hai by Keerthana-64 · Pull Request #2345 · gitpython-developers/GitPython
Description: gix backend mein _backend.submodule_config, GixPython ke ModulesFile.from_bytes ka use karke .gitmodules file ko read karta hai. Yeh parser un lines ko bhi accept kar leta hai jinhe Git bad config line ke saath reject karta hai, aur phir bhi unse settings return karta hai. Example ke liye, url = ../good ke baad agar ek line x url = ../evil ho, toh parser ise implicit x plus url = ../evil ke roop mein read karta hai. Is wajah se repo.submodules ../evil report karta hai aur Submodule.update(init=True) us URL se clone kar leta hai, jabki git submodule update --init is invalid configuration par ruk jata hai. git fsck --strict sirf gitmodulesParse warning deta hai, aur CLI backend ParsingError raise karta hai. GixPython mein strict mode available nahi hai, isliye adapter ab Git par fallback karta hai, jab tak har line inmein se ek na ho: blank line, comment, ek bare submodule header, ya ek single key = [value] setting. Yeh guard sirf fallback select karta hai aur kabhi bhi khud values produce nahi karta. Is mismatch ko doc/gix-backend.md mein GIX-35 ke roop mein document kiya gaya hai. Motivation: Yeh issue is baat ke review ke dauran saamne aaya ki native gix adapters untrusted repository content ko kaise handle karte hain, aur same input par har adapter ko Git ke saath compare kiya gaya. test_submodule_configuration_rejects_lines_git_rejects test, change se pehle gix par teeno fixture scenarios mein fail hota tha, aur change ke baad dono backends par pass hota hai. git config --list ke against chalaye gaye differential fuzzer ne change se pehle rejected files mein native values find ki thi, lekin change ke baad 13,000 inputs mein aisi koi value nahi mili. Jahan Git file accept karta hai, wahan values mein koi difference nahi mila. Full test suite dono backends par pass hoti hai (gix par native submodule reads abhi bhi 943 calls serve karti hain). Iske alawa ruff, mypy aur shellcheck bhi pass hote hain. Testing macOS par Git 2.54.0 aur GixPython 0.3.0 ke saath ki gayi hai.
Open Graph Description: gix backend mein _backend.submodule_config, GixPython ke ModulesFile.from_bytes ka use karke .gitmodules file ko read karta hai. Yeh parser un lines ko bhi accept kar leta hai jinhe Git bad config ...
X Description: gix backend mein _backend.submodule_config, GixPython ke ModulesFile.from_bytes ka use karke .gitmodules file ko read karta hai. Yeh parser un lines ko bhi accept kar leta hai jinhe Git bad config ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2345
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:989b9abf-6838-f670-17fb-3c5a7f027e61 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92EA:32975D:662FE3:88B414:6B00AB0A |
| html-safe-nonce | 8933add21ed321ed474d39effee43305a589d0865e48e209713151f124c7e1c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkVBOjMyOTc1RDo2NjJGRTM6ODhCNDE0OjZCMDBBQjBBIiwidmlzaXRvcl9pZCI6IjE1ODQ1ODU3NDcwODI1NTQxMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4ff587f05cced3b5a90c7c5bcc602e9bafa24f050c6f165ec782601c32aac0ea |
| hovercard-subject-tag | pull_request:5314114305 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2345/files |
| twitter:image | https://avatars.githubusercontent.com/u/304463654?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/304463654?s=400&v=4 |
| og:image:alt | gix backend mein _backend.submodule_config, GixPython ke ModulesFile.from_bytes ka use karke .gitmodules file ko read karta hai. Yeh parser un lines ko bhi accept kar leta hai jinhe Git bad config ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2f575159976167242d488c0b062eb355c4e198b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width