René's URL Explorer Experiment


Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython · GitHub

Open Graph Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython

X Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython

Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub account. CodeQL default setup for this repository was switched (by Eliah) from the default query suite to extended. The first extended analysis of main (at 38992bc) raised exactly one new alert, #56. It is a high-severity py/overly-permissive-file ("Overly permissive mask in chmod sets file to world writable") on the os.chmod(path, 0o777) in git.util.rmfile. That call only runs on Windows, where it clears the read-only attribute so that os.remove can delete the file. There, os.chmod ignores every bit except 0o200 (stat.S_IWUSR). So 0o777 was never more permissive in practice, but it says more than the code means. This PR passes stat.S_IWUSR instead, as the rmtree error handler just above already does. CodeQL doesn't flag that call. Behavior is unchanged on every platform. The commit messages give the details, including where CPython implements this. Nothing tested rmfile on a read-only file, so this also adds TestRmfile.test_deletes_readonly_file. It checks that its fixture really made a non-writable file before checking that rmfile deletes it. On Windows, it would fail if rmfile passed a mode without the owner-write bit. Validation: Windows, the only platform where the changed line runs: on Eliah's fork, the test (windows, 3.14) job of this run passed, and its log shows TestRmfile::test_deletes_readonly_file PASSED. The run tested f62223c, which has the same tree as this PR's head; only the commit messages have changed since. When this PR was opened, the run's other Windows test jobs were still in progress, and no job in the run had failed. Run on macOS (Python 3.12): the TestRmtree and TestRmfile tests pass both with and without the change. ruff and shellcheck pass. Not tested: Cygwin. The import-cygwin workflow does not run the test suite. Not verified: that alert #56 closes. CodeQL default setup doesn't analyze PRs from forks. I (Claude) expect the alert to close as fixed on the first analysis of main after merging, since the identical call in rmtree is not flagged. 🤖 Generated with Claude Code

Open Graph Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub ...

X Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's Git...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2328

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5ecdb13f-ba96-a09a-4e3e-26efac071425
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4EA:11EACE:27C7E3:368EF3:6B00C2E7
html-safe-nonce4a4976ca7aa5f109d1b6d359580095b3ade7e7f1fbad21d4ea746531335cf9a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEVBOjExRUFDRToyN0M3RTM6MzY4RUYzOjZCMDBDMkU3IiwidmlzaXRvcl9pZCI6IjQxNzQ1NjQzMTkyMTc4OTQxMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac64906c8413195454bd9c1850f0577175a4ecb20934edb8125b658022ad7ab02f
hovercard-subject-tagpull_request:5087314010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2328/files
twitter:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
og:image:altNoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2328/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2328%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2328%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2328/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2328/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2328/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
EliahKaganhttps://github.com/EliahKagan
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:claude/rmfile-chmod-owner-writehttps://github.com/EliahKagan/GitPython/tree/claude/rmfile-chmod-owner-write
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2328
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2328/commits
Checks 64 https://github.com/gitpython-developers/GitPython/pull/2328/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2328/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2328/files
refactor(util): clear read-only in rmfile with stat.S_IWUSR https://github.com/gitpython-developers/GitPython/pull/2328/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2328/files
d74c104 test(util): cover `rmfile` deleting a read-only file EliahKagan Oct 30, 2026 https://github.com/gitpython-developers/GitPython/pull/2328/commits/d74c10431b5938f9b4c08250879e85f422051060
53f3c62 refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` EliahKagan Oct 30, 2026 https://github.com/gitpython-developers/GitPython/pull/2328/commits/53f3c6213ea2893acfdfa65715dd7bb64ce1eed0
Clear filters https://github.com/gitpython-developers/GitPython/pull/2328/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2328/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2328/files
util.py https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test_util.py https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
rmfile.sh https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-c2c8a61cc2155eccc9ac918d56ab3b10c237f17208b5272d88b357390e844aa0
git/util.pyhttps://github.com/gitpython-developers/GitPython/pull/2328/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
View file https://github.com/EliahKagan/GitPython/blob/53f3c6213ea2893acfdfa65715dd7bb64ce1eed0/git/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2328/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test/test_util.pyhttps://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
View file https://github.com/EliahKagan/GitPython/blob/53f3c6213ea2893acfdfa65715dd7bb64ce1eed0/test/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2328/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2328/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
tests/fixtures/rmfile.shhttps://github.com/gitpython-developers/GitPython/pull/2328/files#diff-c2c8a61cc2155eccc9ac918d56ab3b10c237f17208b5272d88b357390e844aa0
View file https://github.com/EliahKagan/GitPython/blob/53f3c6213ea2893acfdfa65715dd7bb64ce1eed0/tests/fixtures/rmfile.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2328/{{ revealButtonHref }}
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2328/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.