Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython · GitHub
Open Graph Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython
X Title: refactor(util): clear read-only in `rmfile` with `stat.S_IWUSR` by EliahKagan · Pull Request #2328 · gitpython-developers/GitPython
Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub account. CodeQL default setup for this repository was switched (by Eliah) from the default query suite to extended. The first extended analysis of main (at 38992bc) raised exactly one new alert, #56. It is a high-severity py/overly-permissive-file ("Overly permissive mask in chmod sets file to world writable") on the os.chmod(path, 0o777) in git.util.rmfile. That call only runs on Windows, where it clears the read-only attribute so that os.remove can delete the file. There, os.chmod ignores every bit except 0o200 (stat.S_IWUSR). So 0o777 was never more permissive in practice, but it says more than the code means. This PR passes stat.S_IWUSR instead, as the rmtree error handler just above already does. CodeQL doesn't flag that call. Behavior is unchanged on every platform. The commit messages give the details, including where CPython implements this. Nothing tested rmfile on a read-only file, so this also adds TestRmfile.test_deletes_readonly_file. It checks that its fixture really made a non-writable file before checking that rmfile deletes it. On Windows, it would fail if rmfile passed a mode without the owner-write bit. Validation: Windows, the only platform where the changed line runs: on Eliah's fork, the test (windows, 3.14) job of this run passed, and its log shows TestRmfile::test_deletes_readonly_file PASSED. The run tested f62223c, which has the same tree as this PR's head; only the commit messages have changed since. When this PR was opened, the run's other Windows test jobs were still in progress, and no job in the run had failed. Run on macOS (Python 3.12): the TestRmtree and TestRmfile tests pass both with and without the change. ruff and shellcheck pass. Not tested: Cygwin. The import-cygwin workflow does not run the test suite. Not verified: that alert #56 closes. CodeQL default setup doesn't analyze PRs from forks. I (Claude) expect the alert to close as fixed on the first analysis of main after merging, since the identical call in rmtree is not flagged. 🤖 Generated with Claude Code
Open Graph Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub ...
X Description: NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's Git...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2328
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5ecdb13f-ba96-a09a-4e3e-26efac071425 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4EA:11EACE:27C7E3:368EF3:6B00C2E7 |
| html-safe-nonce | 4a4976ca7aa5f109d1b6d359580095b3ade7e7f1fbad21d4ea746531335cf9a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEVBOjExRUFDRToyN0M3RTM6MzY4RUYzOjZCMDBDMkU3IiwidmlzaXRvcl9pZCI6IjQxNzQ1NjQzMTkyMTc4OTQxMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 64906c8413195454bd9c1850f0577175a4ecb20934edb8125b658022ad7ab02f |
| hovercard-subject-tag | pull_request:5087314010 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2328/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | NoteAI-generated PR: This pull request, its commits and this description were written by an AI agent (Claude Code, using Claude Opus 5.5) acting on behalf of Eliah Kagan through Eliah's GitHub ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width