René's URL Explorer Experiment


Title: fix(config): match `~/` gitdir includes on Windows by b84330808 · Pull Request #2305 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(config): match `~/` gitdir includes on Windows by b84330808 · Pull Request #2305 · gitpython-developers/GitPython

X Title: fix(config): match `~/` gitdir includes on Windows by b84330808 · Pull Request #2305 · gitpython-developers/GitPython

Description: On Windows, GitConfigParser never applies an [includeIf "gitdir:~/..."] section, while git config does. os.path.expanduser returns the home directory with backslashes, so gitdir:~/work/ becomes C:\Users\me/work/**. GitPython compares gitdir patterns with git_dir written with forward slashes, and a backslash in a gitdir pattern escapes the next character, so the pattern never matches. Git converts the home directory to forward slashes when it expands ~ on Windows (interpolate_path() in path.c, used by prepare_include_condition_pattern() in config.c). So with the usual setup [includeIf "gitdir:~/work/"] path = ~/.gitconfig-work GitPython reads user.email etc. for a repository under ~/work from the global config only. Repro on Windows, in a repository under the home directory whose .git/config includes a file that sets user.email = work@example.com through gitdir:~//: > git config --get user.email work@example.com > python -c "import git; print(git.Repo('.').config_reader('repository').get_value('user', 'email', 'NOT FOUND'))" NOT FOUND Change On Windows, a pattern that is ~ or starts with ~/ gets the home directory with forward slashes. The rest of the pattern is unchanged, so backslashes written in the pattern are still escapes (test_conditional_includes_do_not_treat_backslashes_as_separators still passes). Other platforms and ~user patterns keep the previous os.path.expanduser call. Tests test_conditional_includes_expand_home_in_git_dir_pattern points the home directory at a temporary directory and checks that gitdir:~/target/ matches a repository below it. On Windows it fails without the change and passes with it; on other platforms it passes either way. Validation Run by the agent on Windows 11, Git for Windows 2.51.2, Python 3.11.9: test/test_config.py: 55 passed, 3 skipped ruff check, ruff format --check, mypy, basedpyright --warnings: no issues full suite: same failures with and without the change, all from missing symlink privilege (WinError 1314) in test_submodule.py plus test/performance/test_commit.py the repro above prints work@example.com after the change This change and description were written by Claude Code (an AI agent) and opened through @b84330808's account.

Open Graph Description: On Windows, GitConfigParser never applies an [includeIf "gitdir:~/..."] section, while git config does. os.path.expanduser returns the home directory with backslashes, so gitdir:~/work/ b...

X Description: On Windows, GitConfigParser never applies an [includeIf "gitdir:~/..."] section, while git config does. os.path.expanduser returns the home directory with backslashes, so gitdir:~...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80fc5334-9e1f-9687-f0d9-43852b4dcf64
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id962C:16CED0:918E63:C259A2:6B00B6CB
html-safe-nonce9fd3a40a6599101bb93065ce49daa0fecf9ef67d03b9bff4772dde5e26e23237
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjJDOjE2Q0VEMDo5MThFNjM6QzI1OUEyOjZCMDBCNkNCIiwidmlzaXRvcl9pZCI6IjIzNjU1MzIyNDU5OTA2MTg4MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1ff60a48fa95fc584f8b0b8d1080618004f6d331cf80e26e7c0d1f7a83c0dfa
hovercard-subject-tagpull_request:4983081147
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2305/files
twitter:imagehttps://avatars.githubusercontent.com/u/6395743?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6395743?s=400&v=4
og:image:altOn Windows, GitConfigParser never applies an [includeIf "gitdir:~/..."] section, while git config does. os.path.expanduser returns the home directory with backslashes, so gitdir:~/work/ b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2305/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2305%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2305%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2305/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2305/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2305/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
b84330808https://github.com/b84330808
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
b84330808:fix/includeif-gitdir-home-windowshttps://github.com/b84330808/GitPython/tree/fix/includeif-gitdir-home-windows
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2305
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2305/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2305/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2305/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2305/files
fix(config): match ~/ gitdir includes on Windows https://github.com/gitpython-developers/GitPython/pull/2305/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2305/files
b83fcb8 fix(config): match `~/` gitdir includes on Windows b84330808 Oct 23, 2026 https://github.com/gitpython-developers/GitPython/pull/2305/commits/b83fcb8bbe44bfba7f78e5e68cb3be3571f165ce
Clear filters https://github.com/gitpython-developers/GitPython/pull/2305/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2305/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2305/files
config.py https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
test_config.py https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
git/config.pyhttps://github.com/gitpython-developers/GitPython/pull/2305/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
View file https://github.com/b84330808/GitPython/blob/b83fcb8bbe44bfba7f78e5e68cb3be3571f165ce/git/config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2305/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
test/test_config.pyhttps://github.com/gitpython-developers/GitPython/pull/2305/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
View file https://github.com/b84330808/GitPython/blob/b83fcb8bbe44bfba7f78e5e68cb3be3571f165ce/test/test_config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2305/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
https://github.com/gitpython-developers/GitPython/pull/2305/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2305/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.