René's URL Explorer Experiment


Title: fix(tag): split tag object headers at line feeds only by Keerthana-64 · Pull Request #2290 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(tag): split tag object headers at line feeds only by Keerthana-64 · Pull Request #2290 · gitpython-developers/GitPython

X Title: fix(tag): split tag object headers at line feeds only by Keerthana-64 · Pull Request #2290 · gitpython-developers/GitPython

Description: TagObject._set_cache_ split the decoded tag object with str.splitlines() and then read the headers by position, taking lines[3] as the tagger. str.splitlines() also breaks at \r, \v, \f, \x1c-\x1e, \x85, U+2028 and U+2029, but git ends a header only at a line feed. A U+2028 inside the tag header of an untrusted tag object therefore shifts every later header by one line in GitPython only. With tag v1tagger Linus Torvalds 1700000000 +0000 followed by a real tagger Mallory ... line, git cat-file tag, git show and git for-each-ref --format=%(taggername) report Mallory, while GitPython reported tag == "v1" and Linus Torvalds as the tagger. The object passes git fsck --strict and a clone with transfer.fsckObjects=true, because git only warns badTagName. The fix splits at "\n" and drops the trailing empty element, so tags that only use line feeds parse exactly as before. A \r or U+2028 inside the message is now kept, as git shows it. The new test in test/test_refs.py fails before the change and passes after it. ruff, ruff format --check and mypy are clean. On my machine the full suite has 3 failures (test_empty_repo, test_rebasing, test_diff_with_staged_file), and all 3 also fail without this change.

Open Graph Description: TagObject._set_cache_ split the decoded tag object with str.splitlines() and then read the headers by position, taking lines[3] as the tagger. str.splitlines() also breaks at \r, \v, \f, \x1c-\x1e,...

X Description: TagObject._set_cache_ split the decoded tag object with str.splitlines() and then read the headers by position, taking lines[3] as the tagger. str.splitlines() also breaks at \r, \v, \f, \x1c-\x1e,...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2290

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9c7fd7ae-3102-4f24-70e3-b8adb21ff2e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95FA:3D392F:990CFE:CB4D81:6B00B6CA
html-safe-noncee5349757a24c197eba9198dcf8d3fe8993428f1833b59221480eae7bcf931d61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUZBOjNEMzkyRjo5OTBDRkU6Q0I0RDgxOjZCMDBCNkNBIiwidmlzaXRvcl9pZCI6IjQ0NjMyMDA0NjY2OTk4NTk2NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0adcf05d97a0c54859ad0de0293f5c5d01dd54df473b84163081293225099f9c
hovercard-subject-tagpull_request:4890882075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2290/files
twitter:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
og:image:altTagObject._set_cache_ split the decoded tag object with str.splitlines() and then read the headers by position, taking lines[3] as the tagger. str.splitlines() also breaks at \r, \v, \f, \x1c-\x1e,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2290/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2290%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2290%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2290/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2290/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2290/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
Keerthana-64:tag-header-line-feedshttps://github.com/Keerthana-64/GitPython/tree/tag-header-line-feeds
Conversation 2 https://github.com/gitpython-developers/GitPython/pull/2290
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2290/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2290/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2290/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2290/files
fix(tag): split tag object headers at line feeds only https://github.com/gitpython-developers/GitPython/pull/2290/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2290/files
add9920 fix(tag): split tag object headers at line feeds only Keerthana-64 Oct 16, 2026 https://github.com/gitpython-developers/GitPython/pull/2290/commits/add9920ad62af88db369c6451a1dc9400eebb814
Clear filters https://github.com/gitpython-developers/GitPython/pull/2290/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2290/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2290/files
tag.py https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-2526bf3fc6f6f4689c5b99b122e3954143bbf5997e3b81a6e7a0a7409fb61ac1
test_refs.py https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
git/objects/tag.pyhttps://github.com/gitpython-developers/GitPython/pull/2290/files#diff-2526bf3fc6f6f4689c5b99b122e3954143bbf5997e3b81a6e7a0a7409fb61ac1
View file https://github.com/Keerthana-64/GitPython/blob/add9920ad62af88db369c6451a1dc9400eebb814/git/objects/tag.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2290/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-2526bf3fc6f6f4689c5b99b122e3954143bbf5997e3b81a6e7a0a7409fb61ac1
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-2526bf3fc6f6f4689c5b99b122e3954143bbf5997e3b81a6e7a0a7409fb61ac1
test/test_refs.pyhttps://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
View file https://github.com/Keerthana-64/GitPython/blob/add9920ad62af88db369c6451a1dc9400eebb814/test/test_refs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2290/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
https://github.com/gitpython-developers/GitPython/pull/2290/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2290/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.