René's URL Explorer Experiment


Title: fix(submodule): resolve relative submodule URLs the way git does by Keerthana-64 · Pull Request #2289 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(submodule): resolve relative submodule URLs the way git does by Keerthana-64 · Pull Request #2289 · gitpython-developers/GitPython

X Title: fix(submodule): resolve relative submodule URLs the way git does by Keerthana-64 · Pull Request #2289 · gitpython-developers/GitPython

Description: Submodule.update resolves a ./ or ../ submodule URL with urllib.parse.urljoin against the origin URL, and Submodule._clone_repo joins a ../ URL onto the tracking remote's URL with os.path.join. urljoin only resolves against the schemes it knows, so for an ssh:// or git:// superproject the relative URL comes back unchanged and git clone is handed ./planted, a path inside the superproject's checkout; with an scp-like host:path origin, ../../planted collapses to the bare path planted. For the same .gitmodules entry, git submodule init records ssh://host/org/super.git/planted: origin='ssh://git@git.example.com/org/super.git' git -> 'ssh://git@git.example.com/org/super.git/planted' origin='ssh://git@git.example.com/org/super.git' GitPython -> cloned from '/./planted' The superproject's author controls both .gitmodules and the tree, so a committed directory laid out as a bare repository becomes the submodule's source. That is git's local clone path: git upload-pack runs inside the attacker's directory, and the objects are copied without the transfer.fsckObjects checks a transport fetch applies (a commit that git clone file://... refuses as badDate is accepted). Relative URLs are common in multi-repository setups, and anything that updates submodules of repositories it is given treats the superproject as untrusted. resolve_relative_url in git/objects/submodule/util.py is a port of git's relative_url: each ../ strips one component of the remote URL, a path component first and then the scp-like host before the colon, running out of components is an error, ./ is dropped and the remainder appended. Checked against what git submodule init writes to submodule..url on git 2.54 for 272 remote and URL pairs (ssh://, host:path, https://, file://, //share, absolute and relative paths, trailing slashes, .sub, ..//sub), with no differences including the error cases. It replaces urljoin in Submodule.update, os.path.join in _clone_repo (which now also resolves ./, previously passed to git clone verbatim), and the raw relative URL that the URL change path of RootModule.update gave create_remote and set_url. The remote each site resolves against is unchanged. The two behavioral tests in test/test_submodule.py fail before the change with ./planted reaching the clone unchanged; test_submodule.py passes, and ruff, mypy and basedpyright --warnings report nothing new.

Open Graph Description: Submodule.update resolves a ./ or ../ submodule URL with urllib.parse.urljoin against the origin URL, and Submodule._clone_repo joins a ../ URL onto the tracking remote's URL with os.path.join....

X Description: Submodule.update resolves a ./ or ../ submodule URL with urllib.parse.urljoin against the origin URL, and Submodule._clone_repo joins a ../ URL onto the tracking remote's URL with os.path.j...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2289

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dadfdf7e-2efd-b5fb-8ddc-090d1d6923c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9620:3DF0BE:1206E3:17FEB3:6B00BBEB
html-safe-nonce9cc0b1042bb0483acd15a581a3e0c41962fc298078c75dc5f23c10ef89bc1d28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjIwOjNERjBCRToxMjA2RTM6MTdGRUIzOjZCMDBCQkVCIiwidmlzaXRvcl9pZCI6Ijk1NjY3NTI4OTQ4MjU3NDgyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc9495c22633c2db4ff0a3a2cf5cd0652b2b2c2643622cfe224f3da9d1f51ff14
hovercard-subject-tagpull_request:4885825974
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2289/files
twitter:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
og:image:altSubmodule.update resolves a ./ or ../ submodule URL with urllib.parse.urljoin against the origin URL, and Submodule._clone_repo joins a ../ URL onto the tracking remote's URL with os.path.join....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2289/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2289%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2289%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2289/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2289/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2289/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
Keerthana-64:submodule-relative-urlhttps://github.com/Keerthana-64/GitPython/tree/submodule-relative-url
Conversation 10 https://github.com/gitpython-developers/GitPython/pull/2289
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2289/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2289/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2289/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2289/files
fix(submodule): resolve relative submodule URLs the way git does https://github.com/gitpython-developers/GitPython/pull/2289/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2289/files
833c8d8 fix(submodule): resolve relative submodule URLs the way git does Keerthana-64 Oct 16, 2026 https://github.com/gitpython-developers/GitPython/pull/2289/commits/833c8d8d3e5347e95f782cf1cc0b9fab60569110
0a5938d review Byron Oct 16, 2026 https://github.com/gitpython-developers/GitPython/pull/2289/commits/0a5938dc55c569dbf5f5c60244106ef2011cefdb
Clear filters https://github.com/gitpython-developers/GitPython/pull/2289/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2289/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2289/files
base.py https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
root.py https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-7df742abf80356d1e22c392ee26cd2d87f89158b9f70bff6fb936eaf4c7e7faf
util.py https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
test_submodule.py https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-78179a32c1d54a6b78b018ee57328d6ea9424fbfbdbb36caf15e290331621024
git/objects/submodule/base.pyhttps://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
View file https://github.com/Keerthana-64/GitPython/blob/0a5938dc55c569dbf5f5c60244106ef2011cefdb/git/objects/submodule/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2289/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
git/objects/submodule/root.pyhttps://github.com/gitpython-developers/GitPython/pull/2289/files#diff-7df742abf80356d1e22c392ee26cd2d87f89158b9f70bff6fb936eaf4c7e7faf
View file https://github.com/Keerthana-64/GitPython/blob/0a5938dc55c569dbf5f5c60244106ef2011cefdb/git/objects/submodule/root.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2289/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-7df742abf80356d1e22c392ee26cd2d87f89158b9f70bff6fb936eaf4c7e7faf
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-7df742abf80356d1e22c392ee26cd2d87f89158b9f70bff6fb936eaf4c7e7faf
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-7df742abf80356d1e22c392ee26cd2d87f89158b9f70bff6fb936eaf4c7e7faf
git/objects/submodule/util.pyhttps://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
View file https://github.com/Keerthana-64/GitPython/blob/0a5938dc55c569dbf5f5c60244106ef2011cefdb/git/objects/submodule/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2289/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
https://github.com/gitpython-developers/GitPython/pull/2289/files#diff-367e208359050dc30b27c910ac04d326217fcedb92adc5242a2456aceb1d5b77
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2289/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2289/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.