Title: fix(util): wait for contended locks with relative filenames by FanWu-ai · Pull Request #2282 · gitpython-developers/GitPython · GitHub
Open Graph Title: fix(util): wait for contended locks with relative filenames by FanWu-ai · Pull Request #2282 · gitpython-developers/GitPython
X Title: fix(util): wait for contended locks with relative filenames by FanWu-ai · Pull Request #2282 · gitpython-developers/GitPython
Description: BlockingLockFile('resource') fails immediately when another holder owns the lock, reporting that its directory is missing. dirname('resource.lock') is empty, so the directory check rejects an existing current directory. Use the current directory when the lock path has no directory component. Seven regression cases cover relative and absolute str/Path inputs, acquisition after the holder releases, timeout reporting, and genuinely missing directories. Validation on Linux, CPython 3.12.14 and Git 2.52.0: Pristine full suite: 1,689 passed; new cases before the fix: 4 failed, 3 passed. Final full suite: 1,696 passed, 89 unchanged conditional skips, 1 existing xfail, 64 subtests passed; 92% coverage. All nine pinned hooks, mypy (46 files), basedpyright with warnings enabled, clean docs, wheel/sdist builds, strict Twine and whitespace checks pass. The skips cover platform/filesystem-specific cases; the existing xfail concerns shallow submodules. The existing environment-variable path deprecation warning remains. Native Windows, macOS and Cygwin have not been run locally. Follow-up CI compatibility repair (2026-10-12, commit 62fe322): The original hosted run exposed four test failures on Python 3.8–3.10 (including Cygwin 3.9): string-based mock lookup followed the legacy git.util alias to git.index.util instead of the intended module. Patch the already imported time module's sleep attribute directly. This is a one-line test-only change; the production fix and every assertion remain unchanged. Fresh pristine full suites on Linux, CPython 3.8.20/3.9.25/3.10.22/3.12.14: 1,689 passed per interpreter. Final full suites: 1,696 passed per interpreter, with the same 89 skips and one existing xfail; 64 subtests pass where reported (3.10/3.12). On 3.8/3.9/3.10, the corrected tests against the original production code still give 4 failed and 3 passed, preserving regression sensitivity. Final nine pinned hooks, mypy on 3.9/3.10/3.12, basedpyright with warnings enabled, clean documentation builds on 3.9/3.10/3.12, wheel/sdist builds, strict Twine and whitespace checks all pass. The latest five hosted workflows for this commit currently report action_required with no jobs started. Hosted CI is awaiting approval, not passing: Python package run. Earlier hosted results are not evidence that this new commit passed. This contribution was prepared by OpenAI Codex, an AI agent operating through FanWu-ai's account. No human review or approval is claimed.
Open Graph Description: BlockingLockFile('resource') fails immediately when another holder owns the lock, reporting that its directory is missing. dirname('resource.lock') is empty, so the directory check ...
X Description: BlockingLockFile('resource') fails immediately when another holder owns the lock, reporting that its directory is missing. dirname('resource.lock') is empty, so the ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2282
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:294ed3b8-740a-2584-4938-588a72bfc252 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF0C:31E99C:DC5C29:1278158:6B0103D6 |
| html-safe-nonce | c4354bb7788d90a371c28fccc6c3de699708e0f688af3a53ef35ced54ffd2843 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjBDOjMxRTk5QzpEQzVDMjk6MTI3ODE1ODo2QjAxMDNENiIsInZpc2l0b3JfaWQiOiIzODMyNDkzNDE0MTU5NTQ5Mzk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2afd86242143338759b9d8d5b1ccbf0db159385828858ac2d2917ce32bcc7624 |
| hovercard-subject-tag | pull_request:4821199429 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2282/files |
| twitter:image | https://avatars.githubusercontent.com/u/336798967?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336798967?s=400&v=4 |
| og:image:alt | BlockingLockFile('resource') fails immediately when another holder owns the lock, reporting that its directory is missing. dirname('resource.lock') is empty, so the directory check ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width