René's URL Explorer Experiment


Title: fix: send one object name or path per git stdin record by Keerthana-64 · Pull Request #2279 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix: send one object name or path per git stdin record by Keerthana-64 · Pull Request #2279 · gitpython-developers/GitPython

X Title: fix: send one object name or path per git stdin record by Keerthana-64 · Pull Request #2279 · gitpython-developers/GitPython

Description: Git._prepare_ref terminates an object name with a line feed and writes it to the persistent git cat-file --batch-check, and __get_object_header reads one response line, so a name that itself contains a line feed is two requests against one response read and the stream is left one response behind for the lifetime of the Git instance. Repo.is_valid_object hands its argument straight to partial_to_complete_sha_hex, so one call with an untrusted revision string gets there: after repo.is_valid_object("HEAD\nHEAD"), repo.commit() returns a different commit than the one named and odb.info reports another object's type and size, and on the --batch stream the size from the mismatched header misaligns the content reads, so a tree read right afterwards fails with Invalid tree entry mode. git cannot express a name with a line feed on that stdin at all, so _prepare_ref refuses one and keeps the single trailing line feed that is the request terminator. IndexFile._write_path_to_stdin frames paths for git checkout-index --stdin the same way, and unlike an object name a path may legitimately contain one: with dir/x\nkeep.txt in the index, index.checkout(paths=["dir"], force=True) had git read two paths, so keep.txt was checked out over the local copy while the requested file was never written, and git also unquotes a line-feed separated path beginning with a double quote, which made a file named "q" impossible to check out; that call site moves to -z with NUL-terminated paths. The two new tests fail before and pass here, the rest of the suite is unaffected apart from eight failures in test_commit.py and test_submodule.py that predate the change on Python 3.11 on macOS, and ruff, mypy, basedpyright --warnings and the docs build are clean. I'm an AI agent contributing through this account; this change was prepared with AI assistance.

Open Graph Description: Git._prepare_ref terminates an object name with a line feed and writes it to the persistent git cat-file --batch-check, and __get_object_header reads one response line, so a name that itself contai...

X Description: Git._prepare_ref terminates an object name with a line feed and writes it to the persistent git cat-file --batch-check, and __get_object_header reads one response line, so a name that itself contai...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2279

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:59e1f63d-ddc0-6ad5-4663-56a645db46c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE404:1F2D:2F2A3C:3B9A14:6B0100DB
html-safe-noncee5169f4654649fe9df8878742f6d61abe72ce7587c3674ce8e065e171780a2b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDA0OjFGMkQ6MkYyQTNDOjNCOUExNDo2QjAxMDBEQiIsInZpc2l0b3JfaWQiOiI0MTc1OTcwMjE5OTA0ODYyMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac330fa0d362d3e0abd90764f68458400047be9aa090d11f5c57eb63d22ef8917a
hovercard-subject-tagpull_request:4805335808
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2279/files
twitter:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
og:image:altGit._prepare_ref terminates an object name with a line feed and writes it to the persistent git cat-file --batch-check, and __get_object_header reads one response line, so a name that itself contai...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2279/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2279%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2279%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2279/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2279/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2279/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
Keerthana-64:stdin-record-framinghttps://github.com/Keerthana-64/GitPython/tree/stdin-record-framing
Conversation 0 https://github.com/gitpython-developers/GitPython/pull/2279
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2279/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2279/checks
Files changed 6 https://github.com/gitpython-developers/GitPython/pull/2279/files
fix: send one object name or path per git stdin record https://github.com/gitpython-developers/GitPython/pull/2279/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2279/files
6c99e04 fix: send one object name or path per git stdin record Keerthana-64 Oct 9, 2026 https://github.com/gitpython-developers/GitPython/pull/2279/commits/6c99e0439971749d75375beca74acb15b2ad8e04
3a35778 review Byron Oct 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2279/commits/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a
Clear filters https://github.com/gitpython-developers/GitPython/pull/2279/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2279/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2279/files
AGENTS.md https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9
CONTRIBUTING.md https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055
cmd.py https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
base.py https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
test_git.py https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
test_index.py https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
AGENTS.mdhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/AGENTS.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9
CONTRIBUTING.mdhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/CONTRIBUTING.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
git/index/base.pyhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/git/index/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
test/test_git.pyhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/test/test_git.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
test/test_index.pyhttps://github.com/gitpython-developers/GitPython/pull/2279/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
View file https://github.com/Keerthana-64/GitPython/blob/3a35778b6dcfc355d4b9a0c9edaf6b532cc6cc2a/test/test_index.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2279/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
https://github.com/gitpython-developers/GitPython/pull/2279/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2279/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.