René's URL Explorer Experiment


Title: fix: stop stalled remote commands when their timeout expires by Byron · Pull Request #2277 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix: stop stalled remote commands when their timeout expires by Byron · Pull Request #2277 · gitpython-developers/GitPython

X Title: fix: stop stalled remote commands when their timeout expires by Byron · Pull Request #2277 · gitpython-developers/GitPython

Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by Codex GPT-6. Created by Codex on behalf of Byron. Byron will review before this is ready to merge. Fixes #2276. Stalled fetch, pull, and push commands can deadlock when timeout cleanup closes stderr while its pump holds the buffered reader lock. Kill Git and its descendants before closing output streams, then reap the process. Reuse the command watchdog's process lookup, extending it to grandchildren (including Apple Git's HTTP helper launcher). Support both POSIX ps and Cygwin ps -ef when pgrep is unavailable. Both output streams share one deadline. Append timeout diagnostics to captured stderr for AutoInterrupt.wait() instead of synchronously re-entering callbacks, and preserve those errors in partial push results, including when Git exits successfully while a callback remains blocked. Skip process-tree signalling after the child exits. Ordinary cleanup keeps stdin EOF delivery, SIGTERM, and output closure before waiting, including buffered/broken input pipes. Update the public descendant limitations to match the implementation. The loopback regression covers all nine combinations of fetch/pull/push and git:///HTTP/HTTPS. All nine failed before the fix, returning only after the server's five-second safety release; all now pass with 0.5-second timeouts, including in Cygwin CI. Additional regressions cover buffered stdin, undrained output, blocked stdout/stderr callbacks, partial pushes, missing process lookup tools, and POSIX/Cygwin descendant parsing. Validation: All 50 CI checks pass on 30b741c, including Linux, macOS, Windows, Cygwin, Alpine, dependency compatibility, lint, types, tests, and documentation. Python 3.8 focused timeout and cleanup suite: 24 passed. Command, cleanup, and command-deprecation modules: 122 passed, 1 skipped before the final callback/parser additions; subsequent focused checks cover those changes. All nine loopback cases pass with pgrep disabled, exercising the POSIX ps fallback. Cygwin CI passed all nine stalled-remote cases and 1581 tests overall; its sole parser-fixture platform mismatch is corrected by explicitly selecting each modeled platform. Ruff lint/format, native and Windows-targeted mypy, basedpyright, and diff checks pass. Final Codex commit review found no actionable regressions. All six Copilot threads were addressed with regressions or documentation and resolved. Local TestRemote.test_base fails identically with the unchanged implementation due to a missing remote-tracking ref; this limitation was verified against the baseline. Git reference: local source baseline v2.56.0-rc1, especially transport-helper.c:get_helper() (inherited stderr), connect.c:git_connect() (SSH transport children), and run-command.c (descriptor handling and opt-in child cleanup). Runtime reproduction used Apple Git 2.54.0. Cygwin process format was checked against upstream winsup/utils/ps.cc. Process lookup is best-effort if tools are unavailable. Descendants that already detached or spawn after enumeration may escape signalling. Windows command timeouts remain unsupported.

Open Graph Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

X Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2277

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ac55b09-f2ba-41f4-d9c1-e3c340deaa4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB772:27E5CD:F84DA1:1405730:6B0100E7
html-safe-noncea2d6989b2ddb396e011ee89f97a454043760c981663ab9431e9c6948032c20ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzcyOjI3RTVDRDpGODREQTE6MTQwNTczMDo2QjAxMDBFNyIsInZpc2l0b3JfaWQiOiI2ODUzNTM3ODU2NDI2NjcyMzU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac067d2d9421e8377e67315e7b5b709bb0eb1553a683cd908a798466639da34ba1
hovercard-subject-tagpull_request:4770321272
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2277/files
twitter:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
og:image:altTasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2277/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2277%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2277%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2277/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2277/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2277/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
mainhttps://github.com/gitpython-developers/GitPython/tree/main
kill-all-properhttps://github.com/gitpython-developers/GitPython/tree/kill-all-proper
Conversation 22 https://github.com/gitpython-developers/GitPython/pull/2277
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2277/commits
Checks 50 https://github.com/gitpython-developers/GitPython/pull/2277/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2277/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
fix: stop stalled remote commands when their timeout expires https://github.com/gitpython-developers/GitPython/pull/2277/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2277/files
5ba236e fix: stop stalled remote commands when their timeout expires (#2276) Byron Oct 7, 2026 https://github.com/gitpython-developers/GitPython/pull/2277/commits/5ba236e9ce085f7fe467d0964682a4375210aa3e
Clear filters https://github.com/gitpython-developers/GitPython/pull/2277/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
cmd.py https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
remote.py https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
test_autointerrupt.py https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-82e6769889850c2928f622df04a88214a3644a0b3b6bb706eea34625e664901f
test_git.py https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
test_remote.py https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-8f71eea0871a97cc5c7757598e3ffaeacb8cd38f6f5f1742e21fd07364d3a698
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/gitpython-developers/GitPython/blob/5ba236e9ce085f7fe467d0964682a4375210aa3e/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2277/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
git/remote.pyhttps://github.com/gitpython-developers/GitPython/pull/2277/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
View file https://github.com/gitpython-developers/GitPython/blob/5ba236e9ce085f7fe467d0964682a4375210aa3e/git/remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2277/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
https://github.com/gitpython-developers/GitPython/pull/2277/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2277/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.