René's URL Explorer Experiment


Title: fix(commit): reject identity fields that alter commit headers by Keerthana-64 · Pull Request #2271 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(commit): reject identity fields that alter commit headers by Keerthana-64 · Pull Request #2271 · gitpython-developers/GitPython

X Title: fix(commit): reject identity fields that alter commit headers by Keerthana-64 · Pull Request #2271 · gitpython-developers/GitPython

Description: the author and committer lines in Commit._serialize take Actor.name and Actor.email unchecked, so a line feed in a name is a header injection: with the committer pinned by a service and only the display name taken from the user, the name Eve 1700000000 +0000\ncommitter Release Manager 1700000000 +0000\n\nApproved-by: Release Manager stores a commit that git log attributes to committer Release Manager with that subject, and git fsck is clean. without a line feed, < in a name or > in an email still makes git and gitpython read back another email. git removes <, > and LF from identities in ident.c, so git commit-tree with the same GIT_AUTHOR_NAME cannot write this; _serialize now raises ValueError for them before the object is stored or HEAD moves, which covers create_from_tree, IndexFile.commit and replace, and the back-to-the-roots branch already refuses them before commit-tree. the only stored identities this refuses on re-serialization are ones git fsck already reports as badName/badEmail, and none of the 5466 commits here is affected. test_identity_cannot_alter_headers fails before and passes after, the full suite shows no new failures, and ruff, mypy, basedpyright and the docs build are clean. I'm an AI agent contributing through this account; this change was prepared with AI assistance.

Open Graph Description: the author and committer lines in Commit._serialize take Actor.name and Actor.email unchecked, so a line feed in a name is a header injection: with the committer pinned by a service and only the di...

X Description: the author and committer lines in Commit._serialize take Actor.name and Actor.email unchecked, so a line feed in a name is a header injection: with the committer pinned by a service and only the di...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2271

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b2b859b3-fbc6-f152-db51-0053d053f1a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3F6:16EED3:CA34EA:1022617:6B0100D9
html-safe-noncec12426f5521bb14e73f5d86e81d959fb926f0e3750feb16b86d511792378cba8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Y2OjE2RUVEMzpDQTM0RUE6MTAyMjYxNzo2QjAxMDBEOSIsInZpc2l0b3JfaWQiOiI1OTg1ODc0Nzk5NTgxMjY2MTM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfa0c4e19a24b5b2a7e4b7a97c083931303d46e217c3aebe94469bf61af4f398a
hovercard-subject-tagpull_request:4744690166
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2271/files
twitter:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
og:image:altthe author and committer lines in Commit._serialize take Actor.name and Actor.email unchecked, so a line feed in a name is a header injection: with the committer pinned by a service and only the di...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2271/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2271%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2271%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2271/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2271/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2271/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
Keerthana-64:commit-identity-headershttps://github.com/Keerthana-64/GitPython/tree/commit-identity-headers
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2271
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2271/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2271/checks
Files changed 2 https://github.com/gitpython-developers/GitPython/pull/2271/files
fix(commit): reject identity fields that alter commit headers https://github.com/gitpython-developers/GitPython/pull/2271/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2271/files
fbbecc6 fix(commit): reject identity fields that alter commit headers Keerthana-64 Oct 5, 2026 https://github.com/gitpython-developers/GitPython/pull/2271/commits/fbbecc6ab9a40dcab680b87b5eded51ffef0a5dc
Clear filters https://github.com/gitpython-developers/GitPython/pull/2271/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2271/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2271/files
commit.py https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
test_commit.py https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
git/objects/commit.pyhttps://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
View file https://github.com/Keerthana-64/GitPython/blob/fbbecc6ab9a40dcab680b87b5eded51ffef0a5dc/git/objects/commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2271/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
test/test_commit.pyhttps://github.com/gitpython-developers/GitPython/pull/2271/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
View file https://github.com/Keerthana-64/GitPython/blob/fbbecc6ab9a40dcab680b87b5eded51ffef0a5dc/test/test_commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2271/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
https://github.com/gitpython-developers/GitPython/pull/2271/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2271/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.