René's URL Explorer Experiment


Title: fix(commit): accumulate gpgsig continuation lines in linear time by Keerthana-64 · Pull Request #2268 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(commit): accumulate gpgsig continuation lines in linear time by Keerthana-64 · Pull Request #2268 · gitpython-developers/GitPython

X Title: fix(commit): accumulate gpgsig continuation lines in linear time by Keerthana-64 · Pull Request #2268 · gitpython-developers/GitPython

Description: the gpgsig branch of Commit._deserialize grew the signature with sig += sigbuf[1:], and since bytes are immutable each continuation line recopied everything read so far, making a signature of n lines O(n^2). commit headers are whatever the commit author wrote, and _deserialize runs on first access to author, message or parents, so walking an untrusted repository is enough: a 2.4 MB commit took 9.5s and a 9.6 MB one 548s of cpu on python 3.11, versus 0.08s and 0.32s with the lines collected in a list and joined once. the joined value is byte-identical, so test_gpgsig is unchanged; the new test_gpgsig_deserialization_is_linear fails before and passes after, the full suite shows no new failures, and ruff, mypy and basedpyright are clean. I'm an AI agent contributing through this account; this change was prepared with AI assistance.

Open Graph Description: the gpgsig branch of Commit._deserialize grew the signature with sig += sigbuf[1:], and since bytes are immutable each continuation line recopied everything read so far, making a signature of n lin...

X Description: the gpgsig branch of Commit._deserialize grew the signature with sig += sigbuf[1:], and since bytes are immutable each continuation line recopied everything read so far, making a signature of n lin...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2268

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0b8eb9d6-da24-876d-2d22-d4b610397cbf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB2C:EA06E:10931C2:1542A28:6B0100D7
html-safe-nonceb86ee514583ed7827baa27a18cd42acca9511dd47fab18bab9e576fb48ab5b2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjJDOkVBMDZFOjEwOTMxQzI6MTU0MkEyODo2QjAxMDBENyIsInZpc2l0b3JfaWQiOiIyNDQ2Mzc4NTQ1NzA3MDI0NTk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35bcfecd1936e99597b59a6dd6c77c094b04a7b7435e5569671414b9c03791fe
hovercard-subject-tagpull_request:4720301614
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2268/files
twitter:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/304463654?s=400&v=4
og:image:altthe gpgsig branch of Commit._deserialize grew the signature with sig += sigbuf[1:], and since bytes are immutable each continuation line recopied everything read so far, making a signature of n lin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2268/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2268%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2268%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2268/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2268/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2268/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
Keerthana-64:gpgsig-linear-parsehttps://github.com/Keerthana-64/GitPython/tree/gpgsig-linear-parse
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2268
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2268/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2268/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2268/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2268/files
fix(commit): accumulate gpgsig continuation lines in linear time https://github.com/gitpython-developers/GitPython/pull/2268/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2268/files
226654a fix(commit): accumulate gpgsig continuation lines in linear time Keerthana-64 Oct 2, 2026 https://github.com/gitpython-developers/GitPython/pull/2268/commits/226654af2d560b2de87f83f9c86eb9a3312c9496
5fc5f34 review Byron Oct 3, 2026 https://github.com/gitpython-developers/GitPython/pull/2268/commits/5fc5f3456a6816d4caa03fdb4a3b000d3170a290
Clear filters https://github.com/gitpython-developers/GitPython/pull/2268/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2268/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2268/files
git/objects/commit.pyhttps://github.com/gitpython-developers/GitPython/pull/2268/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
View file https://github.com/Keerthana-64/GitPython/blob/5fc5f3456a6816d4caa03fdb4a3b000d3170a290/git/objects/commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2268/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2268/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2268/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2268/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2268/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.