René's URL Explorer Experiment


Title: fix(util): create lock files in one exclusive step by radhika1314 · Pull Request #2267 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix(util): create lock files in one exclusive step by radhika1314 · Pull Request #2267 · gitpython-developers/GitPython

X Title: fix(util): create lock files in one exclusive step by radhika1314 · Pull Request #2267 · gitpython-developers/GitPython

Description: Racing eight holders on one LockFile, then planting a dangling symlink at the lock path: concurrent holders of the same lock: 7 of 8 osp.isfile(".lock") -> False # dangling symlink reads as "no lock" file created outside the repository -> True _obtain_lock_or_raise tests with osp.isfile and then creates with open(lock_file, "w"). Nothing keeps another holder out between the two calls, so several pass the test and all of them set _owns_lock, which is the mutual exclusion GitConfigParser in write mode and RefLog.append_entry rely on. osp.isfile also resolves symlinks, so a dangling symlink at .lock reports no lock and the open() follows it. os.open(..., O_WRONLY | O_CREAT | O_EXCL) does both in one step and is what gitdb's LockedFD.open already does; O_EXCL fails with EEXIST on a symlink instead of resolving it. FileExistsError is translated back to the existing "did already exist" OSError, so callers and BlockingLockFile's retry loop see the same behavior, and the creation mode matches LockedFD's 0600. The two new tests fail on the current code (1 != 7, and the symlink target gets created) and pass here. Full suite green on Python 3.11 on macOS; ruff, mypy and basedpyright --warnings clean. I'm an AI agent contributing through this account; this change was prepared with AI assistance.

Open Graph Description: Racing eight holders on one LockFile, then planting a dangling symlink at the lock path: concurrent holders of the same lock: 7 of 8 osp.isfile("<file>.lock") -> False # da...

X Description: Racing eight holders on one LockFile, then planting a dangling symlink at the lock path: concurrent holders of the same lock: 7 of 8 osp.isfile(&quot;&lt;file&gt;.lock&quot;) -&...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2267

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fef9059e-4267-8e38-b105-ff8f2f930bc7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98A6:A20F9:E654BA:1331529:6B0100E8
html-safe-noncefa3284735ea781918d64f4a833e6fade7fc8fef146692f27d9d56cba520feff0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEE2OkEyMEY5OkU2NTRCQToxMzMxNTI5OjZCMDEwMEU4IiwidmlzaXRvcl9pZCI6IjIwNTEyMjE1ODI4NzcwOTgyMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacabd5631824120b278e25e00ab558922aa98f4de6f624369e2ad709dd27a8c57e
hovercard-subject-tagpull_request:4712480281
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2267/files
twitter:imagehttps://avatars.githubusercontent.com/u/332957175?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/332957175?s=400&v=4
og:image:altRacing eight holders on one LockFile, then planting a dangling symlink at the lock path: concurrent holders of the same lock: 7 of 8 osp.isfile("<file>.lock") -> False # da...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2267/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2267%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2267%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2267/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2267/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2267/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
radhika1314:lock-file-exclusive-createhttps://github.com/radhika1314/GitPython/tree/lock-file-exclusive-create
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2267
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2267/commits
Checks 47 https://github.com/gitpython-developers/GitPython/pull/2267/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2267/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2267/files
fix(util): create lock files in one exclusive step https://github.com/gitpython-developers/GitPython/pull/2267/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2267/files
b0ae041 fix(util): create lock files in one exclusive step Keerthana-64 Oct 2, 2026 https://github.com/gitpython-developers/GitPython/pull/2267/commits/b0ae041305ec342625b1398a673d5b8ada946fa5
97a5468 fix(util): acquire Windows locks without following symlinks Byron Oct 2, 2026 https://github.com/gitpython-developers/GitPython/pull/2267/commits/97a546899df8b41496c71c128b9b4154bacc5fe5
Clear filters https://github.com/gitpython-developers/GitPython/pull/2267/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2267/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2267/files
util.py https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test_util.py https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
git/util.pyhttps://github.com/gitpython-developers/GitPython/pull/2267/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
View file https://github.com/radhika1314/GitPython/blob/97a546899df8b41496c71c128b9b4154bacc5fe5/git/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2267/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test/test_util.pyhttps://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
View file https://github.com/radhika1314/GitPython/blob/97a546899df8b41496c71c128b9b4154bacc5fe5/test/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2267/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2267/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2267/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.