René's URL Explorer Experiment


Title: fix: validate object types when loading binary SHAs by Byron · Pull Request #2256 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix: validate object types when loading binary SHAs by Byron · Pull Request #2256 · gitpython-developers/GitPython

X Title: fix: validate object types when loading binary SHAs by Byron · Pull Request #2256 · gitpython-developers/GitPython

Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by Codex GPT-6. Created by Codex on behalf of Byron. Byron will review before this is ready to merge. Fixes #2254. Commit(repo, tag.binsha).tree now raises a ValueError identifying the SHA, its actual type, and the expected type before parsing tag data as a commit. The shared check also covers trees, tags, blobs, object size/streams, and raw tree traversal. Validation happens on first data access, preserving lazy constructors and placeholder objects. Rejected streams are drained so subsequent git cat-file reads remain usable even while an exception retains its traceback. The related audit found two more cases: IndexFile.new() converted binary SHAs to their Python string representation, and submodule diffs wrapped commit SHAs in Blob objects. Index creation now accepts binary SHAs and hexadecimal bytes alongside strings and trees; submodule diffs use IndexObject entries while retaining access to the submodule's commit data. Existing object, index, and submodule diff tests were extended in place, including mixed binary/hex/tree arguments. No new test functions were added. Validation: 227 affected tests passed, with 2 skips, across the suite run and the staged-file test's rerun with init.defaultBranch=master. Commit signing was disabled only for test commands. The extended object and index tests failed before the fix. The issue reproduction and valid binary-SHA operations were also checked with both GitCmdObjectDB and GitDB. Ruff lint/format checks, mypy (46 source files), and basedpyright passed. The now-obsolete index assignment diagnostic was removed from the type-checking baseline. Codex review of ca55dbf found no actionable regressions. Git behavior reference: d38352cd43ab9745686d697872408bc3249a153f in the local Git checkout; the commit, tree, and tag readers check object types before parsing their contents.

Open Graph Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

X Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2256

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:beee3512-558b-0d9b-c6de-8cf0f51c609f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89CE:3D97C8:D67B65:11F1561:6B0100C8
html-safe-noncec07678032246239ff8950f63bad0f6fc8189024a206277a45343040a42765dd2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUNFOjNEOTdDODpENjdCNjU6MTFGMTU2MTo2QjAxMDBDOCIsInZpc2l0b3JfaWQiOiI3Mzg2NzgxMjk5MTc4MDEyODcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccf7153bf30cfd5ae6d2b723f7af5cdc3af161df035c76c0ff2bc958c1712812b
hovercard-subject-tagpull_request:4659299015
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2256/files
twitter:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
og:image:altTasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2256/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2256%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2256%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2256/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2256/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2256/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
mainhttps://github.com/gitpython-developers/GitPython/tree/main
better-binsha-checkshttps://github.com/gitpython-developers/GitPython/tree/better-binsha-checks
Conversation 19 https://github.com/gitpython-developers/GitPython/pull/2256
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2256/commits
Checks 50 https://github.com/gitpython-developers/GitPython/pull/2256/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2256/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
fix: validate object types when loading binary SHAs https://github.com/gitpython-developers/GitPython/pull/2256/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2256/files
6bf77c0 fix: validate size lookups and preserve binary SHAs (#2254) Byron Sep 28, 2026 https://github.com/gitpython-developers/GitPython/pull/2256/commits/6bf77c0576937e35d8c40286d27dd86f12f5a3d1
Clear filters https://github.com/gitpython-developers/GitPython/pull/2256/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
baseline.json https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-f191a46264777bc8ac70e6675612561df1fd5e3d9d2e0b8c84fc5cababcd8b22
diff.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
base.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
base.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
test_base.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
test_diff.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
test_index.py https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
.basedpyright/baseline.jsonhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-f191a46264777bc8ac70e6675612561df1fd5e3d9d2e0b8c84fc5cababcd8b22
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/.basedpyright/baseline.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-f191a46264777bc8ac70e6675612561df1fd5e3d9d2e0b8c84fc5cababcd8b22
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-f191a46264777bc8ac70e6675612561df1fd5e3d9d2e0b8c84fc5cababcd8b22
git/diff.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/git/diff.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-300633890a1b325dfed86bb5120d89465f0687f4f6b8d5701c44c02f0eee723a
git/index/base.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/git/index/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-56d167dc0ca4d51682e56b5e602c096f3f264fd1ebb61cc03bbb6c409c866eeb
git/objects/base.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/git/objects/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-4fcf911ecd03484eb6c89186dde3ebaa272e9925d4c0da8a5dd358770aa9d21e
test/test_base.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/test/test_base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-1a293b58d544ac5f9d384afd0652dc7e9e17ae7564df252dd5a8fc39543ee0e6
test/test_diff.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/test/test_diff.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-a4c794e0849bb401148549f5efcaa756477ae6f7c2976d2ebf7cb56ff7850139
test/test_index.pyhttps://github.com/gitpython-developers/GitPython/pull/2256/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
View file https://github.com/gitpython-developers/GitPython/blob/6bf77c0576937e35d8c40286d27dd86f12f5a3d1/test/test_index.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2256/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
https://github.com/gitpython-developers/GitPython/pull/2256/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2256/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.