René's URL Explorer Experiment


Title: fix: strip inline config comments the way git does by rawsun007 · Pull Request #2245 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix: strip inline config comments the way git does by rawsun007 · Pull Request #2245 · gitpython-developers/GitPython

X Title: fix: strip inline config comments the way git does by rawsun007 · Pull Request #2245 · gitpython-developers/GitPython

Description: Written by Claude Opus 5 in Claude Code, running through @rawsun007's account, per CONTRIBUTING "Prevent agent impersonation". I speak only for myself here. In git, a # or ; outside quotes starts a comment — with or without a space before it, and whether or not the value is quoted. GitConfigParser cut only a ; that was preceded by whitespace in a value that did not start with ": if vi in ("=", ":") and ";" in optval and not optval.strip().startswith('"'): pos = optval.find(";") if pos != -1 and optval[pos - 1].isspace(): optval = optval[:pos] Measured against git config -f --get a.k on git 2.50.1: [a]\n\tk = … git before after value # comment value value # comment value value ; comment value value value value#nospace value value#nospace value value;nospace value value;nospace value a # b ; c a a # b a "quoted" # after quoted quoted" # after quoted The last row is the worst of them: because the value starts with " and does not end with one, the comment made it look like an unterminated quote, so it was read as the start of a multi-line value and the following lines were swallowed into it. The fix is small because the correct scan is already in this file: is_line_continuation walks a value tracking quotes and backslash escapes. strip_inline_comment reuses that walk to cut the comment before the quote-structure branches, so all three branches see comment-free text, and the legacy ;-only block is gone. A comment character inside quotes stays literal ("has # inside" → has # inside), and both are pinned. Escape handling is deliberately untouched. My first attempt also routed every unquoted value through parse_value, which resolves \t, \n and friends — that broke every Windows job, because a temp path like C:\Temp\test_x\config2 came back with a tab in it. git rejects that line outright (fatal: bad config line 2), so unescaping it would have matched neither git nor the previous behaviour. Whether GitPython should follow git and reject invalid escapes in unquoted values is a separate question; this PR does not touch it. Verification: test/test_config.py is 46 passed, 2 skipped, 14 subtests. Reverting only git/config.py fails 5 of the 8 new subtests, leaving the two quoted-literal cases and the already-working value ; comment green. The full test/ run is 231 passed / 6 failed / 663 errors both with and without this change — those are a fixture-setup problem in my checkout, identical on a clean tree, and none are in test_config.py. Not touched: [a] k = inline, a key on the same line as the section header, which git accepts and this parser rejects with NoOptionError. That is section-header parsing rather than comment handling, so it looked like its own change — happy to send it separately if you want it.

Open Graph Description: Written by Claude Opus 5 in Claude Code, running through @rawsun007's account, per CONTRIBUTING "Prevent agent impersonation". I speak only for myself here. In git, a # or ; outside ...

X Description: Written by Claude Opus 5 in Claude Code, running through @rawsun007's account, per CONTRIBUTING "Prevent agent impersonation". I speak only for myself here. In git, a # o...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2245

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ef1dc078-194d-b153-f452-6ad73d136000
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5DA:2AAD2E:D0D464:117DB8F:6B0100D0
html-safe-nonce9686afac1180512afec37bd862af48f4b22dbdd29670352f7033c7222819096d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNURBOjJBQUQyRTpEMEQ0NjQ6MTE3REI4Rjo2QjAxMDBEMCIsInZpc2l0b3JfaWQiOiI4ODA3MjIwNTkyNzc3NDI5MjAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9562837815953131880304cf1bee6a79ced5798179ba30c616d7a2878cdc7b1b
hovercard-subject-tagpull_request:4556658953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2245/files
twitter:imagehttps://avatars.githubusercontent.com/u/154859727?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/154859727?s=400&v=4
og:image:altWritten by Claude Opus 5 in Claude Code, running through @rawsun007's account, per CONTRIBUTING "Prevent agent impersonation". I speak only for myself here. In git, a # or ; outside ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2245/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2245%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2245%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2245/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2245/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2245/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
rawsun007:inline-comment-strippinghttps://github.com/rawsun007/GitPython/tree/inline-comment-stripping
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2245
Commits 2 https://github.com/gitpython-developers/GitPython/pull/2245/commits
Checks 51 https://github.com/gitpython-developers/GitPython/pull/2245/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2245/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2245/files
fix: strip inline config comments the way git does https://github.com/gitpython-developers/GitPython/pull/2245/files#top
Show all changes 2 commits https://github.com/gitpython-developers/GitPython/pull/2245/files
452878f fix: strip inline config comments the way git does rawsun007 Sep 17, 2026 https://github.com/gitpython-developers/GitPython/pull/2245/commits/452878f9ef8cc96c672cc2b5f491e3ac914764f4
258a884 review Byron Sep 20, 2026 https://github.com/gitpython-developers/GitPython/pull/2245/commits/258a884713302356358b5ad9f89dcd9b365b6b92
Clear filters https://github.com/gitpython-developers/GitPython/pull/2245/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2245/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2245/files
config.py https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
test_config.py https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
git/config.pyhttps://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
View file https://github.com/rawsun007/GitPython/blob/258a884713302356358b5ad9f89dcd9b365b6b92/git/config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2245/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-dd51b67c435dfba6f72cc0d08f99456393556623a0f098ac2808d1a7cb78d53a
test/test_config.pyhttps://github.com/gitpython-developers/GitPython/pull/2245/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
View file https://github.com/rawsun007/GitPython/blob/258a884713302356358b5ad9f89dcd9b365b6b92/test/test_config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2245/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
https://github.com/gitpython-developers/GitPython/pull/2245/files#diff-45fa5f8530eb815c0cf606032e587adedb04dc70e59b203535d51c44654cfc4d
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2245/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.