René's URL Explorer Experiment


Title: Reject submodule move destinations through intermediate symlinks by Byron · Pull Request #2232 · gitpython-developers/GitPython · GitHub

Open Graph Title: Reject submodule move destinations through intermediate symlinks by Byron · Pull Request #2232 · gitpython-developers/GitPython

X Title: Reject submodule move destinations through intermediate symlinks by Byron · Pull Request #2232 · gitpython-developers/GitPython

Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by Codex GPT-6. Created by Codex on behalf of Byron. Byron will review before this is ready to merge. Submodule moves now validate intermediate destination components before changing the checkout, index, or configuration. The check shares the existing checkout-path validation and preserves ordinary moves, no-op moves, and final-component symlink behavior. Advisory summary GHSA-gq48-pqfc-9p58: medium severity; GitPython (pip), reported affected version = 3.1.62. No patched version or CVE is currently assigned. Reproducer details are omitted from this description. Validation Regression reproduced before the fix; all 30 new parameterized cases pass. Complete submodule suite: 75 passed, 3 skipped, 1 expected failure, with commit signing disabled only for the test process. Ruff lint/format, mypy (45 source files), and git diff --check pass. Codex reviewed commits 5a1b6f38 and d7efa37d once each after creation and found no actionable regressions. Git reference: 1630431f326e15fcde608827b5ff38422528eb59, builtin/mv.c and t/t7001-mv.sh, which reject intermediate symlinks without changing the index. This check addresses existing symlinks; concurrent directory replacement remains outside its scope. Windows CI exposed open clone handles in the normal-move test fixture. Follow-up d7efa37d closes the fixture module repository before yielding it, using the existing Windows cleanup in Repo.close(). All 30 focused cases pass locally after this test-only adjustment.

Open Graph Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

X Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2232

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d80c40b6-c46f-25ed-b2d4-23e5bc4366f4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECC6:2652DC:10031A7:1496EC5:6B0100E8
html-safe-noncef400da0ad8b1811ae00db875bdfd7fd764abce012f635a7c24e0ad500edaae34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0M2OjI2NTJEQzoxMDAzMUE3OjE0OTZFQzU6NkIwMTAwRTgiLCJ2aXNpdG9yX2lkIjoiMTg4MTM1ODc3ODgyNjI5MzQ4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5b39e49c81a5fdc5606fca45cf071a1f6e4577eeeebeb5c0a443e3ac48a8cb6b
hovercard-subject-tagpull_request:4491464176
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2232/files
twitter:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
og:image:altTasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2232/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2232%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2232%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2232/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2232/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2232/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
mainhttps://github.com/gitpython-developers/GitPython/tree/main
fix-submodule-movehttps://github.com/gitpython-developers/GitPython/tree/fix-submodule-move
Conversation 24 https://github.com/gitpython-developers/GitPython/pull/2232
Commits 7 https://github.com/gitpython-developers/GitPython/pull/2232/commits
Checks 53 https://github.com/gitpython-developers/GitPython/pull/2232/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2232/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
Reject submodule move destinations through intermediate symlinks https://github.com/gitpython-developers/GitPython/pull/2232/files#top
Show all changes 7 commits https://github.com/gitpython-developers/GitPython/pull/2232/files
24b6f95 fix: Reject submodule move destinations through intermediate symlinks Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/24b6f95d4b90ab1483fb601c736ac6e7c059cd61
43a43cd fix: Validate submodule checkout and metadata paths before mutation Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/43a43cd800200f75ae84957f37b0e8b27c52f403
2bfd829 fix: Preserve submodule paths and release checkout handles on Windows Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/2bfd829f37f4bb810e3c4b409baeeb2be34544b8
415c211 test: Simplify submodule path simulation and verify metadata removal Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/415c211705882fadae6be0a299d86e1e4a3c5b03
958002b test: Disable automatic maintenance in remote timeout tests Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/958002b4cc06647407d39eb78c65d9dc68d1bee9
e9e271b fix: Clone into dangling submodule metadata symlink targets on Windows Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/e9e271bdc0982c262cd47ca4858533eb8c60e8bd
2aca177 test: Pass strings to readlink for Windows Python 3.7 Byron Sep 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2232/commits/2aca1778cd8b884b8dd39c638e366072e99425ee
Clear filters https://github.com/gitpython-developers/GitPython/pull/2232/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
changes.rst https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-18450dccedaf66680c6bfbfa443564198c3d480f939edb0e87f7d8078d0c2673
base.py https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
test_remote.py https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-8f71eea0871a97cc5c7757598e3ffaeacb8cd38f6f5f1742e21fd07364d3a698
test_submodule.py https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-78179a32c1d54a6b78b018ee57328d6ea9424fbfbdbb36caf15e290331621024
doc/source/changes.rsthttps://github.com/gitpython-developers/GitPython/pull/2232/files#diff-18450dccedaf66680c6bfbfa443564198c3d480f939edb0e87f7d8078d0c2673
View file https://github.com/gitpython-developers/GitPython/blob/2aca1778cd8b884b8dd39c638e366072e99425ee/doc/source/changes.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2232/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-18450dccedaf66680c6bfbfa443564198c3d480f939edb0e87f7d8078d0c2673
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-18450dccedaf66680c6bfbfa443564198c3d480f939edb0e87f7d8078d0c2673
git/objects/submodule/base.pyhttps://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
View file https://github.com/gitpython-developers/GitPython/blob/2aca1778cd8b884b8dd39c638e366072e99425ee/git/objects/submodule/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2232/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-44dc32942e129beb7f738ff7d487bfbddb0a7802a91d43c9b8b8952a4d0806bc
test/test_remote.pyhttps://github.com/gitpython-developers/GitPython/pull/2232/files#diff-8f71eea0871a97cc5c7757598e3ffaeacb8cd38f6f5f1742e21fd07364d3a698
View file https://github.com/gitpython-developers/GitPython/blob/2aca1778cd8b884b8dd39c638e366072e99425ee/test/test_remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2232/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2232/files#diff-8f71eea0871a97cc5c7757598e3ffaeacb8cd38f6f5f1742e21fd07364d3a698
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2232/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.