René's URL Explorer Experiment


Title: index: write blobs via git hash-object, not gitdb's odb.store by caroescm · Pull Request #2209 · gitpython-developers/GitPython · GitHub

Open Graph Title: index: write blobs via git hash-object, not gitdb's odb.store by caroescm · Pull Request #2209 · gitpython-developers/GitPython

X Title: index: write blobs via git hash-object, not gitdb's odb.store by caroescm · Pull Request #2209 · gitpython-developers/GitPython

Description: Problem repo.index.add() is GitPython's own way of adding files, separate from just running git add. To do that, it writes the file's content into .git/objects itself using Python, instead of asking git to do it. As part of that, it also tries to change the new file's permissions (chmod) — and in some setups, that permission change isn't allowed, even though writing the file itself worked fine. So index.add() can crash with PermissionError in situations where plain git add (and repo.git.add(...), which just runs git add directly) work without any problem, on the same file. There's also a smaller side effect: because GitPython reads the file itself instead of asking git, it skips any .gitattributes rules (like converting line endings), so the content it stores can end up slightly different from what git add would store. What I changed I changed index.add() to use the real git hash-object -w command to write the file into the object database, instead of doing it in Python. This means: No more Python-side chmod, so the crash goes away. The stored content now matches what git add would store, filters included. Symlinks needed a small extra step: git hash-object normally follows a symlink and hashes the file it points to, but Git is supposed to store the symlink's target path itself, not the pointed-to file. So for symlinks, I write the target path to a temporary file and hash that instead. Fixes #2021 Testing Ran the existing test suite (test_index.py, test_base.py, test_repo.py) — all still pass. Compared index.add()'s output to real git add for a normal file, a symlink, and a file in a subfolder — identical results. Recreated the original bug by blocking chmod only on .git/objects files (same as the error in #2021) — index.add() now works instead of crashing.

Open Graph Description: Problem repo.index.add() is GitPython's own way of adding files, separate from just running git add. To do that, it writes the file's content into .git/objects itself using Python, instead ...

X Description: Problem repo.index.add() is GitPython's own way of adding files, separate from just running git add. To do that, it writes the file's content into .git/objects itself using Python, ...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cc0e97da-bd44-c391-18a2-6c862d691c02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECB6:16EED3:CA57E3:1025285:6B0100E5
html-safe-noncea67f15348266baeaa7bb094cb47365d9b6cbfbd4101c1f13d96ca56d181d3c7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I2OjE2RUVEMzpDQTU3RTM6MTAyNTI4NTo2QjAxMDBFNSIsInZpc2l0b3JfaWQiOiI4MDk0NjQyMDUzMzAxOTkzNzAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccdca26bcd0e83f96474342663de56ecc89b7b879bfde6f04f89ff07317297204
hovercard-subject-tagpull_request:4241789966
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2209/files
twitter:imagehttps://avatars.githubusercontent.com/u/274076767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/274076767?s=400&v=4
og:image:altProblem repo.index.add() is GitPython's own way of adding files, separate from just running git add. To do that, it writes the file's content into .git/objects itself using Python, instead ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2209/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2209/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2209/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
caroescm:fix-index-add-chmodhttps://github.com/caroescm/GitPython/tree/fix-index-add-chmod
Conversation 1 https://github.com/gitpython-developers/GitPython/pull/2209
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2209/commits
Checks 53 https://github.com/gitpython-developers/GitPython/pull/2209/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2209/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2209/files
index: write blobs via git hash-object, not gitdb's odb.store https://github.com/gitpython-developers/GitPython/pull/2209/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2209/files
93677a0 fix: `index.add()` now supports filters (#2021) Byron Aug 10, 2026 https://github.com/gitpython-developers/GitPython/pull/2209/commits/93677a00ab9dcb06cc08595fd1f88a4b4a0fa23b
Clear filters https://github.com/gitpython-developers/GitPython/pull/2209/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2209/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2209/files
db.py https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
test_db.py https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-98e1a3bf9da516572de393e53b0fa04b60042708bca70f034eded93043ace822
test_refs.py https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
git/db.pyhttps://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
View file https://github.com/caroescm/GitPython/blob/93677a00ab9dcb06cc08595fd1f88a4b4a0fa23b/git/db.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2209/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-2c464f9c2a67eaec11758bfe4d275393bd7478c9315028ee3f158cf8587e5fb2
test/test_db.pyhttps://github.com/gitpython-developers/GitPython/pull/2209/files#diff-98e1a3bf9da516572de393e53b0fa04b60042708bca70f034eded93043ace822
View file https://github.com/caroescm/GitPython/blob/93677a00ab9dcb06cc08595fd1f88a4b4a0fa23b/test/test_db.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2209/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-98e1a3bf9da516572de393e53b0fa04b60042708bca70f034eded93043ace822
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-98e1a3bf9da516572de393e53b0fa04b60042708bca70f034eded93043ace822
test/test_refs.pyhttps://github.com/gitpython-developers/GitPython/pull/2209/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
View file https://github.com/caroescm/GitPython/blob/93677a00ab9dcb06cc08595fd1f88a4b4a0fa23b/test/test_refs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2209/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
https://github.com/gitpython-developers/GitPython/pull/2209/files#diff-0d8f1dff061a372fdf4946776e8277a271774b10c1684d1c28c1abd030340d0c
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2209/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.