René's URL Explorer Experiment


Title: Correct Windows hook Bash precedence by Byron · Pull Request #2201 · gitpython-developers/GitPython · GitHub

Open Graph Title: Correct Windows hook Bash precedence by Byron · Pull Request #2201 · gitpython-developers/GitPython

X Title: Correct Windows hook Bash precedence by Byron · Pull Request #2201 · gitpython-developers/GitPython

Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by Codex GPT-5. Created by Codex on behalf of Byron. Byron will review before this is ready to merge. Summary Follow-up to #2199 and its post-merge review of the Windows hook Bash resolver. Refs #2198. The merged resolver still selected the WSL launcher when System32 preceded Git Bash on PATH, and it could not locate Git Bash in the common configuration where PATH contains only Git\cmd. It also skipped an explicitly configured current-directory PATH entry and mocked the resolver in its regression test. This change first locates the Bash associated with GitPython's selected Git executable. It recognizes standard Git\cmd\git.exe, Git\bin\git.exe, and Git\\bin\git.exe layouts, then follows gix-path's bin/bash.exe before usr/bin/bash.exe precedence. The PATH fallback excludes candidates below SystemRoot, ignores empty entries according to Windows semantics, and still honors explicitly named directories. The existing bare fallback is retained for nonstandard installations and remains protected from implicit current-directory lookup by safer_popen. Windows and WSL validation This machine has Ubuntu on WSL 2, C:\Windows\System32\bash.exe, and Git for Windows. Bare bash.exe reported Linux ... microsoft-standard-WSL2. git var GIT_SHELL_PATH returned C:/Program Files/Git/usr/bin/sh.exe, which reported MINGW64. Under System32;Git\usr\bin, the #2199 resolver selected System32 and an actual GitPython hook wrote a Linux/WSL marker. Under the normal System32;Git\cmd PATH, Bash was absent from PATH, but the corrected resolver selected C:\Program Files\Git\bin\bash.exe; the same end-to-end hook wrote a MINGW64 marker. Tests Regression models System32 before Git\cmd, with Bash absent from PATH, and exercises the real resolver. Explicit current-directory PATH entry is accepted while empty entries are ignored. Explicit Git\bin\git.exe configuration resolves its sibling Bash, including a relative configured path resolved from the parent process working directory. The relative-path test enters its temporary root before constructing the path, because Windows cannot express a relative path across the separate checkout and temporary drives used by CI. Focused hook suite: 6 passed. Full test/test_index.py: 32 passed, 1 expected xfail, 1 existing xpass. Repository-wide Ruff lint and format checks passed using the Python 3.7 target. git diff --check passed. A standalone Python 3.7 interpreter was unavailable for an additional py_compile run. codex review --commit b5ae6d8ee6efee580aa21680786775977131bfde could not inspect the local commit because its Windows sandbox helper was unavailable and fell back to the stale pre-fix PR patch. Its three findings described behavior already corrected in this commit and were verified as false positives against the current source and tests.

Open Graph Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

X Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2201

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:987113bd-4846-966b-2a9c-0032cf2ed0b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA30:2454CC:C809C6:FF26C6:6B0100C0
html-safe-noncebd242f6b35fc3dee1c1d6ecf79df8aaa44306993cc8e069a9c786e89e8cf848b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTMwOjI0NTRDQzpDODA5QzY6RkYyNkM2OjZCMDEwMEMwIiwidmlzaXRvcl9pZCI6IjQ0Nzk0MjE0MjQzMDU1MDQ0NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5b9779ee444550886a1fe98cfd2ced28ea9c02f47e48c41315d6a1e9af0061d6
hovercard-subject-tagpull_request:4172587487
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2201/files
twitter:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
og:image:altTasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2201/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2201%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2201%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2201/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2201/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2201/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
mainhttps://github.com/gitpython-developers/GitPython/tree/main
fixup-bash-exe-lookup-on-windowshttps://github.com/gitpython-developers/GitPython/tree/fixup-bash-exe-lookup-on-windows
Conversation 6 https://github.com/gitpython-developers/GitPython/pull/2201
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2201/commits
Checks 53 https://github.com/gitpython-developers/GitPython/pull/2201/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2201/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2201/files
Correct Windows hook Bash precedence https://github.com/gitpython-developers/GitPython/pull/2201/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2201/files
b6f4a75 Address review comments about Windows Bash lookup Byron Jul 30, 2026 https://github.com/gitpython-developers/GitPython/pull/2201/commits/b6f4a75a682d5c5b2e26d22350a476957d4d4117
Clear filters https://github.com/gitpython-developers/GitPython/pull/2201/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2201/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2201/files
fun.py https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
test_index.py https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
git/index/fun.pyhttps://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
View file https://github.com/gitpython-developers/GitPython/blob/b6f4a75a682d5c5b2e26d22350a476957d4d4117/git/index/fun.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2201/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2201/files
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-1d155f283cbf575ea2d0cce3e16d9c60d5fab54c83626603f47eabd2334084b6
test/test_index.pyhttps://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
View file https://github.com/gitpython-developers/GitPython/blob/b6f4a75a682d5c5b2e26d22350a476957d4d4117/test/test_index.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2201/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
https://github.com/gitpython-developers/GitPython/pull/2201/files#diff-21c27b991511d3d0e3a14b4dfb56017689de2fa114c3edf11c577bd1ce744b72
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2201/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.