René's URL Explorer Experiment


Title: fix: reject unsafe output options in Commit.count by Byron · Pull Request #2184 · gitpython-developers/GitPython · GitHub

Open Graph Title: fix: reject unsafe output options in Commit.count by Byron · Pull Request #2184 · gitpython-developers/GitPython

X Title: fix: reject unsafe output options in Commit.count by Byron · Pull Request #2184 · gitpython-developers/GitPython

Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by Codex GPT-5. Created by Codex on behalf of Byron. Byron will review before this is ready to merge. Summary Validate options forwarded by Commit.count() with the existing revision unsafe-option guard. Preserve the explicit allow_unsafe_options=True escape hatch for trusted callers. Audit internal .git.* calls that can accept Git’s --output option; revision iteration, diff/diff-tree, blame, and archive paths were already guarded, leaving Commit.count() as the missing high-level wrapper. Advisory summary Advisory: GHSA-p538-c434-8v24 GHSA: GHSA-p538-c434-8v24 Severity: medium Package: GitPython (pip) Affected versions: <= 3.1.55 Patched versions: not yet designated CVE: not assigned The advisory is unpublished, so this public PR intentionally omits unnecessary exploitation detail. Git reference Git baseline a23bace963: diff.c defines --output as a shared diff option consumed by setup_revisions; t/t6000-rev-list-misc.sh covers the option with rev-list. Validation Regression test failed before the fix and passes after it. Focused unsafe-option tests: 3 passed. mypy git/objects/commit.py: passed. Ruff check and format check: passed. Full test/test_commit.py: 33 passed; 2 unrelated local failures because this fixture checkout has no master ref. codex review --commit 056e1f1474ca5d1c8817abe274633f7420c8104d: no findings.

Open Graph Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

X Description: Tasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2184

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e2bc0c7f-dbf7-0497-4189-bf65e0d3172a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE40E:DB09F:C4B8C7:FC0EB7:6B0100DC
html-safe-nonce25eb874cfbd81aca6acb453231bdefb99eba516120e05047e514438f44abaf41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDBFOkRCMDlGOkM0QjhDNzpGQzBFQjc6NkIwMTAwREMiLCJ2aXNpdG9yX2lkIjoiOTQwNzgzOTEzNzU5NTQxNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac30f3fe8b572de0b980359b38c1a89796c3cb9b69f47f36c67999e37cbd6b8169
hovercard-subject-tagpull_request:4131043786
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2184/files
twitter:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63622?s=400&v=4
og:image:altTasks This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here. refackiew Everything below this line was generated by C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2184/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2184%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2184%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2184/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2184/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2184/files
gitpython-developershttps://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Codehttps://github.com/gitpython-developers/GitPython
Issues1 (1)https://github.com/gitpython-developers/GitPython/issues
Pull requestshttps://github.com/gitpython-developers/GitPython/pulls
Discussionshttps://github.com/gitpython-developers/GitPython/discussions
Actionshttps://github.com/gitpython-developers/GitPython/actions
Security and quality42 (42)https://github.com/gitpython-developers/GitPython/security
Insightshttps://github.com/gitpython-developers/GitPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
mainhttps://github.com/gitpython-developers/GitPython/tree/main
fix-output-arghttps://github.com/gitpython-developers/GitPython/tree/fix-output-arg
Conversation 3 https://github.com/gitpython-developers/GitPython/pull/2184
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2184/commits
Checks 32 https://github.com/gitpython-developers/GitPython/pull/2184/checks
Files changed 2 https://github.com/gitpython-developers/GitPython/pull/2184/files
fix: reject unsafe output options in Commit.count https://github.com/gitpython-developers/GitPython/pull/2184/files#top
Show all changes 1 commit https://github.com/gitpython-developers/GitPython/pull/2184/files
38553b6 fix: reject unsafe output options in Commit.count Byron Jul 25, 2026 https://github.com/gitpython-developers/GitPython/pull/2184/commits/38553b6fddc7f6a667cdb45a6762343a08fc72b2
Clear filters https://github.com/gitpython-developers/GitPython/pull/2184/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2184/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2184/files
commit.py https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
test_commit.py https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
git/objects/commit.pyhttps://github.com/gitpython-developers/GitPython/pull/2184/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
View file https://github.com/gitpython-developers/GitPython/blob/38553b6fddc7f6a667cdb45a6762343a08fc72b2/git/objects/commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2184/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-88141770c3f374c9bacdef629c161e7bc75e7a1585827f5a35671b89df14291f
test/test_commit.pyhttps://github.com/gitpython-developers/GitPython/pull/2184/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
View file https://github.com/gitpython-developers/GitPython/blob/38553b6fddc7f6a667cdb45a6762343a08fc72b2/test/test_commit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2184/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2184/files
https://github.com/gitpython-developers/GitPython/pull/2184/files#diff-3c31ae447cf005d000406f21d8ba228d2313390175fbac5be1e21736aaa7fcb0
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2184/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.