Title: Run `gc.collect()` twice in `test_rename` on Python 3.12 by EliahKagan · Pull Request #2109 · gitpython-developers/GitPython · GitHub
Open Graph Title: Run `gc.collect()` twice in `test_rename` on Python 3.12 by EliahKagan · Pull Request #2109 · gitpython-developers/GitPython
X Title: Run `gc.collect()` twice in `test_rename` on Python 3.12 by EliahKagan · Pull Request #2109 · gitpython-developers/GitPython
Description: Recently, the conditional gc.collect() step for Python >= 3.12 in TestSubmodule.test_rename is often insufficient. This has mainly been seen in #2248. For example: https://github.com/gitpython-developers/GitPython/actions/runs/22864869684/job/66331124651?pr=2106#step:12:620 In principle, there can be situations with finalizers where a cycle is only collectable due to finalization that happened due to a previous collection. Therefore, there is occasionally a benefit to collecting twice. This does that, in the hope that it will help. As expanded on in my self-review comment below, I hope this is temporary, at least in this exact form.
Open Graph Description: Recently, the conditional gc.collect() step for Python >= 3.12 in TestSubmodule.test_rename is often insufficient. This has mainly been seen in #2248. For example: https://github.com/gitpython-d...
X Description: Recently, the conditional gc.collect() step for Python >= 3.12 in TestSubmodule.test_rename is often insufficient. This has mainly been seen in #2248. For example: https://github.com/gitpyth...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2109
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0d017d09-a8d4-de38-3f30-09e9f8110b29 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0B0:371C7C:1697281:20A7DE8:6A54CE6D |
| html-safe-nonce | f6e1f1968b6c18e8ce072bd414b14d59fcf37a93f2f6e69d4ff00aef47f57473 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEIwOjM3MUM3QzoxNjk3MjgxOjIwQTdERTg6NkE1NENFNkQiLCJ2aXNpdG9yX2lkIjoiNTg3MjYyODY2NjczMTkwODcxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cacb12f8ca2d09e061c39aa8a505e05f75713372cab28e37c87fbc995da997b0 |
| hovercard-subject-tag | pull_request:3374603177 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2109/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Recently, the conditional gc.collect() step for Python >= 3.12 in TestSubmodule.test_rename is often insufficient. This has mainly been seen in #2248. For example: https://github.com/gitpython-d... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6e5f2e6ff3f430aa60a674066f957bca9f2106017e1b68126417422b58ce6e1e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | be4d48619391052c9d312c7b587bb2ac38a97f57 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width