Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython · GitHub
Open Graph Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython
X Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython
Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually associated with having a True value of USE_SHELL, but the association is not necessarily obvious. Specifically: For the warning given when reading USE_SHELL on the Git class or through an instance, extra_danger is always False. This is so even if the USE_SHELL value is currently True, because the danger that arises from True occurs internally. For the warning given when writing USE_SHELL, which can only be done on the Git class and not on or through an instance, extra_danger is the value set for the attribute. This is because setting USE_SHELL to True incurs the danger described in #1896. When reading the code, which passed extra_danger positionally, the meaning of the parameter may not always have been obvious. This makes the extra_danger parameter keyword-only, and passes it by keyword in all invocations, so that its meaning is clearer.
Open Graph Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc...
X Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2045
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4f36627b-bc7c-1a71-f334-be9700d940e6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 904E:285A87:10753:15246:6968A923 |
| html-safe-nonce | e6a64e1dc7a09205475ab73d1c2de7f999eff8cfdcda3d966a98c5b18c6696e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDRFOjI4NUE4NzoxMDc1MzoxNTI0Njo2OTY4QTkyMyIsInZpc2l0b3JfaWQiOiIzMzA1OTE5ODQ1MTM4NzM3NDQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 983bbd7bf9f371b6ac0f37987e1510e0132d43799a612359087fbd841c21628e |
| hovercard-subject-tag | pull_request:2576034865 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2045/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width