René's URL Explorer Experiment


Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython · GitHub

Open Graph Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython

X Title: Clarify `USE_SHELL` warning helper signature by EliahKagan · Pull Request #2045 · gitpython-developers/GitPython

Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually associated with having a True value of USE_SHELL, but the association is not necessarily obvious. Specifically: For the warning given when reading USE_SHELL on the Git class or through an instance, extra_danger is always False. This is so even if the USE_SHELL value is currently True, because the danger that arises from True occurs internally. For the warning given when writing USE_SHELL, which can only be done on the Git class and not on or through an instance, extra_danger is the value set for the attribute. This is because setting USE_SHELL to True incurs the danger described in #1896. When reading the code, which passed extra_danger positionally, the meaning of the parameter may not always have been obvious. This makes the extra_danger parameter keyword-only, and passes it by keyword in all invocations, so that its meaning is clearer.

Open Graph Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc...

X Description: This is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2045

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:e7c60f75-200c-8e55-697e-b78f472ae9d0
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idD02E:2C8CA4:104580D:1673F36:6968A90C
html-safe-nonced5dd89e3e1866172608b91aa8d62e64a93d47343d8cd6dd7fb6ebe66207afbc3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDJFOjJDOENBNDoxMDQ1ODBEOjE2NzNGMzY6Njk2OEE5MEMiLCJ2aXNpdG9yX2lkIjoiMTk5ODk2NzE4NTM2NjEwMDIzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6e4417d1daa89c83ccbf0d988f2df62b4d312cd1a115418400977aa2a6283898
hovercard-subject-tagpull_request:2576034865
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2045/checks
twitter:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
og:image:altThis is a minor refactor of how _warn_use_shell can be, and is, invoked. The _warn_use_shell helper function in git.cmd takes a single bool-valued argument extra_danger, which is conceptually assoc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98
turbo-cache-controlno-cache
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3223a6503d318917691422cdadfbe16cd8fb21e5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2045/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2045%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2045%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2045/checks
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
EliahKaganhttps://github.com/EliahKagan
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:shell-warning-refactorhttps://github.com/EliahKagan/GitPython/tree/shell-warning-refactor
Conversation 0 https://github.com/gitpython-developers/GitPython/pull/2045
Commits 1 https://github.com/gitpython-developers/GitPython/pull/2045/commits
Checks 27 https://github.com/gitpython-developers/GitPython/pull/2045/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2045/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2045/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2045%2Fchecks
Clarify USE_SHELL warning helper signature https://github.com/gitpython-developers/GitPython/pull/2045/checks#top
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2045/checks
test-cygwin on: pull_request https://github.com/gitpython-developers/GitPython/actions/runs/15512393422
test (fast) https://github.com/gitpython-developers/GitPython/actions/runs/15512393422/job/43674909767?pr=2045
test (perf) https://github.com/gitpython-developers/GitPython/actions/runs/15512393422/job/43674909771?pr=2045
CodeQL on: pull_request https://github.com/gitpython-developers/GitPython/actions/runs/15512393423
Analyze (actions) https://github.com/gitpython-developers/GitPython/actions/runs/15512393423/job/43674909770?pr=2045
Analyze (python) https://github.com/gitpython-developers/GitPython/actions/runs/15512393423/job/43674909769?pr=2045
test-alpine on: pull_request https://github.com/gitpython-developers/GitPython/actions/runs/15512393424
test https://github.com/gitpython-developers/GitPython/actions/runs/15512393424/job/43674909761?pr=2045
Python package on: pull_request https://github.com/gitpython-developers/GitPython/actions/runs/15512393427
test (ubuntu, 3.7) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909811?pr=2045
test (ubuntu, 3.8) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909816?pr=2045
test (ubuntu, 3.9) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909826?pr=2045
test (ubuntu, 3.10) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909825?pr=2045
test (ubuntu, 3.11) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909831?pr=2045
test (ubuntu, 3.12) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909823?pr=2045
test (ubuntu, 3.13) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909832?pr=2045
test (ubuntu, 3.13t) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909840?pr=2045
test (macos, 3.8) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909835?pr=2045
test (macos, 3.9) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909834?pr=2045
test (macos, 3.10) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909842?pr=2045
test (macos, 3.11) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909837?pr=2045
test (macos, 3.12) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909836?pr=2045
test (macos, 3.13) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909838?pr=2045
test (windows, 3.7) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909839?pr=2045
test (windows, 3.8) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909833?pr=2045
test (windows, 3.9) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909844?pr=2045
test (windows, 3.10) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909841?pr=2045
test (windows, 3.11) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909847?pr=2045
test (windows, 3.12) https://github.com/gitpython-developers/GitPython/actions/runs/15512393427/job/43674909845?pr=2045
Lint on: pull_request https://github.com/gitpython-developers/GitPython/actions/runs/15512393429
lint https://github.com/gitpython-developers/GitPython/actions/runs/15512393429/job/43674909796?pr=2045
CodeQL https://github.com/gitpython-developers/GitPython/pull/2045/checks?check_run_id=43674936006
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.