Title: Fix CI `mypy` command on free-threaded Python by EliahKagan · Pull Request #2040 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix CI `mypy` command on free-threaded Python by EliahKagan · Pull Request #2040 · gitpython-developers/GitPython
X Title: Fix CI `mypy` command on free-threaded Python by EliahKagan · Pull Request #2040 · gitpython-developers/GitPython
Description: When the version is represented as 3.13t, the --python-version option needs an operand of 3.13, not 3.13t. (This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t, too.) Before this change, in the Python 3.13t run: + mypy --python-version=3.13t usage: mypy [-h] [-v] [-V] [more options; see below] [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...] mypy: error: argument --python-version: Invalid python version '3.13t' (expected format: 'x.y') This isn't new--it's always happened in the mypy step in the 3.13t job. We just never noticed it, because the mypy step always reports failure even when working correctly, because there are a number of unresolved type errors. Most of them should not be suppressed, but neither I nor others have get gotten around yet to fixing them. Some of them maybe should be suppressed, but neither I nor others have gotten around yet to verifying are reasonable to suppress. (For quite some time, the mypy step has step-level continue-on-error, which causes it not to fail the job.) There's no connection between this and #2037 or #2038/#2039, except in the broad conceptual sense that this and #2038 share as a contributing factor that it's easy not to notice unanticipated new problems with mypy. However, just in case, I have verified that the effect of #2039 applies the same to 3.13t as to 3.13, by first testing this on a feature branch that had not integrated #2039, and then rebasing. No change is needed in tox.ini, even separately from that not yet listing a py313t environment, because tox.ini as currently written does not pass a --python-version argument to mypy. I plan to merge this once everything passes on CI, after also verifying again that the output is as expected. Edit: The effect is as expected and intended. I'll just wait for the rest of CI to pass before merging.
Open Graph Description: When the version is represented as 3.13t, the --python-version option needs an operand of 3.13, not 3.13t. (This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t...
X Description: When the version is represented as 3.13t, the --python-version option needs an operand of 3.13, not 3.13t. (This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2040
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f46418d3-b17a-9985-a5e8-b284de6a36ac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C45E:72C59:100581:1676B8:6968D2C1 |
| html-safe-nonce | fd502d7f97cfcb66f7609ccb8a8160bb3717dcf5aceb17ecd007cab735730a51 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDVFOjcyQzU5OjEwMDU4MToxNjc2Qjg6Njk2OEQyQzEiLCJ2aXNpdG9yX2lkIjoiODUxNjgwMzcxNzQ2ODA1MDExMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b5bae75e41c437b95252679eb5fc9acae74fe7a06f115f4fa7a4d58ad23d5912 |
| hovercard-subject-tag | pull_request:2575715887 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2040/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | When the version is represented as 3.13t, the --python-version option needs an operand of 3.13, not 3.13t. (This, and the fix here, will automatically apply to later threaded Pythons, such as 3.14t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3c4e9f2fc1db52c609205138be6a397cfde4574cb54d53015014de30dd49f27e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fb1ea11f8c37dd4dd50347cca70d89824e93788 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width