Title: Fix Git.{AutoInterrupt,CatFileContentStream} static typing by EliahKagan · Pull Request #2039 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix Git.{AutoInterrupt,CatFileContentStream} static typing by EliahKagan · Pull Request #2039 · gitpython-developers/GitPython
X Title: Fix Git.{AutoInterrupt,CatFileContentStream} static typing by EliahKagan · Pull Request #2039 · gitpython-developers/GitPython
Description: Fixes #2038 This fixes mypy for Git.AutoInterrupt and Git.CatFileContentStream. Static type checking of these was broken inadvertently in #2037, as described in #2038. This is approach (2) described in #2038. Further details are in that bug report and in the commit messages. As in #2037, I've made sure this doesn't break Sphinx (though it would be very strange if it did), by checking locally as well as in the RTD cloud build. The entries in the latter can be examined: AutoInterrupt, CatFileContentStream. Because CI runs mypy but does not verify its output, I'll wait to mark this non-draft until I've looked at all relevant jobs' mypy steps. (But this may be before the jobs complete, since the jobs that run mypy do so before running pytest, not after.) Edit: All mypy results on CI look as they did before, and the new errors that came in with #2037 are gone.
Open Graph Description: Fixes #2038 This fixes mypy for Git.AutoInterrupt and Git.CatFileContentStream. Static type checking of these was broken inadvertently in #2037, as described in #2038. This is approach (2) describe...
X Description: Fixes #2038 This fixes mypy for Git.AutoInterrupt and Git.CatFileContentStream. Static type checking of these was broken inadvertently in #2037, as described in #2038. This is approach (2) describe...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2039
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a84384df-5a35-9eef-98b2-942214addc6a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A606:3DB7EA:77FC6C:A4CFF8:6968AFBB |
| html-safe-nonce | 44d6ca658b4d36159168f7edd3cb59268aad90e7e2da4ac67ee88742cd0bd960 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjA2OjNEQjdFQTo3N0ZDNkM6QTRDRkY4OjY5NjhBRkJCIiwidmlzaXRvcl9pZCI6IjcyOTYwMTU4MTk3MDkzOTQ4NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 17ba8d37f7a4124801c8e2ffa61153f96c85c0330e6f70db153279a3dc175d26 |
| hovercard-subject-tag | pull_request:2575669833 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2039/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #2038 This fixes mypy for Git.AutoInterrupt and Git.CatFileContentStream. Static type checking of these was broken inadvertently in #2037, as described in #2038. This is approach (2) describe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width