René's URL Explorer Experiment

Title: Preserve quoted leading and trailing single-line config var whitespace by EliahKagan · Pull Request #2036 · gitpython-developers/GitPython · GitHub

Open Graph Title: Preserve quoted leading and trailing single-line config var whitespace by EliahKagan · Pull Request #2036 · gitpython-developers/GitPython

X Title: Preserve quoted leading and trailing single-line config var whitespace by EliahKagan · Pull Request #2036 · gitpython-developers/GitPython

Description: #2035 fixed issue #1923 by removing separate double quotation marks appearing on a single-line configuration variable when parsing a configuration file. However, as noted in #2035 (comment), it also stripped leading and trailing whitespace from the string obtained by removing the quotes. In this PR: 5f30320 adds a test case of a plausible--and in my view, decisive--scenario where such whitespace needs to be preserved and where a user would almost certainly expect it to preserve. This test would also have failed before #2035, due to the absence of quote removal. But it is the sort of value that one would expect to parse correctly now that #1923 is fixed, and which #2035 almost does parse correctly. bd2b930 fixes the case by removing the strip() call while leaving the changes from #2035 otherwise intact. The test added in (1) fails until this change, and then passes. See the commit message for further details.

Open Graph Description: #2035 fixed issue #1923 by removing separate double quotation marks appearing on a single-line configuration variable when parsing a configuration file. However, as noted in #2035 (comment), it als...

X Description: #2035 fixed issue #1923 by removing separate double quotation marks appearing on a single-line configuration variable when parsing a configuration file. However, as noted in #2035 (comment), it als...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2036

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width