René's URL Explorer Experiment


Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython · GitHub

Open Graph Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython

X Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython

Description: I also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_git function. I don't have a machine with Cygwin, so I can't test that it actually does work, but I trust the Python docs when they say that on Cygwin, sys.platform will be cygwin.

Open Graph Description: I also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...

X Description: I also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2026

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7208ab0c-9e3c-ce0a-0dbc-260c56223eea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE10:29D5C2:127831:1A1909:6968D325
html-safe-noncece7a01643740767605baac3dc67d468b5a741367f84a9eb918cd06acd7bd848d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTEwOjI5RDVDMjoxMjc4MzE6MUExOTA5OjY5NjhEMzI1IiwidmlzaXRvcl9pZCI6IjQxMTM5MzM5OTY3NDUzNDc4NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5d9ba20c287df8d8d073c15fba4afa1923a859835e1e31bf69ce505d610a5452
hovercard-subject-tagpull_request:2537193984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2026/files
twitter:imagehttps://avatars.githubusercontent.com/u/97672150?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/97672150?s=400&v=4
og:image:altI also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneaf2d7af0cc84117fa10bf36808605ef68a335c9d8a804b9cdac55f8d77230b00
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecc844ab6ee0198cc2e2c142dcb8a5c2a61d48743
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2026/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2026%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2026%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
EliahKaganhttps://github.com/EliahKagan
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
gcmarx:mainhttps://github.com/gcmarx/GitPython/tree/main
Conversation 21 https://github.com/gitpython-developers/GitPython/pull/2026
Commits 16 https://github.com/gitpython-developers/GitPython/pull/2026/commits
Checks 25 https://github.com/gitpython-developers/GitPython/pull/2026/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/2026/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
correctly handle uname-cmd that doesn't point to an executable file https://github.com/gitpython-developers/GitPython/pull/2026/files#top
Show all changes 16 commits https://github.com/gitpython-developers/GitPython/pull/2026/files
ec00872 add tests for is_cygwin_git gcmarx May 21, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/ec0087227ed37cf1df441e4f0f73daa25895c4b5
de5e57c check for the existence/execute bit on the uname command before tryin… gcmarx May 21, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/de5e57caf26e5f6772ac02a3944e58e0aba177f3
428be1a adding self to authors gcmarx May 21, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/428be1a504e2b30c195786d5ca6708f4c39d90a7
58ff723 Revert "check for the existence/execute bit on the uname command befo… gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/58ff723e6757af3c508e2a9424d287e5016ac230
7187984 use pathlib.Path instead of os.path.isfile gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/71879840b8a72890f63fcadf7a92694106610ef0
3f5a942 don't keep checking if sys.platform isn't 'cygwin' gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/3f5a942be8293bb8c663631756885f877afc22e7
226f4ff check that uname_cmd points to a file; if uname_cmd were a directory,… gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/226f4ffcaf2deed4598b9ff53902a12f6483c069
22d6284 don't use match-case, since it's a 3.10 feature gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/22d6284b099e99716da101198ce113c96e35423a
b1289ee it's is_file(), not isfile() gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/b1289eeb3676e63f4261518655ee90808e9d3d1f
cffa264 turns out f-strings before 3.8 don't support {variable=} notation, ta… gcmarx May 22, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/cffa264bdc1dd09a13a85cc27417b85628273e14
36a893b add self to AUTHORS, add Emacs tempfiles to .gitignore gcmarx May 23, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/36a893bbd47a08df80e0266f6ce5182915511833
c441316 use `strings` instead of `uname` to detect cygwin gcmarx May 27, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/c441316b7714207eaf2c13be5104d15ec69943bd
0df0818 debug printing gcmarx May 27, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/0df08181f1012f0e591f998dcc57fd594e754d98
58f7710 Revert "debug printing" gcmarx May 28, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/58f77105f5163408a9bf323518b96646ab413561
1731c1e Revert "use `strings` instead of `uname` to detect cygwin" gcmarx May 28, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/1731c1e377aca056d1a7acf2dd6df0e68a4e9e7e
f3ab5d3 incorporate review feedback from @EliahKagan gcmarx May 28, 2025 https://github.com/gitpython-developers/GitPython/pull/2026/commits/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af
Clear filters https://github.com/gitpython-developers/GitPython/pull/2026/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
.gitignore https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
AUTHORS https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
util.py https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test_util.py https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
.gitignorehttps://github.com/gitpython-developers/GitPython/pull/2026/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
View file https://github.com/gcmarx/GitPython/blob/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2026/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
AUTHORShttps://github.com/gitpython-developers/GitPython/pull/2026/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
View file https://github.com/gcmarx/GitPython/blob/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af/AUTHORS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2026/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
git/util.pyhttps://github.com/gitpython-developers/GitPython/pull/2026/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
View file https://github.com/gcmarx/GitPython/blob/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af/git/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2026/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test/test_util.pyhttps://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
View file https://github.com/gcmarx/GitPython/blob/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af/test/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/2026/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
https://github.com/gitpython-developers/GitPython/pull/2026/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.