René's URL Explorer Experiment


Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython · GitHub

Open Graph Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython

X Title: correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython

Description: GitPython is a python library used to interact with Git repositories. - correctly handle `uname-cmd` that doesn't point to an executable file by gcmarx · Pull Request #2026 · gitpython-developers/GitPython

Open Graph Description: I also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...

X Description: I also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2026

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:ce66fb23-0aee-6e3c-71b8-2558902f1baa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC30:300E6:21A565:2C95B1:69686FEB
html-safe-nonce2b512b01562a87dd8bae58b4a9c5f4fbd224994497a4a58b1a19a84d6070122a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzMwOjMwMEU2OjIxQTU2NToyQzk1QjE6Njk2ODZGRUIiLCJ2aXNpdG9yX2lkIjoiMjUwODY3ODE3MTU5MDE2MDM2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a2bed7df9e3410e89b53d7d62f4a1be9e76b4b1d580a58e6f6d3ba7cefd1634
hovercard-subject-tagpull_request:2537193984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2026/commits
twitter:imagehttps://opengraph.githubassets.com/eb0441c458c6ee0640a538a4018515f113ff454566548aa6f70ad3045de0e60a/gitpython-developers/GitPython/pull/2026
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb0441c458c6ee0640a538a4018515f113ff454566548aa6f70ad3045de0e60a/gitpython-developers/GitPython/pull/2026
og:image:altI also ran into the issue from #1979. My proposed solution is that GitPython should only try to run uname_cmd if it points to an executable file. I also wrote a short test class for the is_cygwin_g...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegcmarx
hostnamegithub.com
expected-hostnamegithub.com
None50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54
turbo-cache-controlno-cache
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefef287f17234b4529a4b112a3d47fe8551e32ddd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/2026/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2026%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F2026%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/commits
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/commits
Reloadhttps://github.com/gitpython-developers/GitPython/pull/2026/commits
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/commits
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/2026/commits
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
EliahKaganhttps://github.com/EliahKagan
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
gcmarx:mainhttps://github.com/gcmarx/GitPython/tree/main
Conversationhttps://github.com/gitpython-developers/GitPython/pull/2026
Commits16 (16)https://github.com/gitpython-developers/GitPython/pull/2026/commits
Checkshttps://github.com/gitpython-developers/GitPython/pull/2026/checks
Files changedhttps://github.com/gitpython-developers/GitPython/pull/2026/files
correctly handle uname-cmd that doesn't point to an executable filehttps://github.com/gitpython-developers/GitPython/pull/2026/commits#top
EliahKaganhttps://github.com/EliahKagan
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
gcmarx:mainhttps://github.com/gcmarx/GitPython/tree/main
add tests for is_cygwin_githttps://github.com/gitpython-developers/GitPython/pull/2026/commits/ec0087227ed37cf1df441e4f0f73daa25895c4b5
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
ec00872https://github.com/gitpython-developers/GitPython/pull/2026/commits/ec0087227ed37cf1df441e4f0f73daa25895c4b5
https://github.com/gitpython-developers/GitPython/tree/ec0087227ed37cf1df441e4f0f73daa25895c4b5
check for the existence/execute bit on the uname command before trying to run ithttps://github.com/gitpython-developers/GitPython/pull/2026/commits/de5e57caf26e5f6772ac02a3944e58e0aba177f3
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
de5e57chttps://github.com/gitpython-developers/GitPython/pull/2026/commits/de5e57caf26e5f6772ac02a3944e58e0aba177f3
https://github.com/gitpython-developers/GitPython/tree/de5e57caf26e5f6772ac02a3944e58e0aba177f3
adding self to authorshttps://github.com/gitpython-developers/GitPython/pull/2026/commits/428be1a504e2b30c195786d5ca6708f4c39d90a7
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
428be1ahttps://github.com/gitpython-developers/GitPython/pull/2026/commits/428be1a504e2b30c195786d5ca6708f4c39d90a7
https://github.com/gitpython-developers/GitPython/tree/428be1a504e2b30c195786d5ca6708f4c39d90a7
Revert "check for the existence/execute bit on the uname command before trying to run it"https://github.com/gitpython-developers/GitPython/pull/2026/commits/58ff723e6757af3c508e2a9424d287e5016ac230
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
58ff723https://github.com/gitpython-developers/GitPython/pull/2026/commits/58ff723e6757af3c508e2a9424d287e5016ac230
https://github.com/gitpython-developers/GitPython/tree/58ff723e6757af3c508e2a9424d287e5016ac230
use pathlib.Path instead of os.path.isfilehttps://github.com/gitpython-developers/GitPython/pull/2026/commits/71879840b8a72890f63fcadf7a92694106610ef0
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
7187984https://github.com/gitpython-developers/GitPython/pull/2026/commits/71879840b8a72890f63fcadf7a92694106610ef0
https://github.com/gitpython-developers/GitPython/tree/71879840b8a72890f63fcadf7a92694106610ef0
don't keep checking if sys.platform isn't 'cygwin'https://github.com/gitpython-developers/GitPython/pull/2026/commits/3f5a942be8293bb8c663631756885f877afc22e7
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
3f5a942https://github.com/gitpython-developers/GitPython/pull/2026/commits/3f5a942be8293bb8c663631756885f877afc22e7
https://github.com/gitpython-developers/GitPython/tree/3f5a942be8293bb8c663631756885f877afc22e7
check that uname_cmd points to a file; if uname_cmd were a directory, it could both exist and have os.X_OK but not workhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/226f4ffcaf2deed4598b9ff53902a12f6483c069
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
226f4ffhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/226f4ffcaf2deed4598b9ff53902a12f6483c069
https://github.com/gitpython-developers/GitPython/tree/226f4ffcaf2deed4598b9ff53902a12f6483c069
don't use match-case, since it's a 3.10 featurehttps://github.com/gitpython-developers/GitPython/pull/2026/commits/22d6284b099e99716da101198ce113c96e35423a
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
22d6284https://github.com/gitpython-developers/GitPython/pull/2026/commits/22d6284b099e99716da101198ce113c96e35423a
https://github.com/gitpython-developers/GitPython/tree/22d6284b099e99716da101198ce113c96e35423a
it's is_file(), not isfile()https://github.com/gitpython-developers/GitPython/pull/2026/commits/b1289eeb3676e63f4261518655ee90808e9d3d1f
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
b1289eehttps://github.com/gitpython-developers/GitPython/pull/2026/commits/b1289eeb3676e63f4261518655ee90808e9d3d1f
https://github.com/gitpython-developers/GitPython/tree/b1289eeb3676e63f4261518655ee90808e9d3d1f
turns out f-strings before 3.8 don't support {variable=} notation, take that outhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/cffa264bdc1dd09a13a85cc27417b85628273e14
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
cffa264https://github.com/gitpython-developers/GitPython/pull/2026/commits/cffa264bdc1dd09a13a85cc27417b85628273e14
https://github.com/gitpython-developers/GitPython/tree/cffa264bdc1dd09a13a85cc27417b85628273e14
add self to AUTHORS, add Emacs tempfiles to .gitignorehttps://github.com/gitpython-developers/GitPython/pull/2026/commits/36a893bbd47a08df80e0266f6ce5182915511833
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
36a893bhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/36a893bbd47a08df80e0266f6ce5182915511833
https://github.com/gitpython-developers/GitPython/tree/36a893bbd47a08df80e0266f6ce5182915511833
use `strings` instead of `uname` to detect cygwinhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/c441316b7714207eaf2c13be5104d15ec69943bd
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
c441316https://github.com/gitpython-developers/GitPython/pull/2026/commits/c441316b7714207eaf2c13be5104d15ec69943bd
https://github.com/gitpython-developers/GitPython/tree/c441316b7714207eaf2c13be5104d15ec69943bd
debug printinghttps://github.com/gitpython-developers/GitPython/pull/2026/commits/0df08181f1012f0e591f998dcc57fd594e754d98
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
0df0818https://github.com/gitpython-developers/GitPython/pull/2026/commits/0df08181f1012f0e591f998dcc57fd594e754d98
https://github.com/gitpython-developers/GitPython/tree/0df08181f1012f0e591f998dcc57fd594e754d98
Revert "debug printing"https://github.com/gitpython-developers/GitPython/pull/2026/commits/58f77105f5163408a9bf323518b96646ab413561
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
58f7710https://github.com/gitpython-developers/GitPython/pull/2026/commits/58f77105f5163408a9bf323518b96646ab413561
https://github.com/gitpython-developers/GitPython/tree/58f77105f5163408a9bf323518b96646ab413561
Revert "use `strings` instead of `uname` to detect cygwin"https://github.com/gitpython-developers/GitPython/pull/2026/commits/1731c1e377aca056d1a7acf2dd6df0e68a4e9e7e
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
1731c1ehttps://github.com/gitpython-developers/GitPython/pull/2026/commits/1731c1e377aca056d1a7acf2dd6df0e68a4e9e7e
https://github.com/gitpython-developers/GitPython/tree/1731c1e377aca056d1a7acf2dd6df0e68a4e9e7e
incorporate review feedback from @EliahKaganhttps://github.com/gitpython-developers/GitPython/pull/2026/commits/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af
https://github.com/gcmarx
gcmarxhttps://github.com/gitpython-developers/GitPython/commits?author=gcmarx
f3ab5d3https://github.com/gitpython-developers/GitPython/pull/2026/commits/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af
https://github.com/gitpython-developers/GitPython/tree/f3ab5d3810b1e8c1f0365d26eea3e91808d8e4af
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.