Title: `IndexFile._to_relative_path` - fix case where absolute path gets stripped of trailing slash by kamilkozik7 · Pull Request #2012 · gitpython-developers/GitPython · GitHub
Open Graph Title: `IndexFile._to_relative_path` - fix case where absolute path gets stripped of trailing slash by kamilkozik7 · Pull Request #2012 · gitpython-developers/GitPython
X Title: `IndexFile._to_relative_path` - fix case where absolute path gets stripped of trailing slash by kamilkozik7 · Pull Request #2012 · gitpython-developers/GitPython
Description: I encountered this issue on MacOS, python 3.7 and later Added fix and appropriate unit test. Stripping of trailing slash seems to be happening in os.path.relpath, altough I am not sure whether that is expected behaviour. In case it is not expected, and ever gets fixed, I added an additional check ( and not result.endswith(os.sep)) to make sure that the trailing slash doesn't get duplicated.
Open Graph Description: I encountered this issue on MacOS, python 3.7 and later Added fix and appropriate unit test. Stripping of trailing slash seems to be happening in os.path.relpath, altough I am not sure whether that...
X Description: I encountered this issue on MacOS, python 3.7 and later Added fix and appropriate unit test. Stripping of trailing slash seems to be happening in os.path.relpath, altough I am not sure whether that...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/2012
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6d67ab80-403d-a0da-4726-70443c78db89 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0FA:75A99:4E533B:6E75B2:696A0D04 |
| html-safe-nonce | 655a19fe841044a02e63018d2ccf150bfa868379bbd5661f6f4d066a1535891e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEZBOjc1QTk5OjRFNTMzQjo2RTc1QjI6Njk2QTBEMDQiLCJ2aXNpdG9yX2lkIjoiNzI3ODU0NTA2MDk4MDQ2MDgwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4c573ad08ec7ed768eb56e9ab17cc54213a88d1c17bb1dbc2d4cfa54500403bc |
| hovercard-subject-tag | pull_request:2379133688 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/2012/files |
| twitter:image | https://avatars.githubusercontent.com/u/26979805?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/26979805?s=400&v=4 |
| og:image:alt | I encountered this issue on MacOS, python 3.7 and later Added fix and appropriate unit test. Stripping of trailing slash seems to be happening in os.path.relpath, altough I am not sure whether that... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width