Title: Add the `.git` subdir as another `safe.directory` on Cygwin CI by EliahKagan · Pull Request #1916 · gitpython-developers/GitPython · GitHub
Open Graph Title: Add the `.git` subdir as another `safe.directory` on Cygwin CI by EliahKagan · Pull Request #1916 · gitpython-developers/GitPython
X Title: Add the `.git` subdir as another `safe.directory` on Cygwin CI by EliahKagan · Pull Request #1916 · gitpython-developers/GitPython
Description: As shown in this run on my fork, the CI test job for Cygwin is failing now. This fixes that. The first commit in this pull request just demonstrates that the failure is due to the upgrade of the Cygwin git package from 2.43.0-1 to 2.45.1-1. Although that commit makes test pass, I recommend against following that approach, mainly because the new version contains multiple security updates (coming in with the upstream 2.45.1 version, not with any downstream patches), but also because the older version will eventually be dropped from the Cygwin repositories. The better workaround is in the second commit here, which adds the .git subdirectory of the cloned GitPython directory as a value of the multi-valued safe.directory Git configuration variable. Its parent directory is already added, which was previously sufficient, but not anymore. I suspect that, rather than this being any bug in the downstream package, this is actually the correct behavior due to one of the several security fixes in the new version of Git, though I have not verified that. So maybe this is really not a workaround, but a permanent fix. I believe the reason there is no need to modify any other workflow is that the other workflows don't need to add any safe.directory paths at all: they either clone the repository with the necessary ownership in the first place or, in the case of the Alpine Linux job, set the ownership with chown.
Open Graph Description: As shown in this run on my fork, the CI test job for Cygwin is failing now. This fixes that. The first commit in this pull request just demonstrates that the failure is due to the upgrade of the Cy...
X Description: As shown in this run on my fork, the CI test job for Cygwin is failing now. This fixes that. The first commit in this pull request just demonstrates that the failure is due to the upgrade of the Cy...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1916
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:6bc0910e-6657-395a-a11e-5ab64390bec5 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C84C:812E7:3B99BA:5074B1:696873F9 |
| html-safe-nonce | 6b02690d4bdc6d12250a8275d628291106a5799eb601704ef020ac6374cec205 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODRDOjgxMkU3OjNCOTlCQTo1MDc0QjE6Njk2ODczRjkiLCJ2aXNpdG9yX2lkIjoiNTEwNTQzOTgyNDIzMDc3Mzc1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8b1ca46525c3a9715bb4e1999c521affe3f2444fbf2d310dad91888cfb51c94d |
| hovercard-subject-tag | pull_request:1889104424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1916/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | As shown in this run on my fork, the CI test job for Cygwin is failing now. This fixes that. The first commit in this pull request just demonstrates that the failure is due to the upgrade of the Cy... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fef287f17234b4529a4b112a3d47fe8551e32ddd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width