Title: Fix typo in _get_exe_extensions PATHEXT fallback by EliahKagan · Pull Request #1890 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix typo in _get_exe_extensions PATHEXT fallback by EliahKagan · Pull Request #1890 · gitpython-developers/GitPython
X Title: Fix typo in _get_exe_extensions PATHEXT fallback by EliahKagan · Pull Request #1890 · gitpython-developers/GitPython
Description: This applies two minor Cygwin-related clarifications, one of which is theoretically a bugfix though it affects conceptually non-public code that is currently not used in a way that could invoke the bug. Some specific details are in commit messages. The second commit, 988d97b, which fixes COM to .COM in the fallback for the PATHEXT environment variable--whose omission is almost certainly a typo, going back to the function's introduction in e6e23ed (#533)--is theoretically a bugfix. But as noted there, this code is only called when the Python interpreter is a native Windows program, but the function it is a part of is only called when the Python interpreter is not a native Windows program. (Also, it would be pretty unusual for the git executable to have a .com extension.) There are some further changes related to Cygwin detection that may make sense to make in the future, some of which might be best to make after adding relevant tests. The ones that are narrowly related to the change here are that: This value of PATHEXT here is still unusual, because order matters and this lists .BAT before .COM and .EXE, and because it is missing .CMD, which is part of what a minimal value for it should typically contain. I am uncertain if this strange order is intentional. It may also make sense for the list to include .VBS, .JS, .WS, and .MSC for compatibility with the fallback behavior of the Windows cmd.exe shell when PATHEXT is unset, which is what shutil.which does. (I have verified the result of Eryk Sun's debugger check in WinDbg on recent builds of Windows 10 and Windows 11; they are the same.) py_where should really be removed and replaced either with a call to shutil.which, which did not exist at the time py_where was introduced and would almost certainly have been used at that time if it had--or with other logic that works an altogether different way. Which should be done depends on the intent of the public Git.is_cygwin_git class method, which is the only code in GitPython that uses the is_cygwin_git function in git/util.py, for which the py_where helper exists. This PR doesn't try to cover any of that. It's really just applying some clarifications that didn't seem like they fit in any other PR that I would do soon. Regarding the last point about Git.is_cygwin_git, if the goal is to detect Cygwin git even on native Windows systems, then the code it uses will have to be significantly revised. That is because currently it always returns False on such systems. In addition, as noted in the py_where docstring and elsewhere, shell and non-shell path search differ from each other on native Windows, such that neither the nonpublic ad-hoc py_where nor the public general shutil.which will reliably tell us where git is. However, if a path search doesn't need to be done on native Windows, then it can be replaced with shutil.which unless some use has come to depend on (perhaps accidentally introduced) distinctive behavior of py_where. I plan to open an issue about that larger matter, which I am unlikely to work on anytime soon, but that perhaps someone would be interested to take on. (If you know what Git.is_cygwin_git's semantics are supposed to be, then I can make use of that information in the forthcoming issue, but I can still open it even if its intent is currently uncertain.)
Open Graph Description: This applies two minor Cygwin-related clarifications, one of which is theoretically a bugfix though it affects conceptually non-public code that is currently not used in a way that could invoke the...
X Description: This applies two minor Cygwin-related clarifications, one of which is theoretically a bugfix though it affects conceptually non-public code that is currently not used in a way that could invoke the...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1890
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:5e9ba599-7406-1d55-36fc-3e5616494eca |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DEA0:14530E:1120A7C:17A16EE:6968AFC3 |
| html-safe-nonce | 2211c495235a75034bf7703520e83b738c95e13e94b4f888ac35e576eb0aacba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUEwOjE0NTMwRToxMTIwQTdDOjE3QTE2RUU6Njk2OEFGQzMiLCJ2aXNpdG9yX2lkIjoiNjQ1Njc4NzI1NDU0NDc0MDI5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a1a320c964b7ec696643cf93f2534d0b9247995ec1623bde3cbd55a40ac5ad8f |
| hovercard-subject-tag | pull_request:1799518154 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1890/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This applies two minor Cygwin-related clarifications, one of which is theoretically a bugfix though it affects conceptually non-public code that is currently not used in a way that could invoke the... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width