Title: Revise type annotations slightly by EliahKagan · Pull Request #1860 · gitpython-developers/GitPython · GitHub
Open Graph Title: Revise type annotations slightly by EliahKagan · Pull Request #1860 · gitpython-developers/GitPython
X Title: Revise type annotations slightly by EliahKagan · Pull Request #1860 · gitpython-developers/GitPython
Description: This pull request is mostly a small revision to type hints to improve a couple things I had noticed when working on #1850 but omitted from there to avoid bloating its scope: 9f226fc: __slots__ is typically unannotated, but in once place it had an unnecessary annotation. 5d7e55b: Although mypy treats it the same when there are parameter annotations, __init__ is best annotated with an explicit return type of None, per PEP 484. In addition, I noticed some slight under-indentation in a few docstrings I had worked on #1850, and fixed that here in e984bfe. (The type annotation tweaks are sufficiently minor that there is an argument to be made that this is really the most significant individual change in this pull request.) There is some more information in the commit messages.
Open Graph Description: This pull request is mostly a small revision to type hints to improve a couple things I had noticed when working on #1850 but omitted from there to avoid bloating its scope: 9f226fc: __slots__ is ...
X Description: This pull request is mostly a small revision to type hints to improve a couple things I had noticed when working on #1850 but omitted from there to avoid bloating its scope: 9f226fc: __slots__ is ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1860
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e7f80193-9e97-8d3e-e16d-e1115199fadf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D622:C6D2A:62EA18:849F9F:69683965 |
| html-safe-nonce | bd27a0d875336cceb26c2a220f4798a3605a2255c67fee68ccdf1e8dfa3f48af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjIyOkM2RDJBOjYyRUExODo4NDlGOUY6Njk2ODM5NjUiLCJ2aXNpdG9yX2lkIjoiNTY0NjAyNjA1NDc0MDQ5MDU5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a603ebadd573a6aedc5573f8e348f18f4c06f899d8d7efa88f0806bc942901d8 |
| hovercard-subject-tag | pull_request:1755867249 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1860/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This pull request is mostly a small revision to type hints to improve a couple things I had noticed when working on #1850 but omitted from there to avoid bloating its scope: 9f226fc: __slots__ is ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e25f416bb6d8a5f8624aad6cebc375ab2c50ac58f2175f32a7093325e66e5515 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32212b8b3bddd6432b3b35d27c050b1c22bd8cca |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width