Title: `repo.blame` and `repo.blame_incremental` now accept `None` as the `rev` parameter. by Gaubbe · Pull Request #1846 · gitpython-developers/GitPython · GitHub
Open Graph Title: `repo.blame` and `repo.blame_incremental` now accept `None` as the `rev` parameter. by Gaubbe · Pull Request #1846 · gitpython-developers/GitPython
X Title: `repo.blame` and `repo.blame_incremental` now accept `None` as the `rev` parameter. by Gaubbe · Pull Request #1846 · gitpython-developers/GitPython
Description: Fixes #1835. As this pull request only affects the typings and does not change the behavior in any way, I did not write a test for the changes I made. While a test definitely could be written to see if the library does parse a blame output with uncommited changes, I don't perticularily think this is necessary, as the output format of the git blame -p command is the same as if there had been a commit, just with hard-coded values (such as the null SHA as the commit hash). Therefore, there is no reason the parsing would fail. I did manually test both methods with the None rev parameter and they do give the expected behavior. Let me know if you want me to change anything else!
Open Graph Description: Fixes #1835. As this pull request only affects the typings and does not change the behavior in any way, I did not write a test for the changes I made. While a test definitely could be written to se...
X Description: Fixes #1835. As this pull request only affects the typings and does not change the behavior in any way, I did not write a test for the changes I made. While a test definitely could be written to se...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1846
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f427a154-efee-3a11-5839-dcf9eed2d463 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 995E:310A82:C325:FA53:69694FBD |
| html-safe-nonce | c92ceadf1046270ab5c5a9cf967d1ee224e2f1e799d1ba68cf5bccae332cd9ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTVFOjMxMEE4MjpDMzI1OkZBNTM6Njk2OTRGQkQiLCJ2aXNpdG9yX2lkIjoiNTIwOTcxOTI1MDc2NTgyODAyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f6fff795f24b5f3ff5ffec76b0140fde71c2238dd12fa576d82ea3a43ef72bf1 |
| hovercard-subject-tag | pull_request:1741980644 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1846/files |
| twitter:image | https://avatars.githubusercontent.com/u/32037542?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/32037542?s=400&v=4 |
| og:image:alt | Fixes #1835. As this pull request only affects the typings and does not change the behavior in any way, I did not write a test for the changes I made. While a test definitely could be written to se... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width