Title: Omit warning prefix in "Bad git executable" message by EliahKagan · Pull Request #1816 · gitpython-developers/GitPython · GitHub
Open Graph Title: Omit warning prefix in "Bad git executable" message by EliahKagan · Pull Request #1816 · gitpython-developers/GitPython
X Title: Omit warning prefix in "Bad git executable" message by EliahKagan · Pull Request #1816 · gitpython-developers/GitPython
Description: This builds on the changes in #1815 by omitting the WARNING: prefix from the message itself that is produced when GIT_PYTHON_REFRESH is set to warn or a synonym (such as w or log) and the initial refresh performed at import time fails. This is the change suggested in #1815 (comment). When logging is not configured, this changes what we see when the initial refresh fails: -WARNING: Bad git executable. +Bad git executable. This may be considered slightly worse than before, but the advantage is that it doesn't print something that looks like a severity (or a redundancy) when logging is configured. For example, with common logging configuration such as by logging.basicConfig(), we get this improvement: -CRITICAL:git.cmd:WARNING: Bad git executable. +CRITICAL:git.cmd:Bad git executable. This also makes some improvements to the tests. Besides updating them for the changed message (3250313), it: Test that the GitCommandNotFound exception raised when attempting a git operation, when the command in Git.GIT_PYTHON_GIT_EXECUTABLE does not exist but was set directly (rather than through the environment variable or an explicit call to one of the refresh functions), has an expected command attribute value (85ef145). This case has been under test for a long time, but the test had not checked that attribute. Reorder switch the order of that and an adjacent test so the tests of behavior that directly involves GIT_PYTHON_GIT_EXECUTABLE are all together (also in 85ef145). Use Git consistently in test_git.py, instead of using Git in some places and type(self.git) in others. See db36174 for the rationale. Change a call like _logger.warning("%s", X) to _logger.warning(X) in test_index.py, because GitPython uses the latter in all the other places where they would be equivalent. See 4b86993 for details. (This is relevant to this PR because 5faf621 adds another such call.)
Open Graph Description: This builds on the changes in #1815 by omitting the WARNING: prefix from the message itself that is produced when GIT_PYTHON_REFRESH is set to warn or a synonym (such as w or log) and the initial ...
X Description: This builds on the changes in #1815 by omitting the WARNING: prefix from the message itself that is produced when GIT_PYTHON_REFRESH is set to warn or a synonym (such as w or log) and the initial ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1816
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8c48e74a-f495-c341-3a68-e2f950afc811 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 83F2:300E6:366ED1:48563C:69687430 |
| html-safe-nonce | acec73f6fe853ec35c54c4c377fd25b4895c16de0f2c4dddeb5a7e7f683d4d5a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0YyOjMwMEU2OjM2NkVEMTo0ODU2M0M6Njk2ODc0MzAiLCJ2aXNpdG9yX2lkIjoiNzQ3NzM0NDEyNDg1NjIwMjI4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d76c34f393ec5d73b7c7ebdb59fb91cf9b1dd01804355dabd1a89e874f987b78 |
| hovercard-subject-tag | pull_request:1713209837 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1816/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This builds on the changes in #1815 by omitting the WARNING: prefix from the message itself that is produced when GIT_PYTHON_REFRESH is set to warn or a synonym (such as w or log) and the initial ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fef287f17234b4529a4b112a3d47fe8551e32ddd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width