René's URL Explorer Experiment


Title: Report actual attempted Git command when Git.refresh fails by EliahKagan · Pull Request #1812 · gitpython-developers/GitPython · GitHub

Open Graph Title: Report actual attempted Git command when Git.refresh fails by EliahKagan · Pull Request #1812 · gitpython-developers/GitPython

X Title: Report actual attempted Git command when Git.refresh fails by EliahKagan · Pull Request #1812 · gitpython-developers/GitPython

Description: Fixes #1809 Fixes #1811 This modifies Git.refresh to report the attempted Git command rather than always git even if a different command was used. This affects the command attribute of the GitCommandNotFound exception, as well as (and automatically) the text displayed as cmdline: since that is from that attribute. It also expands and adds more tests of git.refesh (which calls Git.refresh) to encompass this behavior, verifying that they fail before #1809 is fixed and pass afterwards, as well as verify some behavior that was already established but not yet under test. Since #1811 would otherwise be exacerbated by these changes, I've also made it so those tests roll back the global changes they make that may affect other test by calling git.refresh() with no arguments. I believe this can be considered to fix that issue. There is a bit more information in the commit messages, including about why I've taken that approach to #1811, at least so far, rather than specifically capturing and restoring the pieces of state that are currently affected. This PR also includes some minor refactoring and comment revision for readability in some code called by git.refresh that should make no behavioral change. This includes an improvement to the wording of the comment in Git.refresh discussed in review comments on #1810; the opportunity for this came closer than I'd predicted in #1810 (comment). (It might be possible to improve it further.) Edit: Corrected "some behavior that was not established" to "some behavior that was already established but not yet under test".

Open Graph Description: Fixes #1809 Fixes #1811 This modifies Git.refresh to report the attempted Git command rather than always git even if a different command was used. This affects the command attribute of the GitComma...

X Description: Fixes #1809 Fixes #1811 This modifies Git.refresh to report the attempted Git command rather than always git even if a different command was used. This affects the command attribute of the GitComma...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1812

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78146605-2be7-a98b-5d18-47506721c16f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2E0:317EEC:1163A61:182191C:6968AFB5
html-safe-nonce5de77c5e2f6794a91cdf5bac3c5f7f16ecca92e06405b2e503d245cbfb22b812
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkUwOjMxN0VFQzoxMTYzQTYxOjE4MjE5MUM6Njk2OEFGQjUiLCJ2aXNpdG9yX2lkIjoiMzk4MTAxMTU4MzYzNzE3MjE1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3382e40024444deaee359262282eaffd77e9abaf5e505c220cd609fc1b9f7de
hovercard-subject-tagpull_request:1695213471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1812/files
twitter:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
og:image:altFixes #1809 Fixes #1811 This modifies Git.refresh to report the attempted Git command rather than always git even if a different command was used. This affects the command attribute of the GitComma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3223a6503d318917691422cdadfbe16cd8fb21e5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/1812/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1812%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1812%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1812/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1812/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1812/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:refresh-cmdlinehttps://github.com/EliahKagan/GitPython/tree/refresh-cmdline
Conversation 2 https://github.com/gitpython-developers/GitPython/pull/1812
Commits 10 https://github.com/gitpython-developers/GitPython/pull/1812/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/1812/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/1812/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
Report actual attempted Git command when Git.refresh fails https://github.com/gitpython-developers/GitPython/pull/1812/files#top
Show all changes 10 commits https://github.com/gitpython-developers/GitPython/pull/1812/files
ba4cbae Split test_refresh into two tests EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/ba4cbae2f5dcc417b5c09054b539d30b2ea1b33d
f241808 Simplify test of refresh that should succeed EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/f24180873b4fb7e8790e3f36e1d570f456565f42
f98aadd Have test of refresh that should fail assert command EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/f98aadddfe390348c2858690fec9577301ea9ba9
24d6067 Fix wrong GitCommandNotFound command from refresh EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/24d6067d9f2a3666d5812e98d6f6bb2bc7cce27f
3a34dee Also test refresh with an already-absolute bad path EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/3a34dee196c2cfb4873f161d17388847f9f1c1cc
5ad7cb2 Start work on making refresh tests restore state EliahKagan Jan 24, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/5ad7cb2f4eeff030b27e0ece3a308464cad415b8
b3fc30e Re-refresh to restore state after refresh tests EliahKagan Jan 25, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/b3fc30eeb476e6d76a292b5a58788efa576fb9a1
ae28c98 Refactor _rollback_refresh slightly for clarity EliahKagan Jan 25, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/ae28c986310703a83d0e2495e0e50530231040ee
3bb63f3 Condense FetchInfo.refresh using contextlib.suppress EliahKagan Jan 25, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/3bb63f3766605a597fa1dbca2367cb6ffda4a3ba
9b7e15f State what the refresh tests verify EliahKagan Jan 25, 2024 https://github.com/gitpython-developers/GitPython/pull/1812/commits/9b7e15f69186a61bc6413a6da0a1ea13776522bc
Clear filters https://github.com/gitpython-developers/GitPython/pull/1812/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
cmd.py https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
remote.py https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
test_git.py https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/1812/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/EliahKagan/GitPython/blob/9b7e15f69186a61bc6413a6da0a1ea13776522bc/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1812/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
git/remote.pyhttps://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
View file https://github.com/EliahKagan/GitPython/blob/9b7e15f69186a61bc6413a6da0a1ea13776522bc/git/remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1812/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-498082829601479324d7f95e72bd35bafafe74be1b0d8e1b7a42e181b08f3639
test/test_git.pyhttps://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
View file https://github.com/EliahKagan/GitPython/blob/9b7e15f69186a61bc6413a6da0a1ea13776522bc/test/test_git.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1812/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1812/files
https://github.com/gitpython-developers/GitPython/pull/1812/files#diff-84c4b72d5c62026240fad69041a453efc37f7336a89035b69672cce0e8beaca1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.